From nobody@FreeBSD.org  Mon May  5 19:40:45 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id E8409576
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  5 May 2014 19:40:45 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id BBD555ED8
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  5 May 2014 19:40:45 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s45JejlZ005466
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 5 May 2014 19:40:45 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s45Jejt4005462;
	Mon, 5 May 2014 19:40:45 GMT
	(envelope-from nobody)
Message-Id: <201405051940.s45Jejt4005462@cgiserv.freebsd.org>
Date: Mon, 5 May 2014 19:40:45 GMT
From: Rainer Hurling <rhurlin@gwdg.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] databases/mdbtools: fix build after r353029
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         189382
>Category:       ports
>Synopsis:       [PATCH] databases/mdbtools: fix build after r353029
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 05 19:50:00 UTC 2014
>Closed-Date:    Tue May 06 08:28:26 UTC 2014
>Last-Modified:  Tue May 06 08:28:26 UTC 2014
>Originator:     Rainer Hurling
>Release:        11.0-CURRENT amd64 (clang)
>Organization:
>Environment:
FreeBSD xxx.xxx.xxx 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r265310: Sun May  4 08:39:23 CEST 2014     xxx@xxx.xxx.xxx:/usr/obj/usr/src/sys/XXX  amd64
>Description:
After 'fixing unixODBC vs libiodbc conflicts' by bapt@ [1], databases/mdbtools does not build anymore. It tries to find include/sql.h from databases/libiodbc, which does not exist any more.

As a quick fix I changed the dependency from databases/libiodbc to databases/unixODBC. This builds and works fine, but on some boxes it now could be necessary to change the configuration file for odbc connections.


The plan for the near future will be to find a solution to also get libiodbc to work again with mdbtools. On success, I would like to make a knob to choose between the both database lib dependencies.



[1] http://svnweb.freebsd.org/ports?view=revision&revision=353029
>How-To-Repeat:
Try to build databases/mdbtools 0.7.1_1
>Fix:


Patch attached with submission follows:

diff -ur mdbtools.orig/Makefile mdbtools/Makefile
--- mdbtools.orig/Makefile	2014-05-05 18:47:42.000000000 +0200
+++ mdbtools/Makefile	2014-05-05 21:06:59.000000000 +0200
@@ -3,7 +3,7 @@
 
 PORTNAME=	mdbtools
 PORTVERSION=	0.7.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases
 MASTER_SITES=	https://github.com/brianb/mdbtools/archive/
 DISTNAME=	${PORTVERSION}
@@ -16,7 +16,7 @@
 # To build man-pages
 BUILD_DEPENDS=	gawk:${PORTSDIR}/lang/gawk \
 		txt2man:${PORTSDIR}/textproc/txt2man
-LIB_DEPENDS=	libiodbc.so:${PORTSDIR}/databases/libiodbc
+LIB_DEPENDS=	libodbc.so:${PORTSDIR}/databases/unixODBC
 
 USES=		bison pkgconfig iconv
 USE_AUTOTOOLS=	libtool autoconf automake
@@ -25,7 +25,7 @@
 WANT_GNOME=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--with-libiconv-prefix=${LOCALBASE} \
-		--with-iodbc=${LOCALBASE}
+		--with-unixodbc=${LOCALBASE}
 
 DOCS=		AUTHORS ChangeLog HACKING NEWS README TODO
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon May 5 19:50:07 UTC 2014 
Responsible-Changed-Why:  
sunpoet@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=189382 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/189382: commit references a PR
Date: Tue,  6 May 2014 07:32:22 +0000 (UTC)

 Author: bapt
 Date: Tue May  6 07:32:18 2014
 New Revision: 353075
 URL: http://svnweb.freebsd.org/changeset/ports/353075
 QAT: https://qat.redports.org/buildarchive/r353075/
 
 Log:
   Switch over to unixODBC to fix build after r353029
   
   PR:		ports/189382
   Submitted by:	Rainer Hurling <rhurlin@gwdg.de>
 
 Modified:
   head/databases/mdbtools/Makefile
 
 Modified: head/databases/mdbtools/Makefile
 ==============================================================================
 --- head/databases/mdbtools/Makefile	Tue May  6 07:29:10 2014	(r353074)
 +++ head/databases/mdbtools/Makefile	Tue May  6 07:32:18 2014	(r353075)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	mdbtools
  PORTVERSION=	0.7.1
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	databases
  MASTER_SITES=	https://github.com/brianb/mdbtools/archive/
  DISTNAME=	${PORTVERSION}
 @@ -16,7 +16,7 @@ LICENSE=	GPLv2
  # To build man-pages
  BUILD_DEPENDS=	gawk:${PORTSDIR}/lang/gawk \
  		txt2man:${PORTSDIR}/textproc/txt2man
 -LIB_DEPENDS=	libiodbc.so:${PORTSDIR}/databases/libiodbc
 +LIB_DEPENDS=	libodbc.so:${PORTSDIR}/databases/unixODBC
  
  USES=		bison pkgconfig iconv
  USE_AUTOTOOLS=	libtool autoconf automake
 @@ -25,7 +25,7 @@ USE_GNOME=	glib20
  WANT_GNOME=	yes
  GNU_CONFIGURE=	yes
  CONFIGURE_ARGS=	--with-libiconv-prefix=${LOCALBASE} \
 -		--with-iodbc=${LOCALBASE}
 +		--with-unixodbc=${LOCALBASE}
  
  DOCS=		AUTHORS ChangeLog HACKING NEWS README TODO
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: bapt 
State-Changed-When: Tue May 6 08:28:24 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=189382 
>Unformatted:
