From kibab@olymp.kibab.com  Mon Apr 28 14:52:03 2014
Return-Path: <kibab@olymp.kibab.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id B203118B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Apr 2014 14:52:03 +0000 (UTC)
Received: from olymp.kibab.com (olymp6.kibab.com [IPv6:2a01:4f8:160:84c1::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 775F217EB
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Apr 2014 14:52:03 +0000 (UTC)
Message-Id: <20140428145155.684933F461@olymp.kibab.com>
Date: Mon, 28 Apr 2014 16:51:55 +0200 (CEST)
From: Ilya Bakulin <webmaster@kibab.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] devel/php5-thrift: Unbreak build
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         189076
>Category:       ports
>Synopsis:       [MAINTAINER] devel/php5-thrift: Unbreak build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 28 15:00:00 UTC 2014
>Closed-Date:    Thu May 22 09:37:53 UTC 2014
>Last-Modified:  Thu May 22 09:40:01 UTC 2014
>Originator:     Ilya Bakulin
>Release:        FreeBSD 9.1-RELEASE-p11 amd64
>Organization:
Deglitch Networks
>Environment:
System: FreeBSD olymp.kibab.com 9.1-RELEASE-p11 FreeBSD 9.1-RELEASE-p11 #0: Tue Apr  8 20:54:56 UTC
>Description:
For some unknown reason, the configuration file for creating PHP extension
is missing in the distfile. Add it manually.

Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- php5-thrift-0.9.1.patch begins here ---
diff -ruN /usr/ports/devel/php5-thrift/Makefile ./Makefile
--- /usr/ports/devel/php5-thrift/Makefile	2014-02-22 11:00:42.000000000 +0100
+++ ./Makefile	2014-04-28 16:20:00.000000000 +0200
@@ -6,21 +6,20 @@
 CATEGORIES=	devel
 PKGNAMEPREFIX=	php5-
 DISTFILES=	# empty
+
 MAINTAINER=	webmaster@kibab.com
 COMMENT=	PHP interface to Thrift
 
-BROKEN=		Fails to configure
-
 FETCH_DEPENDS+=	${NONEXISTENT}:${PORTSDIR}/devel/thrift:extract
 
 USE_PHP=	yes
+
 USE_PHPIZE=	yes
 USE_PHPEXT=	yes
 PHP_MODNAME=	thrift_protocol
 
 WRKSRC=		${WRKDIR}/php/src/ext/thrift_protocol
 
-NO_STAGE=	yes
 post-extract:
 	${LN} -sfh \
 		`${MAKE} -C ${PORTSDIR}/devel/thrift -V WRKSRC`/lib/php \
diff -ruN /usr/ports/devel/php5-thrift/files/patch-php-src-ext-thrift_protocol-config.m4 ./files/patch-php-src-ext-thrift_protocol-config.m4
--- /usr/ports/devel/php5-thrift/files/patch-php-src-ext-thrift_protocol-config.m4	1970-01-01 01:00:00.000000000 +0100
+++ ./files/patch-php-src-ext-thrift_protocol-config.m4	2014-04-28 16:16:19.000000000 +0200
@@ -0,0 +1,17 @@
+--- /dev/null	1970-01-01 01:00:00.000000000 +0100
++++ config.m4	2014-04-28 15:50:27.000000000 +0200
+@@ -0,0 +1,14 @@
++dnl Copyright (C) 2009 Facebook
++dnl Copying and distribution of this file, with or without modification,
++dnl are permitted in any medium without royalty provided the copyright
++dnl notice and this notice are preserved.
++
++PHP_ARG_ENABLE(thrift_protocol, whether to enable the thrift_protocol extension,
++[  --enable-thrift_protocol	Enable the fbthrift_protocol extension])
++
++if test "$PHP_THRIFT_PROTOCOL" != "no"; then
++  PHP_REQUIRE_CXX()
++  PHP_ADD_LIBRARY_WITH_PATH(stdc++, "", THRIFT_PROTOCOL_SHARED_LIBADD)
++  PHP_SUBST(THRIFT_PROTOCOL_SHARED_LIBADD)
++  PHP_NEW_EXTENSION(thrift_protocol, php_thrift_protocol.cpp, $ext_shared)
++fi
--- php5-thrift-0.9.1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Thu May 22 09:37:52 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=189076 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/189076: commit references a PR
Date: Thu, 22 May 2014 09:37:43 +0000 (UTC)

 Author: miwi
 Date: Thu May 22 09:37:35 2014
 New Revision: 354810
 URL: http://svnweb.freebsd.org/changeset/ports/354810
 QAT: https://qat.redports.org/buildarchive/r354810/
 
 Log:
   - Fix build
   
   PR:		189076
   Submitted by:	Ilya Bakulin <webmaster@kibab.com> (maintainer)
 
 Added:
   head/devel/php5-thrift/files/
   head/devel/php5-thrift/files/patch-php-src-ext-thrift_protocol-config.m4   (contents, props changed)
 Modified:
   head/devel/php5-thrift/Makefile
 
 Modified: head/devel/php5-thrift/Makefile
 ==============================================================================
 --- head/devel/php5-thrift/Makefile	Thu May 22 09:37:25 2014	(r354809)
 +++ head/devel/php5-thrift/Makefile	Thu May 22 09:37:35 2014	(r354810)
 @@ -6,21 +6,20 @@ PORTVERSION=	${THRIFT_PORTVERSION}
  CATEGORIES=	devel
  PKGNAMEPREFIX=	php5-
  DISTFILES=	# empty
 +
  MAINTAINER=	webmaster@kibab.com
  COMMENT=	PHP interface to Thrift
  
 -BROKEN=		Fails to configure
 -
  FETCH_DEPENDS+=	${NONEXISTENT}:${PORTSDIR}/devel/thrift:extract
  
  USE_PHP=	yes
 +
  USE_PHPIZE=	yes
  USE_PHPEXT=	yes
  PHP_MODNAME=	thrift_protocol
  
  WRKSRC=		${WRKDIR}/php/src/ext/thrift_protocol
  
 -NO_STAGE=	yes
  post-extract:
  	${LN} -sfh \
  		`${MAKE} -C ${PORTSDIR}/devel/thrift -V WRKSRC`/lib/php \
 
 Added: head/devel/php5-thrift/files/patch-php-src-ext-thrift_protocol-config.m4
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/devel/php5-thrift/files/patch-php-src-ext-thrift_protocol-config.m4	Thu May 22 09:37:35 2014	(r354810)
 @@ -0,0 +1,17 @@
 +--- /dev/null	1970-01-01 01:00:00.000000000 +0100
 ++++ config.m4	2014-04-28 15:50:27.000000000 +0200
 +@@ -0,0 +1,14 @@
 ++dnl Copyright (C) 2009 Facebook
 ++dnl Copying and distribution of this file, with or without modification,
 ++dnl are permitted in any medium without royalty provided the copyright
 ++dnl notice and this notice are preserved.
 ++
 ++PHP_ARG_ENABLE(thrift_protocol, whether to enable the thrift_protocol extension,
 ++[  --enable-thrift_protocol	Enable the fbthrift_protocol extension])
 ++
 ++if test "$PHP_THRIFT_PROTOCOL" != "no"; then
 ++  PHP_REQUIRE_CXX()
 ++  PHP_ADD_LIBRARY_WITH_PATH(stdc++, "", THRIFT_PROTOCOL_SHARED_LIBADD)
 ++  PHP_SUBST(THRIFT_PROTOCOL_SHARED_LIBADD)
 ++  PHP_NEW_EXTENSION(thrift_protocol, php_thrift_protocol.cpp, $ext_shared)
 ++fi
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
