From nobody@FreeBSD.org  Sun Apr 27 15:34:46 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id B67D9251
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Apr 2014 15:34:46 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id A2BCBEB
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Apr 2014 15:34:46 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s3RFYkTh097921
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Apr 2014 15:34:46 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s3RFYjEn097908;
	Sun, 27 Apr 2014 15:34:45 GMT
	(envelope-from nobody)
Message-Id: <201404271534.s3RFYjEn097908@cgiserv.freebsd.org>
Date: Sun, 27 Apr 2014 15:34:45 GMT
From: "A.J. van Werven" <freebsd@skysmurf.nl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] games/oneko fails to build with Clang
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: candy@kgc.co.jp

>Number:         189050
>Category:       ports
>Synopsis:       [PATCH] games/oneko fails to build with Clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          feedback
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 27 15:40:02 UTC 2014
>Closed-Date:    
>Last-Modified:  Sun Apr 27 15:50:00 UTC 2014
>Originator:     A.J. van Werven
>Release:        9.1-RELEASE-p3
>Organization:
>Environment:
>Description:
The games/oneko port fails to build on FreeBSD 9.1-RELEASE-p3/amd64, if Clang is used as the compiler.

The function NekoChangeVisibility() in event.c does not have a return type specified. It is therefore assumed to return int, while it doesn't actually return anything. Explicitly specifying this function to be of type void fixes the problem.
>How-To-Repeat:
# portmaster games/oneko
(On a system that uses Clang, I didn't try with GCC.)
>Fix:
Apply the supplied patch to event.c.

Please note: the port's Makefile explicitly specifies a do-patch target, so the Makefile will probably have to be updated as well, in order to make sure the patch actually gets applied.

Patch attached with submission follows:

--- event.c.bak	2014-04-27 16:54:53.000000000 +0200
+++ event.c	2014-04-27 16:55:20.000000000 +0200
@@ -230,6 +230,7 @@
 }
 #endif	/* SENDER */
 
+void
 NekoChangeVisibility(window)
 Window window;
 {


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Apr 27 15:40:06 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=189050 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: candy@kgc.co.jp
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/189050: [PATCH] games/oneko fails to build with Clang
Date: Sun, 27 Apr 2014 15:40:05 UT

 Maintainer of games/oneko,
 
 Please note that PR ports/189050 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189050
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
>Unformatted:
