From nobody@FreeBSD.org  Thu Apr 24 03:25:14 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id D8B29657
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Apr 2014 03:25:14 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id AC15F1C2D
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Apr 2014 03:25:14 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s3O3PDwQ059169
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Apr 2014 03:25:13 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s3O3PC8v059140;
	Thu, 24 Apr 2014 03:25:12 GMT
	(envelope-from nobody)
Message-Id: <201404240325.s3O3PC8v059140@cgiserv.freebsd.org>
Date: Thu, 24 Apr 2014 03:25:12 GMT
From: Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
To: freebsd-gnats-submit@FreeBSD.org
Subject: notify-osd-0.9.29_6 doesn't compile
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         188940
>Category:       ports
>Synopsis:       deskutils/notify-osd 0.9.29_6 doesn't compile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ehaupt
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 24 03:30:00 UTC 2014
>Closed-Date:    Fri Apr 25 09:18:08 CEST 2014
>Last-Modified:  Fri Apr 25 09:18:08 CEST 2014
>Originator:     Walter Schwarzenfeld
>Release:        
>Organization:
>Environment:
FreeBSD 9.2-RELEASE-p4
>Description:
/usr/local/bin/ld: test_raico-gaussian-blur.o: undefined reference to symbol 'exp@@FBSD_1.0'
//lib/libm.so.5: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
gmake[2]: *** [test-modules] Error 1

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Apr 24 03:41:16 UTC 2014 
Responsible-Changed-Why:  
ports PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188940 
Responsible-Changed-From-To: freebsd-ports-bugs->ehaupt 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Apr 24 03:41:48 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188940 

From: Tijl Coosemans <tijl@FreeBSD.org>
To: bug-followup@FreeBSD.org, w.schwarzenfeld@utanet.at
Cc:  
Subject: Re: ports/188940: deskutils/notify-osd 0.9.29_6 doesn&#39;t compile
Date: Thu, 24 Apr 2014 11:24:53 +0200

 --MP_/tGjcKoKPcdOBh_maCgMTCPq
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 This patch should fix it.  Please give it a try.
 It disables the tests subdirectory which also allows removing USE_GCC.
 --MP_/tGjcKoKPcdOBh_maCgMTCPq
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=notify-osd.patch
 
 Index: deskutils/notify-osd/Makefile
 ===================================================================
 --- deskutils/notify-osd/Makefile	(revision 351984)
 +++ deskutils/notify-osd/Makefile	(working copy)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	notify-osd
  PORTVERSION=	0.9.29
 -PORTREVISION=	6
 +PORTREVISION=	7
  CATEGORIES=	deskutils
  MASTER_SITES=	http://launchpadlibrarian.net/43419242/ \
  		CRITICAL
 @@ -23,8 +23,16 @@ GNU_CONFIGURE=	yes
  USES=		gmake libtool pkgconfig
  USE_GNOME=	libwnck gconf2
  USE_XORG=	pixman
 -USE_GCC=	yes
  
  LDFLAGS+=	-L${LOCALBASE}/lib -lpixman-1
  
 +.include <bsd.port.options.mk>
 +
 +post-patch:
 +	@${REINPLACE_CMD} '/SUBDIRS =/s/tests//' ${WRKSRC}/Makefile.in
 +.if ${OSVERSION} < 900033
 +	@${REINPLACE_CMD} 's/-Bsymbolic-functions/-Bsymbolic/' \
 +		${WRKSRC}/src/Makefile.in
 +.endif
 +
  .include <bsd.port.mk>
 Index: deskutils/notify-osd/files/patch-tests_test-synchronous.c
 ===================================================================
 --- deskutils/notify-osd/files/patch-tests_test-synchronous.c	(revision 351984)
 +++ deskutils/notify-osd/files/patch-tests_test-synchronous.c	(working copy)
 @@ -1,21 +0,0 @@
 ---- tests/test-synchronous.c.orig	2011-08-16 13:55:36.000000000 +0200
 -+++ tests/test-synchronous.c	2011-08-16 13:56:05.000000000 +0200
 -@@ -38,7 +38,7 @@ send_normal (const gchar *message)
 -         NotifyNotification *n;
 - 	n = notify_notification_new ("Test notification",
 - 				     g_strdup (message),
 --				     "", NULL);
 -+				     "");
 - 	notify_notification_show (n, NULL);
 - 	g_object_unref(G_OBJECT(n));
 - }
 -@@ -53,8 +53,7 @@ send_synchronous (const char *type,
 - 	if (n == NULL)
 - 		n = notify_notification_new (" ",
 - 					     "",
 --					     g_strdup (icon),
 --					     NULL);
 -+					     g_strdup (icon));
 - 	else
 - 		notify_notification_update (n,
 - 					    " ",
 Index: deskutils/notify-osd/files/patch-tests_test-withlib.c
 ===================================================================
 --- deskutils/notify-osd/files/patch-tests_test-withlib.c	(revision 351984)
 +++ deskutils/notify-osd/files/patch-tests_test-withlib.c	(working copy)
 @@ -1,113 +0,0 @@
 ---- tests/test-withlib.c.orig	2011-08-16 13:52:38.000000000 +0200
 -+++ tests/test-withlib.c	2011-08-16 13:54:51.000000000 +0200
 -@@ -94,7 +94,7 @@ test_withlib_show_notification (void)
 - 
 - 	n = notify_notification_new ("Test",
 - 				     "You should see a normal notification",
 --				     "", NULL);
 -+				     "");
 - 	notify_notification_show (n, NULL);
 - 	sleep (3);
 - 
 -@@ -109,7 +109,7 @@ test_withlib_update_notification (void)
 - 
 - 	n = notify_notification_new ("Test",
 - 				     "New notification",
 --				     "", NULL);
 -+				     "");
 - 	res = notify_notification_show (n, NULL);
 - 	g_assert (res);
 - 	sleep (1);
 -@@ -135,7 +135,7 @@ test_withlib_pass_icon_data (void)
 - 
 - 	n = notify_notification_new ("Image Test",
 - 				     "You should see an image",
 --				     "", NULL);
 -+				     "");
 - 	g_print ("iconpath: %s\n", SRCDIR"/icons/avatar.png");
 - 	pixbuf = gdk_pixbuf_new_from_file_at_scale (SRCDIR"/icons/avatar.png",
 - 						    64, 64, TRUE, NULL);
 -@@ -157,22 +157,22 @@ test_withlib_priority (void)
 - 
 - 	n1 = notify_notification_new ("Dummy Notification",
 - 				      "This is a test notification",
 --				      "", NULL);
 -+				      "");
 - 	notify_notification_show (n1, NULL);
 - 	n2 = notify_notification_new ("Normal Notification",
 - 				      "You should see this *after* the urgent notification.",
 --				      "", NULL);
 -+				      "");
 - 	notify_notification_set_urgency (n2, NOTIFY_URGENCY_LOW);
 - 	notify_notification_show (n2, NULL);
 - 	n3 = notify_notification_new ("Synchronous Notification",
 - 				      "You should immediately see this notification.",
 --				      "", NULL);
 -+				      "");
 - 	notify_notification_set_hint_string (n3, "synchronous", "test");
 - 	notify_notification_set_urgency (n3, NOTIFY_URGENCY_NORMAL);
 - 	notify_notification_show (n3, NULL);
 - 	n4 = notify_notification_new ("Urgent Notification",
 - 				      "You should see a dialog box, and after, a normal notification.",
 --				      "", NULL);
 -+				      "");
 - 	notify_notification_set_urgency (n4, NOTIFY_URGENCY_CRITICAL);
 - 	notify_notification_show (n4, NULL);
 - 	
 -@@ -207,7 +207,7 @@ test_withlib_actions (void)
 - 
 - 	n1 = notify_notification_new ("Notification with an action",
 - 				      "You should see that in a dialog box. Click the 'Action' button for the test to succeed.",
 --				      "", NULL);
 -+				      "");
 - 	notify_notification_add_action (n1,
 - 					"action",
 - 					"Action",
 -@@ -231,7 +231,7 @@ test_withlib_close_notification (void)
 - 
 - 	n = notify_notification_new ("Test Title",
 - 				     "This notification will be closed prematurely...",
 --				     "", NULL);
 -+				     "");
 - 	notify_notification_show (n, NULL);
 - 	
 - 	loop = g_main_loop_new(NULL, FALSE);
 -@@ -256,8 +256,7 @@ test_withlib_append_hint (void)
 - 	/* init notification, supply first line of body-text */
 - 	n = notify_notification_new ("Test (append-hint)",
 - 				     "The quick brown fox jumps over the lazy dog.",
 --				     SRCDIR"/icons/avatar.png",
 --				     NULL);
 -+				     SRCDIR"/icons/avatar.png");
 - 	res = notify_notification_show (n, NULL);
 - 	g_assert (res);
 - 	sleep (1);
 -@@ -296,8 +295,7 @@ test_withlib_icon_only_hint (void)
 - 	/* init notification, supply first line of body-text */
 - 	n = notify_notification_new (" ", /* needs this to be non-NULL */
 - 				     NULL,
 --				     "notification-audio-play",
 --				     NULL);
 -+				     "notification-audio-play");
 - 	notify_notification_set_hint_string (n, "icon-only", "allowed");
 - 	res = notify_notification_show (n, NULL);
 - 	g_assert (res);
 -@@ -314,8 +312,7 @@ test_withlib_swallow_markup (void)
 - 
 - 	n = notify_notification_new ("Swallow markup test",
 - 				     "This text is hopefully neither <b>bold</b>, <i>italic</i> nor <u>underlined</u>.\n\nA little math-notation:\n\n\ta &gt; b &lt; c = 0",
 --				     SRCDIR"/icons/avatar.png",
 --				     NULL);
 -+				     SRCDIR"/icons/avatar.png");
 - 	res = notify_notification_show (n, NULL);
 - 	g_assert (res);
 - 	sleep (2);
 -@@ -341,7 +338,7 @@ test_withlib_throttle (void)
 - 
 - 		// create dummy notification
 - 		snprintf (buf, 19, "Test #%.2d", i);
 --		n = notify_notification_new (buf, buf, "", NULL);
 -+		n = notify_notification_new (buf, buf, "");
 - 
 - 		// inject it into the queue
 - 		res = notify_notification_show (n, &error);
 
 --MP_/tGjcKoKPcdOBh_maCgMTCPq--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/188940: commit references a PR
Date: Thu, 24 Apr 2014 14:00:32 +0000 (UTC)

 Author: ehaupt
 Date: Thu Apr 24 14:00:29 2014
 New Revision: 352004
 URL: http://svnweb.freebsd.org/changeset/ports/352004
 QAT: https://qat.redports.org/buildarchive/r352004/
 
 Log:
   Fix build on 9.2 and remove dependency to gcc [1].
   
   PR:		188940
   Submitted by:	tijl [1]
   Reported by:	Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
 
 Deleted:
   head/deskutils/notify-osd/files/
 Modified:
   head/deskutils/notify-osd/Makefile
 
 Modified: head/deskutils/notify-osd/Makefile
 ==============================================================================
 --- head/deskutils/notify-osd/Makefile	Thu Apr 24 13:25:51 2014	(r352003)
 +++ head/deskutils/notify-osd/Makefile	Thu Apr 24 14:00:29 2014	(r352004)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	notify-osd
  PORTVERSION=	0.9.29
 -PORTREVISION=	6
 +PORTREVISION=	7
  CATEGORIES=	deskutils
  MASTER_SITES=	http://launchpadlibrarian.net/43419242/ \
  		CRITICAL
 @@ -23,8 +23,16 @@ GNU_CONFIGURE=	yes
  USES=		gmake libtool pkgconfig
  USE_GNOME=	libwnck gconf2
  USE_XORG=	pixman
 -USE_GCC=	yes
  
  LDFLAGS+=	-L${LOCALBASE}/lib -lpixman-1
  
 +.include <bsd.port.options.mk>
 +
 +post-patch:
 +	@${REINPLACE_CMD} '/SUBDIRS =/s/tests//' ${WRKSRC}/Makefile.in
 +.if ${OSVERSION} < 900033
 +	@${REINPLACE_CMD} 's/-Bsymbolic-functions/-Bsymbolic/' \
 +		${WRKSRC}/src/Makefile.in
 +.endif
 +
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: ehaupt 
State-Changed-When: Fri Apr 25 09:18:06 CEST 2014 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188940 
>Unformatted:
