From jhein@symmetricom.com  Fri Apr 18 18:56:30 2014
Return-Path: <jhein@symmetricom.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 9E344EA5;
	Fri, 18 Apr 2014 18:56:30 +0000 (UTC)
Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214])
	by mx1.freebsd.org (Postfix) with ESMTP id 5861312D1;
	Fri, 18 Apr 2014 18:56:29 +0000 (UTC)
Received: from gromit.timing.com (gromit.timing.com [206.168.13.209])
	by duck.symmetricom.us (8.14.6/8.14.6) with ESMTP id s3IIuLXg077337;
	Fri, 18 Apr 2014 12:56:21 -0600 (MDT)
	(envelope-from jhein@symmetricom.com)
Received: from gromit.timing.com (localhost [127.0.0.1])
	by gromit.timing.com (8.14.7/8.14.5) with ESMTP id s3IIuKGt049233;
	Fri, 18 Apr 2014 12:56:21 -0600 (MDT)
	(envelope-from jhein@gromit.timing.com)
Received: (from jhein@localhost)
	by gromit.timing.com (8.14.7/8.14.7/Submit) id s3IIuF6t049232;
	Fri, 18 Apr 2014 12:56:15 -0600 (MDT)
	(envelope-from jhein)
Message-Id: <201404181856.s3IIuF6t049232@gromit.timing.com>
Date: Fri, 18 Apr 2014 12:56:15 -0600 (MDT)
From: John Hein <john.hein@microsemi.com>
Reply-To: John Hein <john.hein@microsemi.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: doceng@freebsd.org
Subject: [patch] print/ghostcript9 - remove unecessary chown & fix stage as non-root
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         188770
>Category:       ports
>Synopsis:       [patch] print/ghostcript9 - remove unecessary chown & fix stage as non-root
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    doceng
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 18 19:00:00 UTC 2014
>Closed-Date:    Mon Apr 28 16:23:02 UTC 2014
>Last-Modified:  Mon Apr 28 16:30:00 UTC 2014
>Originator:     John Hein
>Release:        
>Organization:
>Environment:

>Description:

The ${CHOWN} in the post-install in print/ghostscript9/Makefile is not
needed - the created package specifies @owner root for packages that
have been created via the staging process.

I also moved the strip from post-install to 'install -s' in the make
infrastructure.  This allows 'make stage' as a regular user (otherwise,
you get 'permission denied' trying to strip a read-only file - noticed
when using portmaster with PM_SU_CMD=/usr/local/bin/sudo).

I didn't add a strip for the shared lib since we usually don't do
that for ports and that would be a change of behavior.


>How-To-Repeat:

>Fix:

No need to bump portrevision.

Index: Makefile
===================================================================
--- Makefile	(revision 351530)
+++ Makefile	(working copy)
@@ -162,8 +162,6 @@
 		( cd ${STAGEDIR}${DOCSDIR} && ${TAR} -xof - )
 
 post-install:
-	${CHOWN} -R ${SHAREOWN}:${SHAREGRP} ${STAGEDIR}${DATADIR}/${PORTVERSION}
-	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/gsc ${STAGEDIR}${PREFIX}/bin/gsx
 	${LN} -sf gsc ${STAGEDIR}${PREFIX}/bin/gs
 	${LN} -s -f ${LOCALBASE}/share/fonts/CIDFont \
 		${STAGEDIR}${DATADIR}/${PORTVERSION}/Resource/CIDFont/fonts
Index: files/patch-base-unix-dll.mak
===================================================================
--- files/patch-base-unix-dll.mak	(revision 0)
+++ files/patch-base-unix-dll.mak	(working copy)
@@ -0,0 +1,13 @@
+--- base/unix-dll.mak.orig	2012-08-08 02:01:36.000000000 -0600
++++ base/unix-dll.mak	2014-04-18 12:12:34.000000000 -0600
+@@ -162,8 +162,8 @@
+ 	-mkdir -p $(DESTDIR)$(bindir)
+ 	-mkdir -p $(DESTDIR)$(libdir)
+ 	-mkdir -p $(DESTDIR)$(gsincludedir)
+-	$(INSTALL_PROGRAM) $(GSSOC) $(DESTDIR)$(bindir)/$(GSSOC_XENAME)
+-	$(INSTALL_PROGRAM) $(GSSOX) $(DESTDIR)$(bindir)/$(GSSOX_XENAME)
++	$(INSTALL_PROGRAM) -s $(GSSOC) $(DESTDIR)$(bindir)/$(GSSOC_XENAME)
++	$(INSTALL_PROGRAM) -s $(GSSOX) $(DESTDIR)$(bindir)/$(GSSOX_XENAME)
+ 	$(INSTALL_PROGRAM) $(BINDIR)/$(GS_SONAME_MAJOR_MINOR) $(DESTDIR)$(libdir)/$(GS_SONAME_MAJOR_MINOR)
+ 	$(RM_) $(DESTDIR)$(libdir)/$(GS_SONAME)
+ 	ln -s $(GS_SONAME_MAJOR_MINOR) $(DESTDIR)$(libdir)/$(GS_SONAME)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->doceng 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Apr 20 17:09:37 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188770 
State-Changed-From-To: open->closed 
State-Changed-By: mat 
State-Changed-When: Mon Apr 28 16:23:01 UTC 2014 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188770 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/188770: commit references a PR
Date: Mon, 28 Apr 2014 16:22:53 +0000 (UTC)

 Author: mat
 Date: Mon Apr 28 16:22:49 2014
 New Revision: 352522
 URL: http://svnweb.freebsd.org/changeset/ports/352522
 QAT: https://qat.redports.org/buildarchive/r352522/
 
 Log:
   Fix build as a user, really this time.
   
   PR:		188770
   Submitted by:	John Hein
   Sponsored by:	Absolight
 
 Added:
   head/print/ghostscript9/files/patch-base-unix-dll.mak   (contents, props changed)
 Modified:
   head/print/ghostscript9/Makefile
 
 Modified: head/print/ghostscript9/Makefile
 ==============================================================================
 --- head/print/ghostscript9/Makefile	Mon Apr 28 16:22:28 2014	(r352521)
 +++ head/print/ghostscript9/Makefile	Mon Apr 28 16:22:49 2014	(r352522)
 @@ -162,7 +162,6 @@ post-install-docs:
  		( cd ${STAGEDIR}${DOCSDIR} && ${TAR} -xof - )
  
  post-install:
 -	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/gsc ${STAGEDIR}${PREFIX}/bin/gsx
  	${LN} -sf gsc ${STAGEDIR}${PREFIX}/bin/gs
  	${LN} -s -f ${LOCALBASE}/share/fonts/CIDFont \
  		${STAGEDIR}${DATADIR}/${PORTVERSION}/Resource/CIDFont/fonts
 
 Added: head/print/ghostscript9/files/patch-base-unix-dll.mak
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/print/ghostscript9/files/patch-base-unix-dll.mak	Mon Apr 28 16:22:49 2014	(r352522)
 @@ -0,0 +1,13 @@
 +--- base/unix-dll.mak.orig	2012-08-08 02:01:36.000000000 -0600
 ++++ base/unix-dll.mak	2014-04-18 12:12:34.000000000 -0600
 +@@ -162,8 +162,8 @@
 + 	-mkdir -p $(DESTDIR)$(bindir)
 + 	-mkdir -p $(DESTDIR)$(libdir)
 + 	-mkdir -p $(DESTDIR)$(gsincludedir)
 +-	$(INSTALL_PROGRAM) $(GSSOC) $(DESTDIR)$(bindir)/$(GSSOC_XENAME)
 +-	$(INSTALL_PROGRAM) $(GSSOX) $(DESTDIR)$(bindir)/$(GSSOX_XENAME)
 ++	$(INSTALL_PROGRAM) -s $(GSSOC) $(DESTDIR)$(bindir)/$(GSSOC_XENAME)
 ++	$(INSTALL_PROGRAM) -s $(GSSOX) $(DESTDIR)$(bindir)/$(GSSOX_XENAME)
 + 	$(INSTALL_PROGRAM) $(BINDIR)/$(GS_SONAME_MAJOR_MINOR) $(DESTDIR)$(libdir)/$(GS_SONAME_MAJOR_MINOR)
 + 	$(RM_) $(DESTDIR)$(libdir)/$(GS_SONAME)
 + 	ln -s $(GS_SONAME_MAJOR_MINOR) $(DESTDIR)$(libdir)/$(GS_SONAME)
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
