From jhein@symmetricom.com  Tue Apr 15 19:17:57 2014
Return-Path: <jhein@symmetricom.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 07A5767A;
	Tue, 15 Apr 2014 19:17:57 +0000 (UTC)
Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214])
	by mx1.freebsd.org (Postfix) with ESMTP id B4840123D;
	Tue, 15 Apr 2014 19:17:56 +0000 (UTC)
Received: from gromit.timing.com (gromit.timing.com [206.168.13.209])
	by duck.symmetricom.us (8.14.6/8.14.6) with ESMTP id s3FJHmvv029838;
	Tue, 15 Apr 2014 13:17:48 -0600 (MDT)
	(envelope-from jhein@symmetricom.com)
Received: from gromit.timing.com (localhost [127.0.0.1])
	by gromit.timing.com (8.14.7/8.14.5) with ESMTP id s3FJHmHl028411;
	Tue, 15 Apr 2014 13:17:48 -0600 (MDT)
	(envelope-from jhein@gromit.timing.com)
Received: (from jhein@localhost)
	by gromit.timing.com (8.14.7/8.14.7/Submit) id s3FJHmYF028410;
	Tue, 15 Apr 2014 13:17:48 -0600 (MDT)
	(envelope-from jhein)
Message-Id: <201404151917.s3FJHmYF028410@gromit.timing.com>
Date: Tue, 15 Apr 2014 13:17:48 -0600 (MDT)
From: John Hein <john.hein@microsemi.com>
Reply-To: John Hein <john.hein@microsemi.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: gnome@freebsd.org
Subject: [patch] update devel/seed (2.31.91) to build with both new and older readline
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         188670
>Category:       ports
>Synopsis:       [patch] update devel/seed (2.31.91) to build with both new and older readline
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 15 19:20:00 UTC 2014
>Closed-Date:    Tue Apr 29 21:06:41 UTC 2014
>Last-Modified:  Tue Apr 29 21:10:01 UTC 2014
>Originator:     John Hein
>Release:        
>Organization:
>Environment:
System:


>Description:

If the devel/readline (6.3+) port is installed, you can get build
errors with devel/seed (currently 2.31.91_4).

gmake[3]: Entering directory `/d/pub/jhein/.no-amanda-backup/wd/usr/ports/devel/seed/work/seed-2.31.91/modules/readline'
  CC     libseed_readline_la-seed-readline.lo
seed-readline.c: In function 'seed_readline_bind':
seed-readline.c:80: error: 'Function' undeclared (first use in this function)
seed-readline.c:80: error: (Each undeclared identifier is reported only once
seed-readline.c:80: error: for each function it appears in.)
seed-readline.c:80: error: expected expression before ')' token


>How-To-Repeat:

install devel/readline (6.3.3)
try to build devel/seed (2.31.91_4)

>Fix:

Index: devel/seed/files/patch-modules_readline_seed-readline.c
===================================================================
--- devel/seed/files/patch-modules_readline_seed-readline.c	(revision 0)
+++ devel/seed/files/patch-modules_readline_seed-readline.c	(working copy)
@@ -0,0 +1,16 @@
+'Function' is deprecated - patch to work with older readline API
+(e.g., currently in base) or new (e.g., readline 6.3.3 in ports).
+
+http://lists.gnu.org/archive/html/bug-readline/2014-03/msg00002.html
+
+--- modules/readline/seed-readline.c.orig	2010-08-30 15:37:39.000000000 -0600
++++ modules/readline/seed-readline.c	2014-04-15 13:00:13.000000000 -0600
+@@ -77,7 +77,7 @@
+   key = seed_value_to_string(ctx, arguments[0], exception);
+   c = seed_make_rl_closure((SeedObject) arguments[1]);
+ 
+-  rl_bind_key(*key, (Function *) c);
++  rl_bind_key(*key, (rl_command_func_t *) c);
+ 
+   g_free(key);
+ 

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Apr 15 19:20:04 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188670 
State-Changed-From-To: open->closed 
State-Changed-By: kwm 
State-Changed-When: Tue Apr 29 21:06:18 UTC 2014 
State-Changed-Why:  
Committed thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188670 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/188670: commit references a PR
Date: Tue, 29 Apr 2014 21:05:48 +0000 (UTC)

 Author: kwm
 Date: Tue Apr 29 21:05:43 2014
 New Revision: 352643
 URL: http://svnweb.freebsd.org/changeset/ports/352643
 QAT: https://qat.redports.org/buildarchive/r352643/
 
 Log:
   Fix the build with readline from ports.
   
   PR:		ports/188670 [1]
   		ports/187883 [2]
   Submitted by:	John Hein <john.hein@microsemi.com> [1]
   		truckman@
 
 Added:
   head/devel/seed/files/patch-modules_readline_seed-readline.c   (contents, props changed)
 
 Added: head/devel/seed/files/patch-modules_readline_seed-readline.c
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/devel/seed/files/patch-modules_readline_seed-readline.c	Tue Apr 29 21:05:43 2014	(r352643)
 @@ -0,0 +1,15 @@
 +'Function' is deprecated - patch to work with older readline API
 +(e.g., currently in base) or new (e.g., readline 6.3.3 in ports).
 +
 +http://lists.gnu.org/archive/html/bug-readline/2014-03/msg00002.html
 +
 +--- modules/readline/seed-readline.c.orig	2010-08-30 15:37:39.000000000 -0600
 ++++ modules/readline/seed-readline.c	2014-04-15 13:00:13.000000000 -0600
 +@@ -77,7 +77,7 @@
 +   key = seed_value_to_string(ctx, arguments[0], exception);
 +   c = seed_make_rl_closure((SeedObject) arguments[1]);
 + 
 +-  rl_bind_key(*key, (Function *) c);
 ++  rl_bind_key(*key, (rl_command_func_t *) c);
 + 
 +   g_free(key);
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
