From banshee@gabriella.abattoir.com  Mon Apr 14 23:00:40 2014
Return-Path: <banshee@gabriella.abattoir.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 25F88AC0
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Apr 2014 23:00:40 +0000 (UTC)
Received: from gabriella.abattoir.com (70-36-157-19.static.sonic.net [70.36.157.19])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 02ABD1848
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Apr 2014 23:00:39 +0000 (UTC)
Received: from gabriella.abattoir.com (localhost [127.0.0.1])
	by gabriella.abattoir.com (8.14.7/8.14.7) with ESMTP id s3EMnbaT017182
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Apr 2014 15:49:37 -0700 (PDT)
	(envelope-from banshee@gabriella.abattoir.com)
Received: (from root@localhost)
	by gabriella.abattoir.com (8.14.7/8.14.7/Submit) id s3EMnbxI017181;
	Mon, 14 Apr 2014 15:49:37 -0700 (PDT)
	(envelope-from banshee)
Message-Id: <201404142249.s3EMnbxI017181@gabriella.abattoir.com>
Date: Mon, 14 Apr 2014 15:49:37 -0700 (PDT)
From: JMV <banshee@abattoir.com>
Reply-To: JMV <banshee@abattoir.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: port security/sshguard doesn't start without explicit pidfile
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         188635
>Category:       ports
>Synopsis:       port security/sshguard doesn't start without explicit pidfile
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 14 23:10:00 UTC 2014
>Closed-Date:    Sat Apr 26 01:24:47 UTC 2014
>Last-Modified:  Sat Apr 26 01:24:47 UTC 2014
>Originator:     JMV
>Release:        FreeBSD 9.2-RELEASE-p4 amd64
>Organization:
just-another-unix-hacker
>Environment:
System: FreeBSD gabriella.abattoir.com 9.2-RELEASE-p4 FreeBSD 9.2-RELEASE-p4 #0: Tue Apr 8 18:08:22 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
	/usr/local/etc/rc.d/sshguard silently fails to start if sshguard_pidfile is not defined in /etc/rc.conf because the start script refers to the wrong variable.

>How-To-Repeat:
	Install security/sshguard
	Ensure rc.conf contains sshguard_enable="YES"
	Ensure rc.conf does not contain sshguard_pidfile
	$ service sshguard start
	Silently fails to start.
>Fix:
command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${sshguard_pidfile}"

should be

command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${pidfile}"

>Release-Note:
>Audit-Trail:

From: =?iso-8859-1?B?Q+1hdCDTIEfhaWJodGhlYWNo4Wlu?= <k@stereochro.me>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/188635: port security/sshguard doesn't start without
 explicit pidfile
Date: Fri, 25 Apr 2014 18:25:22 +0100

 This PR was fixed in port commit 352123[1] and can be closed.
 
 [1] http://svnweb.freebsd.org/ports?view=revision&revision=352123
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sat Apr 26 01:24:28 UTC 2014 
State-Changed-Why:  
fixed in http://svnweb.freebsd.org/ports?view=revision&revision=352123 . 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188635 
>Unformatted:
