From nobody@FreeBSD.org  Sat Apr 12 21:49:03 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 602DB8EB
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Apr 2014 21:49:03 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4D07612E2
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Apr 2014 21:49:03 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s3CLn20J009135
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Apr 2014 21:49:02 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s3CLn2VP009134;
	Sat, 12 Apr 2014 21:49:02 GMT
	(envelope-from nobody)
Message-Id: <201404122149.s3CLn2VP009134@cgiserv.freebsd.org>
Date: Sat, 12 Apr 2014 21:49:02 GMT
From: Stephen Hurd <shurd@sasktel.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [Maintainer Update] comms/fllog to use *_CONFIGURE_* for knob
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         188536
>Category:       ports
>Synopsis:       [Maintainer Update] comms/fllog to use *_CONFIGURE_* for knob
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    db
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 12 21:50:01 UTC 2014
>Closed-Date:    Sat Apr 12 22:19:26 UTC 2014
>Last-Modified:  Sat Apr 12 22:20:00 UTC 2014
>Originator:     Stephen Hurd
>Release:        10.0-RELEASE
>Organization:
>Environment:
FreeBSD portable 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Change from old style .if/CONFUGRE_ARGS+=/.else to new style *_CONFIGURE_* for the knob.

No functional change.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 351133)
+++ Makefile	(working copy)
@@ -23,16 +23,11 @@
 
 NATIVE_OPT_DESC=	Enable Native Optimizations
 
-.include <bsd.port.pre.mk>
-
 PLIST_FILES=	bin/fllog \
 		share/applications/fllog.desktop \
 		share/pixmaps/fllog.xpm
 
-.if ${PORT_OPTIONS:MNATIVE_OPT}
-CONFIGURE_ARGS+=--enable-optimizations=native
-.else
-CONFIGURE_ARGS+=--enable-optimizations=none
-.endif
+NATIVE_OPT_CONFIGURE_ON=	--enable-optimizations=native
+NATIVE_OPT_CONFIGURE_OFF=	--enable-optimizations=none
 
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->db 
Responsible-Changed-By: db 
Responsible-Changed-When: Sat Apr 12 21:58:08 UTC 2014 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188536 
State-Changed-From-To: open->closed 
State-Changed-By: db 
State-Changed-When: Sat Apr 12 22:19:17 UTC 2014 
State-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=188536 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/188536: commit references a PR
Date: Sat, 12 Apr 2014 22:19:07 +0000 (UTC)

 Author: db
 Date: Sat Apr 12 22:19:04 2014
 New Revision: 351152
 URL: http://svnweb.freebsd.org/changeset/ports/351152
 QAT: https://qat.redports.org/buildarchive/r351152/
 
 Log:
   - Change from old style .if/CONFUGRE_ARGS+=/.else to new style *_CONFIGURE_*
     for the knob.
   
   PR:		ports/188536
   Submitted by:	Maintainer
 
 Modified:
   head/comms/fllog/Makefile
 
 Modified: head/comms/fllog/Makefile
 ==============================================================================
 --- head/comms/fllog/Makefile	Sat Apr 12 22:18:27 2014	(r351151)
 +++ head/comms/fllog/Makefile	Sat Apr 12 22:19:04 2014	(r351152)
 @@ -23,16 +23,11 @@ OPTIONS_DEFINE=	NATIVE_OPT
  
  NATIVE_OPT_DESC=	Enable Native Optimizations
  
 -.include <bsd.port.pre.mk>
 -
  PLIST_FILES=	bin/fllog \
  		share/applications/fllog.desktop \
  		share/pixmaps/fllog.xpm
  
 -.if ${PORT_OPTIONS:MNATIVE_OPT}
 -CONFIGURE_ARGS+=--enable-optimizations=native
 -.else
 -CONFIGURE_ARGS+=--enable-optimizations=none
 -.endif
 +NATIVE_OPT_CONFIGURE_ON=	--enable-optimizations=native
 +NATIVE_OPT_CONFIGURE_OFF=	--enable-optimizations=none
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
