From lchen@zen.lhaven.homeip.net  Mon Mar 31 20:39:37 2014
Return-Path: <lchen@zen.lhaven.homeip.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id A6D5858D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 Mar 2014 20:39:37 +0000 (UTC)
Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 76BB8234
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 Mar 2014 20:39:37 +0000 (UTC)
Received: from ip70-179-144-228.fv.ks.cox.net ([70.179.144.228] helo=zen.lhaven.homeip.net)
	by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.72)
	(envelope-from <lchen@zen.lhaven.homeip.net>)
	id 1WUizR-0001Db-JE
	for FreeBSD-gnats-submit@freebsd.org; Mon, 31 Mar 2014 20:39:29 +0000
Received: from zen.lhaven.homeip.net (localhost [127.0.0.1])
	by zen.lhaven.homeip.net (8.14.8/8.14.7) with ESMTP id s2VKcCBs082487;
	Mon, 31 Mar 2014 15:38:12 -0500 (CDT)
	(envelope-from lchen@zen.lhaven.homeip.net)
Received: (from lchen@localhost)
	by zen.lhaven.homeip.net (8.14.8/8.14.7/Submit) id s2VKc7wj082486;
	Mon, 31 Mar 2014 15:38:07 -0500 (CDT)
	(envelope-from lchen)
Message-Id: <201403312038.s2VKc7wj082486@zen.lhaven.homeip.net>
Date: Mon, 31 Mar 2014 15:38:07 -0500 (CDT)
From: Lawrence "The Dreamer" Chen <beastie@tardisi.com>
Reply-To: Lawrence "The Dreamer" Chen <beastie@tardisi.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] sysutils/memtest86+: Doesn't build if ISO option is selected.
X-Send-Pr-Version: 3.114
X-GNATS-Notify: avg@icyb.net.ua

>Number:         188149
>Category:       ports
>Synopsis:       [patch] sysutils/memtest86+: Doesn't build if ISO option is selected.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          feedback
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 31 20:40:00 UTC 2014
>Closed-Date:    
>Last-Modified:  Tue Apr  1 06:40:00 UTC 2014
>Originator:     Lawrence "The Dreamer" Chen
>Release:        FreeBSD 9.2-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD zen.lhaven.homeip.net 9.2-RELEASE-p3 FreeBSD 9.2-RELEASE-p3 #0: Sat Jan 11 03:25:02 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:
	
	sysutils/memtest86+ fails to build if the port option ISO is selected.
>How-To-Repeat:
	
>Fix:

	

	On closer look at the build failure, I saw this:

	make all
	make: illegal option -- -
	usage: make [-BPSXeiknpqrstv] [-C directory] [-D variable]
	        [-d flags] [-E variable] [-f makefile] [-I directory]
	        [-j max_jobs] [-m directory] [-V variable]
	        [variable=value] [target ...]
	gmake: *** [iso] Error 2
	gmake: *** Waiting for unfinished jobs....
	===> Compilation failed unexpectedly.

	We're using gmake, and the Makefile is calling make?
	
	Patch the Makefile to also use gmake.


--- patch begins here ---
--- files/patch-Makefile.orig	2014-01-22 11:40:44.000000000 -0600
+++ files/patch-Makefile	2014-03-31 15:25:47.000000000 -0500
@@ -1,6 +1,6 @@
---- Makefile	2008-11-16 02:30:50.000000000 +0200
-+++ Makefile	2009-02-18 09:03:07.000000000 +0200
-@@ -23,15 +23,15 @@ all: memtest.bin memtest
+--- Makefile.orig	2014-03-31 15:24:42.901769547 -0500
++++ Makefile	2014-03-31 15:25:34.535769604 -0500
+@@ -23,15 +23,15 @@
  # symbols and then link it dynamically so I have full
  # relocation information
  memtest_shared: $(OBJS) memtest_shared.lds Makefile
@@ -19,9 +19,12 @@
  
  head.s: head.S config.h defs.h test.h
  	$(CC) -E -traditional $< -o $@
-@@ -58,7 +58,6 @@ clean:
+@@ -59,9 +59,8 @@
+ 	@./makedos.sh
+ 
  iso:
- 	make all
+-	make all
++	gmake all
  	./makeiso.sh
 -	rm -f *.o *.s memtest.bin memtest memtest_shared memtest_shared.bin
  
--- patch ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Mar 31 20:40:04 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188149 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: avg@icyb.net.ua
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/188149: [patch] sysutils/memtest86+: Doesn't build if ISO option is selected.
Date: Mon, 31 Mar 2014 20:40:03 UT

 Maintainer of sysutils/memtest86+,
 
 Please note that PR ports/188149 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/188149
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Andriy Gapon <avg@FreeBSD.org>
To: bug-followup@FreeBSD.org, beastie@tardisi.com
Cc:  
Subject: Re: ports/188149: [patch] sysutils/memtest86+: Doesn&#39;t build
 if ISO option is selected.
Date: Tue, 01 Apr 2014 09:32:56 +0300

 Thank you for the report!
 I have an alternative suggestion: instead of calling make all the 'iso' target
 should just depend on 'all' target similarly to 'install' target.
 -- 
 Andriy Gapon
>Unformatted:
