From dm@home8.dinoex.sub.de  Sun Mar 30 07:17:51 2014
Return-Path: <dm@home8.dinoex.sub.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id E0BF6F25
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Mar 2014 07:17:51 +0000 (UTC)
Received: from uucp.dinoex.sub.de (smtp3.dinoex.sub.de [IPv6:2001:1440:5001:1::2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "uucp.dinoex.sub.de", Issuer "CAcert Class 3 Root" (not verified))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4C480C6D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Mar 2014 07:17:50 +0000 (UTC)
Received: from home8.dinoex.sub.de (home8.dinoex.sub.de [194.45.71.48])
	by uucp.dinoex.sub.de (8.14.8/8.14.5) with ESMTP id s2U7GqMZ058612
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Mar 2014 09:17:23 +0200 (CEST)
	(envelope-from dm@home8.dinoex.sub.de)
Received: (from dm@localhost)
	by home8.dinoex.sub.de (8.14.5/8.14.5/Submit) id s2U7Gp1s024163;
	Sun, 30 Mar 2014 09:16:51 +0200 (CEST)
	(envelope-from dm)
Message-Id: <201403300716.s2U7Gp1s024163@home8.dinoex.sub.de>
Date: Sun, 30 Mar 2014 09:16:51 +0200 (CEST)
From: dirk.meyer@dinoex.sub.org
Reply-To: dirk.meyer@dinoex.sub.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] mail/milter-bogom
X-Send-Pr-Version: 3.113
X-GNATS-Notify: victor@bsdes.net

>Number:         188068
>Category:       ports
>Synopsis:       [PATCH] mail/milter-bogom for staging
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 30 07:20:00 UTC 2014
>Closed-Date:    Tue Apr 15 12:11:55 CEST 2014
>Last-Modified:  Tue Apr 15 12:11:55 CEST 2014
>Originator:     Dirk Meyer
>Release:        FreeBSD 9.2-RELEASE
>Organization:
privat
>Environment:

	FreeBSD ports

>Description:

	convert port to staging
	undo silent install
	drop MAN8PREFIX, which fails on custom PREFIX
	add trailing / to install for robustness

>How-To-Repeat:
>Fix:

	apply patch:

Index: Makefile
===================================================================
--- Makefile	(revision 349338)
+++ Makefile	(working copy)
@@ -14,8 +14,6 @@
 
 RUN_DEPENDS=	bogofilter:${PORTSDIR}/mail/bogofilter
 
-MAN8=		bogom.8
-
 MAKE_ARGS=	CPPFLAGS="-DDEF_CONF=\\\"${PREFIX}/etc/bogom.conf\\\" ${PTHREAD_CFLAGS}" \
 		LIBS="-lmilter ${PTHREAD_LIBS}"
 
@@ -23,31 +21,30 @@
 SUB_FILES=	pkg-message
 
 PLIST_FILES=	sbin/bogom \
+		man/man8/bogom.8.gz \
 		etc/bogom.conf-example
 
 PORTDOCS=	README CHANGELOG
 
-NO_STAGE=	yes
+.include <bsd.port.options.mk>
+
 post-patch:
-	@${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|g' ${WRKSRC}/bogom.8
-	@${REINPLACE_CMD} -e \
+	${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|g' ${WRKSRC}/bogom.8
+	${REINPLACE_CMD} -e \
 		's|/usr/local/bin/bogofilter|${LOCALBASE}/bin/bogofilter|g' \
 		${WRKSRC}/bogom.8 \
 		${WRKSRC}/bogom.conf-example \
 		${WRKSRC}/milter.c
 
 do-install:
-	@${INSTALL_PROGRAM} ${WRKSRC}/bogom ${PREFIX}/sbin
-	@${INSTALL_MAN} ${WRKSRC}/bogom.8 ${MAN8PREFIX}/man/man8
-	@${INSTALL_DATA} ${WRKSRC}/bogom.conf-example ${PREFIX}/etc
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
+	${INSTALL_PROGRAM} ${WRKSRC}/bogom ${STAGEDIR}${PREFIX}/sbin/
+	${INSTALL_MAN} ${WRKSRC}/bogom.8 ${STAGEDIR}${PREFIX}/man/man8/
+	${INSTALL_DATA} ${WRKSRC}/bogom.conf-example ${STAGEDIR}${PREFIX}/etc/
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
 .for f in ${PORTDOCS}
-	@${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR}/
 .endfor
 .endif
 
-post-install:
-	@${CAT} ${PKGMESSAGE}
-
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Mar 30 07:20:04 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188068 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: victor@bsdes.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/188068: [PATCH] mail/milter-bogom
Date: Sun, 30 Mar 2014 07:20:03 UT

 Maintainer of mail/milter-bogom,
 
 Please note that PR ports/188068 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/188068
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: dinoex 
Responsible-Changed-When: Sun Mar 30 10:59:27 CEST 2014 
Responsible-Changed-Why:  
I will take care of it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188068 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/188068: commit references a PR
Date: Tue, 15 Apr 2014 09:05:51 +0000 (UTC)

 Author: dinoex
 Date: Tue Apr 15 09:05:47 2014
 New Revision: 351315
 URL: http://svnweb.freebsd.org/changeset/ports/351315
 QAT: https://qat.redports.org/buildarchive/r351315/
 
 Log:
   - use STAGEDIR
   - drop MAN8PREFIX
   - undo silent install
   - robust INSTALL
   PR:		188068
   Approved by:	(Maintainer Timeout)
 
 Modified:
   head/mail/milter-bogom/Makefile
 
 Modified: head/mail/milter-bogom/Makefile
 ==============================================================================
 --- head/mail/milter-bogom/Makefile	Tue Apr 15 08:55:52 2014	(r351314)
 +++ head/mail/milter-bogom/Makefile	Tue Apr 15 09:05:47 2014	(r351315)
 @@ -14,8 +14,6 @@ COMMENT=	Simple sendmail milter to inter
  
  RUN_DEPENDS=	bogofilter:${PORTSDIR}/mail/bogofilter
  
 -MAN8=		bogom.8
 -
  MAKE_ARGS=	CPPFLAGS="-DDEF_CONF=\\\"${PREFIX}/etc/bogom.conf\\\" ${PTHREAD_CFLAGS}" \
  		LIBS="-lmilter ${PTHREAD_LIBS}"
  
 @@ -23,31 +21,30 @@ USE_RC_SUBR=	milter-bogom
  SUB_FILES=	pkg-message
  
  PLIST_FILES=	sbin/bogom \
 +		man/man8/bogom.8.gz \
  		etc/bogom.conf-example
  
  PORTDOCS=	README CHANGELOG
  
 -NO_STAGE=	yes
 +.include <bsd.port.options.mk>
 +
  post-patch:
 -	@${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|g' ${WRKSRC}/bogom.8
 -	@${REINPLACE_CMD} -e \
 +	${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|g' ${WRKSRC}/bogom.8
 +	${REINPLACE_CMD} -e \
  		's|/usr/local/bin/bogofilter|${LOCALBASE}/bin/bogofilter|g' \
  		${WRKSRC}/bogom.8 \
  		${WRKSRC}/bogom.conf-example \
  		${WRKSRC}/milter.c
  
  do-install:
 -	@${INSTALL_PROGRAM} ${WRKSRC}/bogom ${PREFIX}/sbin
 -	@${INSTALL_MAN} ${WRKSRC}/bogom.8 ${MAN8PREFIX}/man/man8
 -	@${INSTALL_DATA} ${WRKSRC}/bogom.conf-example ${PREFIX}/etc
 -.if !defined(NOPORTDOCS)
 -	@${MKDIR} ${DOCSDIR}
 +	${INSTALL_PROGRAM} ${WRKSRC}/bogom ${STAGEDIR}${PREFIX}/sbin/
 +	${INSTALL_MAN} ${WRKSRC}/bogom.8 ${STAGEDIR}${PREFIX}/man/man8/
 +	${INSTALL_DATA} ${WRKSRC}/bogom.conf-example ${STAGEDIR}${PREFIX}/etc/
 +.if ${PORT_OPTIONS:MDOCS}
 +	${MKDIR} ${STAGEDIR}${DOCSDIR}
  .for f in ${PORTDOCS}
 -	@${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
 +	${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR}/
  .endfor
  .endif
  
 -post-install:
 -	@${CAT} ${PKGMESSAGE}
 -
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: dinoex 
State-Changed-When: Tue Apr 15 12:11:30 CEST 2014 
State-Changed-Why:  
committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=188068 
>Unformatted:
