From truckman@FreeBSD.org  Mon Mar 24 00:06:41 2014
Return-Path: <truckman@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 0BDAC351
	for <FreeBSD-gnats-submit@FreeBSD.org>; Mon, 24 Mar 2014 00:06:41 +0000 (UTC)
Received: from gw.catspoiler.org (gw.catspoiler.org [75.1.14.242])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id BD1CE74D
	for <FreeBSD-gnats-submit@FreeBSD.org>; Mon, 24 Mar 2014 00:06:40 +0000 (UTC)
Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id s2O06Y1h000508
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 23 Mar 2014 16:06:34 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Received: from mousie.catspoiler.org (localhost.catspoiler.org [127.0.0.1])
	by mousie.catspoiler.org (8.14.7/8.14.7) with ESMTP id s2O06YIi064515
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 23 Mar 2014 17:06:34 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Received: (from dl@localhost)
	by mousie.catspoiler.org (8.14.7/8.14.7/Submit) id s2O06YLZ064514;
	Sun, 23 Mar 2014 17:06:34 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <201403240006.s2O06YLZ064514@mousie.catspoiler.org>
Date: Sun, 23 Mar 2014 17:06:34 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Reply-To: Don Lewis <truckman@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:
Subject: [patch] readline update broke devel/seed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         187883
>Category:       ports
>Synopsis:       [patch] readline update broke devel/seed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 24 00:10:00 UTC 2014
>Closed-Date:    Tue Apr 29 21:06:11 UTC 2014
>Last-Modified:  Tue Apr 29 21:06:11 UTC 2014
>Originator:     Don Lewis
>Release:        FreeBSD 8.4-STABLE i386
>Organization:
FreeBSD Project
>Environment:
System: FreeBSD scratch.catspoiler.org 8.4-STABLE FreeBSD 8.4-STABLE #70 r263289: Tue Mar 18 13:22:31 PDT 2014     dl@scratch.catspoiler.org:/usr/obj/usr/src/sys/GENERICDDB  i386

	seed-2.31.91_3
	readline-6.3_1


>Description:

	The upgrade to readline-6.3 removed a deprecated typedef that
	seed was relying on.

Making all in readline
gmake[3]: Entering directory `/usr/ports/devel/seed/work/seed-2.31.91/modules/readline'
  CC     libseed_readline_la-seed-readline.lo
seed-readline.c: In function 'seed_readline_bind':
seed-readline.c:80: error: 'Function' undeclared (first use in this function)
seed-readline.c:80: error: (Each undeclared identifier is reported only once
seed-readline.c:80: error: for each function it appears in.)
seed-readline.c:80: error: expected expression before ')' token
gmake[3]: *** [libseed_readline_la-seed-readline.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/devel/seed/work/seed-2.31.91/modules/readline'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/devel/seed/work/seed-2.31.91/modules'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/devel/seed/work/seed-2.31.91'
gmake: *** [all] Error 2
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop in /usr/ports/devel/seed.



>How-To-Repeat:

	Upgrade readline to version 6.3 and attempt to build devel/seed.

>Fix:


	Drop the following patch into devel/seed/files/

--- modules/readline/seed-readline.c.orig	2010-08-30 14:37:39.000000000 -0700
+++ modules/readline/seed-readline.c	2014-03-23 15:16:40.000000000 -0700
@@ -77,7 +77,7 @@
   key = seed_value_to_string(ctx, arguments[0], exception);
   c = seed_make_rl_closure((SeedObject) arguments[1]);
 
-  rl_bind_key(*key, (Function *) c);
+  rl_bind_key(*key, (rl_hook_func_t *) c);
 
   g_free(key);
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Mar 24 00:10:04 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187883 
State-Changed-From-To: open->closed 
State-Changed-By: kwm 
State-Changed-When: Tue Apr 29 21:06:01 UTC 2014 
State-Changed-Why:  
Committed thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187883 
>Unformatted:
