From ohauer@FreeBSD.org  Sun Mar 16 18:08:42 2014
Return-Path: <ohauer@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 68F0EE8C;
	Sun, 16 Mar 2014 18:08:42 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 56752282;
	Sun, 16 Mar 2014 18:08:42 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2GI8gD2017858;
	Sun, 16 Mar 2014 18:08:42 GMT
	(envelope-from ohauer@freefall.freebsd.org)
Received: (from ohauer@localhost)
	by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2GI8fI9017857;
	Sun, 16 Mar 2014 18:08:41 GMT
	(envelope-from ohauer)
Message-Id: <201403161808.s2GI8fI9017857@freefall.freebsd.org>
Date: Sun, 16 Mar 2014 18:08:41 GMT
From: Olli Hauer <ohauer@FreeBSD.org>
Reply-To:
To: FreeBSD-gnats-submit@freebsd.org
Cc: <erik@bz.bzflag.bz>
Subject: [patch] lang/itcl add stage support
X-Send-Pr-Version: 3.114
X-GNATS-Notify: erik@bz.bzflag.bz

>Number:         187639
>Category:       ports
>Synopsis:       [patch] lang/itcl add stage support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rene
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 16 18:10:00 UTC 2014
>Closed-Date:    Fri Apr 04 21:10:00 UTC 2014
>Last-Modified:  Fri Apr  4 21:10:02 UTC 2014
>Originator:     ohauer
>Release:        
>Organization:
>Environment:

>Description:
- add stage support to lang/itcl
- make QA script happy s/MAN3/MAN_3/

A copy of the patch can be found here:
http://people.freebsd.org/~ohauer/diffs/itcl_stage.diff
	
>How-To-Repeat:

>Fix:

--- itcl_stage.diff begins here ---
Index: itcl/Makefile
===================================================================
--- itcl/Makefile	(revision 348418)
+++ itcl/Makefile	(working copy)
@@ -29,31 +29,27 @@
 		MAJOR=${PORTVERSION:R:R} \
 		SHORT=${PORTVERSION:R:S/.//}
 
-MANCOMPRESSED=	no
-MANN=		body.itcl class.itcl code.itcl configbody.itcl delete.itcl ensemble.itcl find.itcl \
-		is.itcl itcl.itcl itclvars.itcl local.itcl scope.itcl
-MAN3=		Itcl_RegisterC.3 Itcl_Stack.3 Itcl_Class.3 Itcl_List.3 Itcl_Object.3 Itcl_Preserve.3
+MAN_3=		Itcl_RegisterC.3 Itcl_Stack.3 Itcl_Class.3 \
+		Itcl_List.3 Itcl_Object.3 Itcl_Preserve.3
 
-NO_STAGE=	yes
-.include <bsd.port.pre.mk>
-
 post-patch:
 	${REINPLACE_CMD} -E '/^includedir/s|/include|/include/itcl${PORTVERSION:R}|' \
 	    ${WRKSRC}/${CONFIGURE_SCRIPT}
 
 post-build test:
-	cd ${WRKSRC} && ${SETENV} ITCL_LIBRARY=${WRKSRC}/library \
-		${TCLSH} tests/all.tcl -load "load ./libitcl.so.1"
+	(cd ${WRKSRC} && ${SETENV} ITCL_LIBRARY=${WRKSRC}/library \
+		${TCLSH} tests/all.tcl -load "load ./libitcl.so.1")
 
 post-install:
-	${LN} -sf ${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
-	    ${PREFIX}/lib/libitcl.so.${PORTVERSION:R:R}
-	${LN} -sf ${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
-	    ${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl${PORTVERSION:R:S/.//}.so
-	${LN} -sf ${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
-	    ${PREFIX}/lib/libitcl.so
-.for FILE in ${MAN3}
-	${INSTALL_DATA} ${WRKSRC}/doc/${FILE:S/Itcl_//} ${PREFIX}/man/man3/${FILE}
+	${LN} -s libitcl.so.1 \
+	    ${STAGEDIR}${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl${PORTVERSION:R:S/.//}.so
+	${LN} -s ${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
+	    ${STAGEDIR}${PREFIX}/lib/libitcl.so.${PORTVERSION:R:R}
+	${LN} -s ${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
+	    ${STAGEDIR}${PREFIX}/lib/libitcl.so
+
+.for FILE in ${MAN_3}
+	${INSTALL_DATA} ${WRKSRC}/doc/${FILE:S/Itcl_//} ${STAGEDIR}${MAN3PREFIX}/man/man3/${FILE}
 .endfor
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
Index: ../itcl/pkg-plist
===================================================================
--- itcl/pkg-plist	(revision 348418)
+++ itcl/pkg-plist	(working copy)
@@ -1,14 +1,32 @@
 include/itcl%%VERSION%%/itcl.h
+include/itcl%%VERSION%%/itclDecls.h
 include/itcl%%VERSION%%/itclInt.h
-include/itcl%%VERSION%%/itclDecls.h
 include/itcl%%VERSION%%/itclIntDecls.h
-lib/libitcl.so.%%MAJOR%%
-lib/libitcl.so
+lib/itcl%%VERSION%%/itcl.tcl
+lib/itcl%%VERSION%%/itclConfig.sh
 lib/itcl%%VERSION%%/libitcl.so.1
 lib/itcl%%VERSION%%/libitcl%%SHORT%%.so
-lib/itcl%%VERSION%%/itcl.tcl
-lib/itcl%%VERSION%%/itclConfig.sh
 lib/itcl%%VERSION%%/libitclstub.a
 lib/itcl%%VERSION%%/pkgIndex.tcl
+lib/libitcl.so
+lib/libitcl.so.%%MAJOR%%
+man/man3/Itcl_Class.3.gz
+man/man3/Itcl_List.3.gz
+man/man3/Itcl_Object.3.gz
+man/man3/Itcl_Preserve.3.gz
+man/man3/Itcl_RegisterC.3.gz
+man/man3/Itcl_Stack.3.gz
+man/mann/body.itcl.gz
+man/mann/class.itcl.gz
+man/mann/code.itcl.gz
+man/mann/configbody.itcl.gz
+man/mann/delete.itcl.gz
+man/mann/ensemble.itcl.gz
+man/mann/find.itcl.gz
+man/mann/is.itcl.gz
+man/mann/itcl.itcl.gz
+man/mann/itclvars.itcl.gz
+man/mann/local.itcl.gz
+man/mann/scope.itcl.gz
+@dirrm lib/itcl%%VERSION%%
 @dirrm include/itcl%%VERSION%%
-@dirrm lib/itcl%%VERSION%%
--- itcl_stage.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Mar 16 18:10:04 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187639 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: erik@bz.bzflag.bz
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/187639: [patch] lang/itcl add stage support
Date: Sun, 16 Mar 2014 18:10:03 UT

 Maintainer of lang/itcl,
 
 Please note that PR ports/187639 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187639
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->rene 
Responsible-Changed-By: rene 
Responsible-Changed-When: Fri Apr 4 21:05:35 UTC 2014 
Responsible-Changed-Why:  
Take 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187639 
State-Changed-From-To: feedback->closed 
State-Changed-By: rene 
State-Changed-When: Fri Apr 4 21:09:48 UTC 2014 
State-Changed-Why:  
Committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187639 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/187639: commit references a PR
Date: Fri,  4 Apr 2014 21:09:42 +0000 (UTC)

 Author: rene
 Date: Fri Apr  4 21:09:37 2014
 New Revision: 350168
 URL: http://svnweb.freebsd.org/changeset/ports/350168
 QAT: https://qat.redports.org/buildarchive/r350168/
 
 Log:
   - Stage support
   - Include bsd.port.mk only once
   
   PR:		ports/187639
   Submitted by:	ohauer@
   Approved by:	maintainer timeout (erik@bz.bzflag.bz , 19 days)
 
 Modified:
   head/lang/itcl/Makefile
   head/lang/itcl/pkg-plist
 
 Modified: head/lang/itcl/Makefile
 ==============================================================================
 --- head/lang/itcl/Makefile	Fri Apr  4 20:54:03 2014	(r350167)
 +++ head/lang/itcl/Makefile	Fri Apr  4 21:09:37 2014	(r350168)
 @@ -29,31 +29,27 @@ PLIST_SUB+=	PORTVERSION=${PORTVERSION} \
  		MAJOR=${PORTVERSION:R:R} \
  		SHORT=${PORTVERSION:R:S/.//}
  
 -MANCOMPRESSED=	no
 -MANN=		body.itcl class.itcl code.itcl configbody.itcl delete.itcl ensemble.itcl find.itcl \
 -		is.itcl itcl.itcl itclvars.itcl local.itcl scope.itcl
 -MAN3=		Itcl_RegisterC.3 Itcl_Stack.3 Itcl_Class.3 Itcl_List.3 Itcl_Object.3 Itcl_Preserve.3
 -
 -NO_STAGE=	yes
 -.include <bsd.port.pre.mk>
 +MAN_3=		Itcl_RegisterC.3 Itcl_Stack.3 Itcl_Class.3 \
 +		Itcl_List.3 Itcl_Object.3 Itcl_Preserve.3
  
  post-patch:
  	${REINPLACE_CMD} -E '/^includedir/s|/include|/include/itcl${PORTVERSION:R}|' \
  	    ${WRKSRC}/${CONFIGURE_SCRIPT}
  
  post-build test:
 -	cd ${WRKSRC} && ${SETENV} ITCL_LIBRARY=${WRKSRC}/library \
 -		${TCLSH} tests/all.tcl -load "load ./libitcl.so.1"
 +	(cd ${WRKSRC} && ${SETENV} ITCL_LIBRARY=${WRKSRC}/library \
 +		${TCLSH} tests/all.tcl -load "load ./libitcl.so.1")
  
  post-install:
 -	${LN} -sf ${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
 -	    ${PREFIX}/lib/libitcl.so.${PORTVERSION:R:R}
 -	${LN} -sf ${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
 -	    ${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl${PORTVERSION:R:S/.//}.so
 -	${LN} -sf ${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
 -	    ${PREFIX}/lib/libitcl.so
 -.for FILE in ${MAN3}
 -	${INSTALL_DATA} ${WRKSRC}/doc/${FILE:S/Itcl_//} ${PREFIX}/man/man3/${FILE}
 +	${LN} -s libitcl.so.1 \
 +	    ${STAGEDIR}${PREFIX}/lib/${PORTNAME}${PORTVERSION:R}/libitcl${PORTVERSION:R:S/.//}.so
 +	${LN} -s ${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
 +	    ${STAGEDIR}${PREFIX}/lib/libitcl.so.${PORTVERSION:R:R}
 +	${LN} -s ${PORTNAME}${PORTVERSION:R}/libitcl.so.1 \
 +	    ${STAGEDIR}${PREFIX}/lib/libitcl.so
 +
 +.for FILE in ${MAN_3}
 +	${INSTALL_DATA} ${WRKSRC}/doc/${FILE:S/Itcl_//} ${STAGEDIR}${MAN3PREFIX}/man/man3/${FILE}
  .endfor
  
 -.include <bsd.port.post.mk>
 +.include <bsd.port.mk>
 
 Modified: head/lang/itcl/pkg-plist
 ==============================================================================
 --- head/lang/itcl/pkg-plist	Fri Apr  4 20:54:03 2014	(r350167)
 +++ head/lang/itcl/pkg-plist	Fri Apr  4 21:09:37 2014	(r350168)
 @@ -1,14 +1,32 @@
  include/itcl%%VERSION%%/itcl.h
 -include/itcl%%VERSION%%/itclInt.h
  include/itcl%%VERSION%%/itclDecls.h
 +include/itcl%%VERSION%%/itclInt.h
  include/itcl%%VERSION%%/itclIntDecls.h
 -lib/libitcl.so.%%MAJOR%%
 -lib/libitcl.so
 -lib/itcl%%VERSION%%/libitcl.so.1
 -lib/itcl%%VERSION%%/libitcl%%SHORT%%.so
  lib/itcl%%VERSION%%/itcl.tcl
  lib/itcl%%VERSION%%/itclConfig.sh
 +lib/itcl%%VERSION%%/libitcl.so.1
 +lib/itcl%%VERSION%%/libitcl%%SHORT%%.so
  lib/itcl%%VERSION%%/libitclstub.a
  lib/itcl%%VERSION%%/pkgIndex.tcl
 -@dirrm include/itcl%%VERSION%%
 +lib/libitcl.so
 +lib/libitcl.so.%%MAJOR%%
 +man/man3/Itcl_Class.3.gz
 +man/man3/Itcl_List.3.gz
 +man/man3/Itcl_Object.3.gz
 +man/man3/Itcl_Preserve.3.gz
 +man/man3/Itcl_RegisterC.3.gz
 +man/man3/Itcl_Stack.3.gz
 +man/mann/body.itcl.gz
 +man/mann/class.itcl.gz
 +man/mann/code.itcl.gz
 +man/mann/configbody.itcl.gz
 +man/mann/delete.itcl.gz
 +man/mann/ensemble.itcl.gz
 +man/mann/find.itcl.gz
 +man/mann/is.itcl.gz
 +man/mann/itcl.itcl.gz
 +man/mann/itclvars.itcl.gz
 +man/mann/local.itcl.gz
 +man/mann/scope.itcl.gz
  @dirrm lib/itcl%%VERSION%%
 +@dirrm include/itcl%%VERSION%%
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
