From xmj@chaot.net  Sun Mar 16 15:09:46 2014
Return-Path: <xmj@chaot.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id E1B4E3FA
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Mar 2014 15:09:46 +0000 (UTC)
Received: from dd16522.kasserver.com (dd16522.kasserver.com [85.13.137.124])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id A5D821E2
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Mar 2014 15:09:46 +0000 (UTC)
Received: from mx12.chaot.net (82.131.85.135.cable.starman.ee [82.131.85.135])
	by dd16522.kasserver.com (Postfix) with ESMTPSA id 8F64645611F;
	Sun, 16 Mar 2014 16:09:43 +0100 (CET)
Received: from localhost (1003@localhost [local]);
	by localhost (OpenSMTPD) with ESMTPA id 5bc762cc;
	Sun, 16 Mar 2014 17:09:42 +0200 (EET)
Message-Id: <17506199968125452262.enqueue@mx12.chaot.net>
Date: Sun, 16 Mar 2014 17:09:42 +0200 (EET)
From: Johannes Jost Meixner <xmj@chaot.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: aragon@phat.za.net
Subject: [PATCH] audio/alsa-utils: Fix package build with XMLTO turned off
X-Send-Pr-Version: 3.113
X-GNATS-Notify: aragon@phat.za.net

>Number:         187634
>Category:       ports
>Synopsis:       [PATCH] audio/alsa-utils: Fix package build with XMLTO turned off
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 16 15:10:00 UTC 2014
>Closed-Date:    Mon Mar 17 15:51:17 UTC 2014
>Last-Modified:  Mon Mar 17 16:00:01 UTC 2014
>Originator:     Johannes Jost Meixner
>Release:        FreeBSD 11.0-CURRENT amd64
>Organization:
Goldener Grund OUe
>Environment:
System: FreeBSD mx12.chaot.net 11.0-CURRENT FreeBSD 11.0-CURRENT #4: Sun Mar  9 15:34:03 EET
>Description:
- Fix package build
- Deprecate USE_BZIP

Unsetting the XMLTO option leads to a situation in which alsactl_init.7.gz won't
be present, leading to a failure of pkg create during port compilation.

Adding the OPTIONS_SUB knob and an %%XMLTO%% to the pkg-plist fixes this.

Port maintainer (aragon@phat.za.net) is cc'd.

port test: ok
testport: ok
redports: https://redports.org/buildarchive/20140316150300-18521/

Generated with FreeBSD Port Tools 1.00.2014.03.16 (mode: change, diff: SVN)
>How-To-Repeat:
>Fix:

--- alsa-utils-1.0.27.2.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 348413)
+++ Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	alsa-utils
 PORTVERSION=	1.0.27.2
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	ALSA/utils \
 		GENTOO/distfiles
@@ -13,12 +14,12 @@
 LIB_DEPENDS=	libasound.so:${PORTSDIR}/audio/alsa-lib
 RUN_DEPENDS=	${LOCALBASE}/lib/alsa-lib/libasound_module_pcm_oss.so:${PORTSDIR}/audio/alsa-plugins
 
-USE_BZIP2=	yes
-USES=		gmake
+USES=		gmake tar:bzip2
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--with-udev-rules-dir="\$${prefix}/lib/udev"
 CFLAGS+=	-I${LOCALBASE}/include
 
+OPTIONS_SUB=	yes
 OPTIONS_DEFINE=	XMLTO NLS
 OPTIONS_DEFAULT=XMLTO
 XMLTO_DESC=	Generate alsactl_init(7) man page using xmlto(1)
Index: pkg-plist
===================================================================
--- pkg-plist	(revision 348413)
+++ pkg-plist	(working copy)
@@ -29,7 +29,7 @@
 man/man1/aseqnet.1.gz
 man/man1/iecset.1.gz
 man/man1/speaker-test.1.gz
-man/man7/alsactl_init.7.gz
+%%XMLTO%%man/man7/alsactl_init.7.gz
 man/man8/alsaconf.8.gz
 sbin/alsaconf
 sbin/alsactl
--- alsa-utils-1.0.27.2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->swills 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Mar 16 15:10:05 UTC 2014 
Responsible-Changed-Why:  
swills@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187634 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Mar 16 15:10:06 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187634 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: aragon@phat.za.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/187634: [PATCH] audio/alsa-utils: Fix package build with XMLTO turned off
Date: Sun, 16 Mar 2014 15:10:06 UT

 Maintainer of audio/alsa-utils,
 
 Please note that PR ports/187634 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187634
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Aragon Gouveia <aragon@phat.za.net>
To: bug-followup@FreeBSD.org, xmj@chaot.net
Cc:  
Subject: Re: ports/187634: [PATCH] audio/alsa-utils: Fix package build with
 XMLTO turned off
Date: Sun, 16 Mar 2014 17:52:31 +0200

 Should be fine.  Thanks!
State-Changed-From-To: feedback->closed 
State-Changed-By: swills 
State-Changed-When: Mon Mar 17 15:51:15 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187634 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/187634: commit references a PR
Date: Mon, 17 Mar 2014 15:50:52 +0000 (UTC)

 Author: swills
 Date: Mon Mar 17 15:50:48 2014
 New Revision: 348484
 URL: http://svnweb.freebsd.org/changeset/ports/348484
 QAT: https://qat.redports.org/buildarchive/r348484/
 
 Log:
   - Fix package build
   - Deprecate USE_BZIP
   
   PR:		ports/187634
   Submitted by:	Johannes Jost Meixner <xmj@chaot.net>
   Approved by:	Aragon Gouveia <aragon@phat.za.net> (maintainer)
 
 Modified:
   head/audio/alsa-utils/Makefile
   head/audio/alsa-utils/pkg-plist
 
 Modified: head/audio/alsa-utils/Makefile
 ==============================================================================
 --- head/audio/alsa-utils/Makefile	Mon Mar 17 15:50:33 2014	(r348483)
 +++ head/audio/alsa-utils/Makefile	Mon Mar 17 15:50:48 2014	(r348484)
 @@ -3,6 +3,7 @@
  
  PORTNAME=	alsa-utils
  PORTVERSION=	1.0.27.2
 +PORTREVISION=	1
  CATEGORIES=	audio
  MASTER_SITES=	ALSA/utils \
  		GENTOO/distfiles
 @@ -13,12 +14,12 @@ COMMENT=	ALSA compatibility utils
  LIB_DEPENDS=	libasound.so:${PORTSDIR}/audio/alsa-lib
  RUN_DEPENDS=	${LOCALBASE}/lib/alsa-lib/libasound_module_pcm_oss.so:${PORTSDIR}/audio/alsa-plugins
  
 -USE_BZIP2=	yes
 -USES=		gmake
 +USES=		gmake tar:bzip2
  GNU_CONFIGURE=	yes
  CONFIGURE_ARGS=	--with-udev-rules-dir="\$${prefix}/lib/udev"
  CFLAGS+=	-I${LOCALBASE}/include
  
 +OPTIONS_SUB=	yes
  OPTIONS_DEFINE=	XMLTO NLS
  OPTIONS_DEFAULT=XMLTO
  XMLTO_DESC=	Generate alsactl_init(7) man page using xmlto(1)
 
 Modified: head/audio/alsa-utils/pkg-plist
 ==============================================================================
 --- head/audio/alsa-utils/pkg-plist	Mon Mar 17 15:50:33 2014	(r348483)
 +++ head/audio/alsa-utils/pkg-plist	Mon Mar 17 15:50:48 2014	(r348484)
 @@ -29,7 +29,7 @@ man/man1/aseqdump.1.gz
  man/man1/aseqnet.1.gz
  man/man1/iecset.1.gz
  man/man1/speaker-test.1.gz
 -man/man7/alsactl_init.7.gz
 +%%XMLTO%%man/man7/alsactl_init.7.gz
  man/man8/alsaconf.8.gz
  sbin/alsaconf
  sbin/alsactl
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
