From nobody@FreeBSD.org  Wed Mar 12 20:58:45 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 0AB37B37
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Mar 2014 20:58:45 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id EA6732F
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Mar 2014 20:58:44 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s2CKwgkc044409
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Mar 2014 20:58:42 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s2CKwgwo044408;
	Wed, 12 Mar 2014 20:58:42 GMT
	(envelope-from nobody)
Message-Id: <201403122058.s2CKwgwo044408@cgiserv.freebsd.org>
Date: Wed, 12 Mar 2014 20:58:42 GMT
From: Volodymyr Kostyrko <arcade@b1t.name>
To: freebsd-gnats-submit@FreeBSD.org
Subject: devel/allegro - fails to install (patch)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         187511
>Category:       ports
>Synopsis:       devel/allegro - fails to install (patch)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nemysis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 12 21:00:00 UTC 2014
>Closed-Date:    Wed Mar 12 22:41:29 UTC 2014
>Last-Modified:  Wed Mar 12 23:10:00 UTC 2014
>Originator:     Volodymyr Kostyrko
>Release:        ^/stable/10
>Organization:
none
>Environment:
FreeBSD limbo.b1t.lan 10.0-STABLE FreeBSD 10.0-STABLE #38 r263044: Tue Mar 11 23:39:04 EET 2014     arcade@limbo.b1t.lan:/usr/obj/usr/src/sys/MINIMAL  amd64
>Description:
Hi again! Long time no see...

Another patch to make this installable without DOCS/EXAMPLES:

Index: Makefile
===================================================================
--- Makefile    (revision 347977)
+++ Makefile    (working copy)
@@ -91,8 +91,13 @@
                ${WRKSRC}/CMakeLists.txt
 .endif

+.if ${PORT_OPTIONS:MEXAMPLES} || ${PORT_OPTIONS:MDOCS}
 post-install:
+.endif
+.if ${PORT_OPTIONS:MDOCS}
        @${INSTALL_MAN} ${WRKSRC}/docs/man/*.3 ${STAGEDIR}${MAN3PREFIX}/man/man3/
+.endif
+.if ${PORT_OPTIONS:MEXAMPLES}
        @(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR})
 .for l in ex12bit ex3buf ex3d exaccel exalpha exbitmap exblend excamera excolmap \
        exconfig excustom exdata exdbuf exexedat exfixed exflame exflip exfont \
@@ -102,6 +107,7 @@
        extrans2 extruec exunicod exupdate exxfade exzbuf
        ${STRIP_CMD} ${STAGEDIR}${EXAMPLESDIR}/${l}
 .endfor
+.endif

 .if ${PORT_OPTIONS:MDEMOS} && ${PORT_OPTIONS:MEXAMPLES}
        @(cd ${WRKSRC} && ${COPYTREE_SHARE} demos ${STAGEDIR}${EXAMPLESDIR})
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->nemysis 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Mar 12 21:00:09 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187511 
State-Changed-From-To: open->closed 
State-Changed-By: nemysis 
State-Changed-When: Wed Mar 12 22:41:28 UTC 2014 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=187511 

From: Rusmir =?UTF-8?B?RHXFoWtv?= <nemysis@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: Volodymyr Kostyrko <arcade@b1t.name>
Subject: Re: ports/187511: devel/allegro - fails to install (patch)
Date: Wed, 12 Mar 2014 23:40:34 +0100

 Please look
 
 http://wiki.freebsd.org/pkgng
 
 Thanks for your report.
 
 I do not accept full your changes:
 
 Never set MAN as Option, MAN is not DOCS and must always be installed
 
 
 +.if ${PORT_OPTIONS:MDOCS}
 @${INSTALL_MAN} ${WRKSRC}/docs/man/*.3 ${STAGEDIR}${MAN3PREFIX}/man/man3/
 +.endif
 
 
 With pgkng not needed more to be used, only in special examples as here
 
 .if ${PORT_OPTIONS:MDOCS}
 ...
 .endif
 
 
 .if ${PORT_OPTIONS:MEXAMPLES}
 ...
 .endif
 
 
 Is not to set in one condition here
 
 post-install:
 
 
 You have not given a svn diff.
 
 Next time use
 
 svn co svn://svn.FreeBSD.org/ports/head /usr/ports
 
 As Example
 
 cd /usr/local/ports/cat
 
 svn checkout svn://svn.freebsd.org/ports/head/cat/port port
 
 Make there changes and use to make diff
 
 svn diff > ../port.diff
 
 
 --=20
 Best regards,
 Rusmir Du=C5=A1ko

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/187511: commit references a PR
Date: Wed, 12 Mar 2014 23:07:01 +0000 (UTC)

 Author: nemysis
 Date: Wed Mar 12 23:06:53 2014
 New Revision: 348014
 URL: http://svnweb.freebsd.org/changeset/ports/348014
 QAT: https://qat.redports.org/buildarchive/r348014/
 
 Log:
   - Fix build, without EXAMPLES Option and change pkg-plist
   
   PR:		ports/187511
   Submitted by:	Volodymyr Kostyrko <arcade@b1t.name>
 
 Modified:
   head/devel/allegro/Makefile
   head/devel/allegro/pkg-plist
 
 Modified: head/devel/allegro/Makefile
 ==============================================================================
 --- head/devel/allegro/Makefile	Wed Mar 12 23:00:09 2014	(r348013)
 +++ head/devel/allegro/Makefile	Wed Mar 12 23:06:53 2014	(r348014)
 @@ -93,15 +93,18 @@ post-patch:
  
  post-install:
  	@${INSTALL_MAN} ${WRKSRC}/docs/man/*.3 ${STAGEDIR}${MAN3PREFIX}/man/man3/
 +
 +.if ${PORT_OPTIONS:MEXAMPLES}
  	@(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR})
 -.for l in ex12bit ex3buf ex3d exaccel exalpha exbitmap exblend excamera excolmap \
 +. for l in ex12bit ex3buf ex3d exaccel exalpha exbitmap exblend excamera excolmap \
  	exconfig excustom exdata exdbuf exexedat exfixed exflame exflip exfont \
  	exgui exhello exjoy exkeys exlights exmem exmidi exmouse expackf expal \
  	expat exquat exrgbhsv exrotscl exsample exscale exscn3d exscroll exshade \
  	exspline exsprite exstars exstream exswitch exsyscur extimer extrans \
  	extrans2 extruec exunicod exupdate exxfade exzbuf
  	${STRIP_CMD} ${STAGEDIR}${EXAMPLESDIR}/${l}
 -.endfor
 +. endfor
 +.endif
  
  .if ${PORT_OPTIONS:MDEMOS} && ${PORT_OPTIONS:MEXAMPLES}
  	@(cd ${WRKSRC} && ${COPYTREE_SHARE} demos ${STAGEDIR}${EXAMPLESDIR})
 
 Modified: head/devel/allegro/pkg-plist
 ==============================================================================
 --- head/devel/allegro/pkg-plist	Wed Mar 12 23:00:09 2014	(r348013)
 +++ head/devel/allegro/pkg-plist	Wed Mar 12 23:06:53 2014	(r348014)
 @@ -8,9 +8,9 @@ bin/grabber
  bin/pack
  bin/pat2dat
  bin/rgbmap
 -%%DEMOS%%bin/shooter
 -%%DEMOS%%bin/skater
 -%%DEMOS%%bin/skater_agl
 +%%DEMOS%%%%EXAMPLES%%bin/shooter
 +%%DEMOS%%%%EXAMPLES%%bin/skater
 +%%DEMOS%%%%EXAMPLES%%bin/skater_agl
  bin/textconv
  include/alleggl.h
  include/allegro.h
 @@ -1059,8 +1059,8 @@ man/man3/voice_sweep_pan.3.gz
  man/man3/vsync.3.gz
  man/man3/xor_mode.3.gz
  man/man3/xwin_set_window_name.3.gz
 -%%DEMOS%%share/pixmaps/shooter.png
 -%%DEMOS%%share/pixmaps/skater.png
 +%%DEMOS%%%%EXAMPLES%%share/pixmaps/shooter.png
 +%%DEMOS%%%%EXAMPLES%%share/pixmaps/skater.png
  @dirrm lib/allegro/%%SHLIB_VER%%
  @dirrm lib/allegro
  @dirrm include/allegrogl/GLext
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
