From nobody@FreeBSD.org  Sun Feb 23 14:57:44 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 2E132EE1
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Feb 2014 14:57:44 +0000 (UTC)
Received: from newred.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id E97E713A7
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Feb 2014 14:57:43 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by newred.freebsd.org (8.14.7/8.14.7) with ESMTP id s1NEvhmJ025735
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Feb 2014 14:57:43 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.7/8.14.7/Submit) id s1NEvhqG025734;
	Sun, 23 Feb 2014 14:57:43 GMT
	(envelope-from nobody)
Message-Id: <201402231457.s1NEvhqG025734@cgiserv.freebsd.org>
Date: Sun, 23 Feb 2014 14:57:43 GMT
From: Jean-Sbastien Pdron <dumbbell@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] graphics/darktable: update to 1.4.1
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         186979
>Category:       ports
>Synopsis:       [PATCH] graphics/darktable: update to 1.4.1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    danfe
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 23 15:00:00 UTC 2014
>Closed-Date:    
>Last-Modified:  Thu May 22 08:20:00 UTC 2014
>Originator:     Jean-Sbastien Pdron
>Release:        11.0-CURRENT
>Organization:
The FreeBSD Project
>Environment:
FreeBSD magellan.dumbbell.fr 11.0-CURRENT FreeBSD 11.0-CURRENT #0 7e2b0bf(master): Sat Feb 22 18:18:04 CET 2014     root@magellan.dumbbell.fr:/usr/obj/home/dumbbell/Projects/freebsd/src/GIT/sys/GENERIC  amd64
>Description:
The following patch stages and updates graphics/darktable to 1.4.1:
http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update-141-staging-openmp.b.patch

The following changes were made to options:
- Remove KWALLET option (unused)
- Rename FACEBOOK option to FB_PICASA, because both export features depend on json-glib.
- Add COLORD option (color management)
- Add GRAPHMAGICK option (support GraphicsMagick's image formats)
- Add LUA option (embed Lua to add scripting)
- Add SQUISH option (use libsquish to compress thumbnails)

The patch enables more options by default, because I think it's more sensible for a photographer using binary packages:
- COLORD
- FB_PICASA
- FLICKR
- GEO
- GRAPHMAGICK
- LUA
- NLS
- OPENJPEG
- SQUISH

Regarding the GCC option (enabled by default to provide OpenMP support), USES=compiler:features allows to check if libc++ is the C++ standard library. In this case, devel/libc++ is pulled as a build dependency: this allows GCC to be used even when other libraries (eg. exiv2) were built with Clang.

COLORD adds a LIB_DEPENDS to graphics/colord, but darktable provides it's own libcolord.so internally (statically linked). The comment in src/CMakeLists.txt explains that libcolord.so in many [Linux] distros is linked against Gtk+3.

GRAPHMAGICK adds a LIB_DEPENDS to graphics/GraphicsMagick13: I used library name with version (libGraphicsMagick.so.14), because it doesn't build with graphics/GraphicsMagick. I didn't try with graphics/GraphicsMagick12.

graphics/webp is added as a mandatory option: CMakeLists.txt defines a "USE_WEBP" CMake option, but that option is never used.

patch-cmake_modules_FindFreetype.cmake is removed because the corresponding CMake module is gone.

patch-src-common-imageio_exr.hh is removed because a better fix (one which works for both FreeBSD and Mac OS X) is committed upstream.

pkg-plist's diff is large because I preferred to keep the order of "make makeplist". Future updates will be easier. Otherwise, changes are small.

The patch was tested using advices from StageDir wiki page, except the poudriere/tinderbox step.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->danfe 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Feb 23 15:00:08 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186979 

From: Matthieu Volat <mazhe@alkumuna.eu>
To: bug-followup@FreeBSD.org, dumbbell@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Tue, 11 Mar 2014 23:17:19 +0100

 --Sig_/qPwKJBanIq5n2Ls4faA0Y3g
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 I tried the patch, here's my experience:
 
 * The first line of the post-patch target (reinplace __APPLE__ in a header =
 with __${OPSYS}__) was not needed since a while
 
 * Stage fails if NLS is disabled:
 sed: /usr/ports/graphics/darktable/work/stage/usr/ports/graphics/darktable/=
 work/.PLIST.mktmp:
 No such file or directory
   I think ${TMPPLIST} should not be prefixed by ${STAGEDIR} in post-install=
 , this is valable for the "without RAWSPEED" section too.
 
 * For what it's worth, I don't think Graphmagick merits to be enabled by de=
 fault, it places an additional dependency on a not so used package which br=
 ings little to the equation (it's used only for importing images which are =
 not raw/jpeg/j2k/tif/webp... well unless bmp producing cameras are common..=
 .)
 
 * The package seems to force the usage of cmake ninja generator (and thus a=
 dd ninja as dependency) for no reason (build and install fine with make).
 
 --=20
 Matthieu Volat <mazhe@alkumuna.eu>
 tel: 06 84 54 39 43
 www: <http://500px.com/Mazhe>
 
 --Sig_/qPwKJBanIq5n2Ls4faA0Y3g
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iEYEARECAAYFAlMfi3QACgkQ+ENDeYKZi36wBQCgm+fRF47NNFB6sUlMn6Vtedj0
 /qoAoK85xtzRNfeTGmVHp1rfMe1QLqzO
 =c+Jv
 -----END PGP SIGNATURE-----
 
 --Sig_/qPwKJBanIq5n2Ls4faA0Y3g--

From: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org>
To: Matthieu Volat <mazhe@alkumuna.eu>, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Sat, 15 Mar 2014 15:41:12 +0100

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --uSU3svQLwuGuR4uf24jnbvk3mCiLpOn4o
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 On 11.03.2014 23:17, Matthieu Volat wrote:
 > * The first line of the post-patch target (reinplace __APPLE__ in a=20
 > header with __${OPSYS}__) was not needed since a while
 
 You're right, I updated the patch (see below).
 
 > * Stage fails if NLS is disabled:
 > sed: /usr/ports/graphics/darktable/work/stage/usr/ports/graphics/darkta=
 ble/work/.PLIST.mktmp:
 > No such file or directory
 > I think ${TMPPLIST} should not be prefixed by ${STAGEDIR} in=20
 > post-install, this is valable for the "without RAWSPEED" section
 > too.
 
 Fixed in the new patch too.
 
 > * For what it's worth, I don't think Graphmagick merits to be=20
 > enabled by default, it places an additional dependency on a not so
 > used package which brings little to the equation (it's used only for
 > importing images which are not raw/jpeg/j2k/tif/webp... well unless
 > bmp producing cameras are common...)
 
 Yeah, I was not sure what to do and don't know what users expect. Fedora
 has it enabled by default, not Debian for instance. I followed your
 advice and disabled it by default.
 
 > * The package seems to force the usage of cmake ninja generator (and=20
 > thus add ninja as dependency) for no reason (build and install fine
 > with make).
 
 Ninja isn't mandatory, but it reduces build time by 33% here. It's a
 really small build dependency which helps when working on darktable.
 
 Here's the new patch:
 http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update-1=
 41-staging-openmp.c.patch
 
 Thank you very much Matthieu for testing!
 
 --=20
 Jean-S=E9bastien P=E9dron
 
 
 --uSU3svQLwuGuR4uf24jnbvk3mCiLpOn4o
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQJ8BAEBCgBmBQJTJGaNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz
 OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTM+48P/2WsiUySoOCGRipY8XX4j50W
 lPQDhPHkzOlH8cXyG7aiyaUxgbzu6neQpNxUT92HyBm5bIjA7M3hpm/s7c77+Eos
 HgG9e6+uJbetO+eBJoZY3XgUg7aZpqOGWlRv+JwxTOflWrJV4LRWcexpuVVrB2QD
 GHWpFgEkCjuclOwVlygDLxUjJLAhV/jmw/kANtOhnQnRaEwFhAPkXd0Eiya3Q4yd
 NM7XyyAPuA23KCssyF0COuV05x+hq8XwT9LLIwRJuRlc1LZ+dKs0UL9b+76JHG9A
 9aCScDNK6+Eo76RZlXTWhWliXTB+vdd8916QfXsQmg3+Umq68M9Lcz/I/mRHOG9t
 rDeytnbGdTIx5dHvil+GRu3F6j55Ns9ikRxIKiGU9ghj2i+ehq0TzI7Ba519s5pP
 bCYE+hKK/KVtVHYcacOd6kGIN9WywncEqvFNLpzzuosv4pzdymqOFB7WuautKuVs
 Nu8frkx542+CnJfLIBp8ghDnP+zyoDxW9mZw1WAM7AcUst5lmf/HVBJIPoOn/Kgo
 EgtWlqIF/JpZBhGkhIcyU1rTwU7iUP6P+r/3YuCYtqnlQmsB5TfeEbK/3Ff+Qo12
 hgZk8kxOkNBlnHgT8tSTjuDQWJ8Ngc0ZmXXpKgDPo35AvuNMJPOW1L02ztZ9pGZi
 cQLft14E1JVFKQikPxgH
 =F+lL
 -----END PGP SIGNATURE-----
 
 --uSU3svQLwuGuR4uf24jnbvk3mCiLpOn4o--

From: Matthieu Volat <mazhe@alkumuna.eu>
To: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Sat, 15 Mar 2014 17:03:08 +0100

 --Sig_/XTwAoSS+/t4k+O8NvpI2m.3
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 On Sat, 15 Mar 2014 15:41:12 +0100
 Jean-S=C3=A9bastien P=C3=A9dron <dumbbell@FreeBSD.org> wrote:
 
 > On 11.03.2014 23:17, Matthieu Volat wrote:
 > > * For what it's worth, I don't think Graphmagick merits to be=20
 > > enabled by default, it places an additional dependency on a not so
 > > used package which brings little to the equation (it's used only for
 > > importing images which are not raw/jpeg/j2k/tif/webp... well unless
 > > bmp producing cameras are common...)
 >=20
 > Yeah, I was not sure what to do and don't know what users expect. Fedora
 > has it enabled by default, not Debian for instance. I followed your
 > advice and disabled it by default.
 
 This one may be tricky, I hoped bsdstat could give a rational argument whet=
 her people activate this option, but it does not do port option stats.
 
 >=20
 > > * The package seems to force the usage of cmake ninja generator (and=20
 > > thus add ninja as dependency) for no reason (build and install fine
 > > with make).
 >=20
 > Ninja isn't mandatory, but it reduces build time by 33% here. It's a
 > really small build dependency which helps when working on darktable.
 
 Leaving aside that it is a bit quick to ignore the time to build (and updat=
 e) ninja versus darktable and others that may use it, I feel it as somewhat=
  arbitrary enforcement, can't this be left at the user discretion /etc/make=
 .conf? It has the advantage of allowing to enable it globaly (or selectivel=
 y using conditionals).
 
 (but thanks to bring it, I forgot that I wanted to have a look at it at one=
  point)
 
 >=20
 > Here's the new patch:
 > http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update-1=
 41-staging-openmp.c.patch
 >=20
 > Thank you very much Matthieu for testing!
 
 No prob, this is a very important piece of soft for me :)
 
 Here's a bonus: some files are optional to the LUA option, and should be mo=
 ved from pkg-plist to an concatenation of the PLIST_FILE variable in the Ma=
 kefile, here's the part in the Makefile:
 .if ${PORT_OPTIONS:MLUA}
 USES+=3D      lua
 PLIST_FILES+=3D \
     %%DATADIR%%/lua/darktable/debug.lua \
     %%DATADIR%%/luarc \
     @dirrmtry %%DATADIR%%/lua/darktable \
     @dirrmtry %%DATADIR%%/lua
 .else
 CMAKE_ARGS+=3D    -DUSE_LUA:BOOL=3DOFF
 .endif
 
 And another pedantic bonus : the version in GCC_DESC can be either dropped =
 or updated, 4.7 is the new port default :)
 
 >=20
 > --=20
 > Jean-S=C3=A9bastien P=C3=A9dron
 >=20
 
 
 --=20
 Matthieu Volat <mazhe@alkumuna.eu>
 tel: 06 84 54 39 43
 www: <http://500px.com/Mazhe>
 
 --Sig_/XTwAoSS+/t4k+O8NvpI2m.3
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iEYEARECAAYFAlMkecYACgkQ+ENDeYKZi35+AgCeK9YwYXXKs7NYUaSqSBdnVC+7
 G3YAoLbTk1di6hBg8X9CIy2iDPuO4Qiq
 =mIGV
 -----END PGP SIGNATURE-----
 
 --Sig_/XTwAoSS+/t4k+O8NvpI2m.3--

From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org>
To: Matthieu Volat <mazhe@alkumuna.eu>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Mon, 24 Mar 2014 14:32:28 +0100

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --X1cEl45sliL0GpxvU8vpSNEWv8jnrWaBw
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 On 15.03.2014 17:03, Matthieu Volat wrote:
 >> Ninja isn't mandatory, but it reduces build time by 33% here. It's a
 >> really small build dependency which helps when working on darktable.
 >=20
 > Leaving aside that it is a bit quick to ignore the time to build=20
 > (and update) ninja versus darktable and others that may use it, I
 > feel it as somewhat arbitrary enforcement, can't this be left at the
 > user discretion /etc/make.conf? It has the advantage of allowing to
 > enable it globaly (or selectively using conditionals).
 
 In fact, I looked at what was done in other ports and the use of ninja
 is never conditional. Of course, that doesn't mean it should be the same
 in darktable. I don't mind if this becomes an option but I believe
 darktable already has a ton of options. ninja is fast to install/update
 and this would bring more complexity to this port. And it should be
 handled in the framework as you said, not in this specific port.
 
 But that's my opinion and the port maintainer may choose otherwise :)
 
 > No prob, this is a very important piece of soft for me :)
 >=20
 > Here's a bonus: some files are optional to the LUA option, and=20
 > should be moved from pkg-plist to an concatenation of the PLIST_FILE
 > variable in the Makefile, here's the part in the Makefile:
 
 Thanks, this is fixed in the new patch. I just let the @dirrmtry
 directives in the plist (I can't remember why though, I think there was
 an error when putting them in the PLIST_FILES variable).
 
 > And another pedantic bonus : the version in GCC_DESC can be either=20
 > dropped or updated, 4.7 is the new port default :)
 
 Fixed too :)
 
 So, the new patch:
 http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update-1=
 41-staging-openmp.d.patch
 
 Again, thank you for the extensive review!
 
 --=20
 Jean-S=C3=A9bastien P=C3=A9dron
 
 
 --X1cEl45sliL0GpxvU8vpSNEWv8jnrWaBw
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQIcBAEBAgAGBQJTMDP2AAoJEDnpl2Gl/ZTMJKUQANmFCHt+xcVhP34iWAEgiSat
 nWCK3CNJ8Cf7mpl/NRHC2ELCBzPt6H0jCFkFtFf045fbEQx6bdeyXZUp/PNquvJ7
 Xnlfsq0xrdCmSebvXwM4a1rV3j6I0iHem0jv/PlBQK3YQkVURX95yZNPwwV5IZTW
 eIay7kEx7/EQGpYkitTgpZLKcCEb9SpqkNfb46UtOMUtVdgtgyCB2MTIRBOXV++A
 PkGSeX8tGjAIRarGui3HHSTPNL8B2zcdODwdPWOYA+/H+d5BhORYWNtMK8fdGQQ3
 3lQcHpnKdfgL17tHvcU8Z9YjMuR4Ocukca1L1qN/wvrnDuHHzWcRs7jRV3pxjWYd
 78ga+is8JUj+fa4eF4GMWBekvjrNqYXpNL/8wDrnaPxPgjwIMSWqRJqoB22PewOT
 B23V9eRVQjHztcq61qGTQkWx8F+4YR6Eej1SnDORuCiVXaQqhYgU3XxMv7KSjA1w
 LSvQDmZqQac7qRMmsdYIvAieW2i4tJAnPgTEmzsHG5EfYgMQ3AZrASPA+VB1dbGj
 DF4i7sOI6PS88htzwlrO7bzN5kb/V624ZwOnfC6wta7sMxbT86+6aj5cMzeXfj5u
 XXNI1K2dMx4cdeNs0gvqvO9KQJf4zNzguNy2Oaop9iXT6DGT0UbYD82/1UqcDQkH
 UZtQRgPwvEdM/h13dsSo
 =5hMJ
 -----END PGP SIGNATURE-----
 
 --X1cEl45sliL0GpxvU8vpSNEWv8jnrWaBw--

From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Thu, 03 Apr 2014 17:35:50 +0200

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --OvQwGKDSOm5pDEL1xBbm1jAsvp0VUuToE
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Here's a new patch using the DOCS option, instead of NOPORTDOCS:
 http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update-1=
 41-staging-openmp.e.patch
 
 --=20
 Jean-S=C3=A9bastien P=C3=A9dron
 
 
 --OvQwGKDSOm5pDEL1xBbm1jAsvp0VUuToE
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQIcBAEBAgAGBQJTPX/bAAoJEDnpl2Gl/ZTMvs0P/RCmsZM3Y7x501tR/6q+fV20
 f/nuDgL0iFUwbREwrtT1p9z2yLmIrclJMVGhGKRZzDN4e+5izABVKFsTEvChHlqJ
 FdbQHPyUkdQpI7YaMewvmWE6Clv6rUX/8TcSdQDGZPgc7Ep73+vkKOIUZm+oNbQz
 E5K7mRwwFf/akaQ69elaEsl7LMUF/7byNvqrAQP0kE6LQqfZA9PcpDF8I9REl9hi
 eRtlKHrPSEMQbSivPPAqgp5kUDHE9tN20DdEqkZbRXDxW+tbxW2u1vvCyrgMiWDi
 d6S5QftrFVRuHa9JI7q1yZ4I8yfnspxOBLRt1zlAiPfbgVk72YQMl8Jfxx9mUi8d
 RLB8uh6IsjMr483rihoTCyoXn7QKdHeUOsNFsdHnHw2AL+scaoQtbPRm0npZyqvl
 uITCHJSkOpCXXEpL8K1cV+z6Kh/SHxXpXUth1HllaM7BVZOo6pt9haefWyBAebcC
 THXPk41MittzRxuXgg5/izHIDb3OvMUJTq0rC02CO+U9vNyLdpu30VK5PxL1laDz
 4PZFn6jCzNPD149Ro0SNvImzVIgfnoGHW+JRp16TIXYNOR7AyapP4IuAbFsgAFt9
 ozQPq+McP2Hw3YH/K3vEuAgvx58zO0aHZo6f1dSY3bMzuj3nwmXmez9KRNaDxrcS
 z4VLELLVY+LAVogYDi2b
 =JCOP
 -----END PGP SIGNATURE-----
 
 --OvQwGKDSOm5pDEL1xBbm1jAsvp0VUuToE--

From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?=
 <jean-sebastien.pedron@dumbbell.fr>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Thu, 03 Apr 2014 17:36:46 +0200

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --dELi33nA3o0np29ums7angIT1boGC2Ee5
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 On 03.04.2014 17:35, Jean-S=C3=A9bastien P=C3=A9dron wrote:
 > Here's a new patch using the DOCS option, instead of NOPORTDOCS:
 > http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update=
 -141-staging-openmp.e.patch
 
 Forgot to mention: this was spotted by antoine@.
 
 --=20
 Jean-S=C3=A9bastien P=C3=A9dron
 
 
 --dELi33nA3o0np29ums7angIT1boGC2Ee5
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQIcBAEBAgAGBQJTPYAOAAoJEDnpl2Gl/ZTMPnUP/jQMnGI5j13BL3MZSSszZJRZ
 vnxMoshbXnZlGLgjdV98YJTS+VJq1w1VorKmglY78HAmVu8fJGFDXE3BRb751Lwn
 8u5ymbAHU80QZLX5j7CqLSCfmXJQNhJt3ZxCew0gxHD+PxKUV8leTuNMytxJ8svp
 hz15k0VrUBYDXt0SMR9fFFCtYgSeDtVbZ1dOe9pOi2znTiaIp+Grp74cDV0PWXjY
 4OeyV9O8S8j0R2hk1/UHJERXanbaxIGW19TQ8A9hUjKPlH6GGvMBU1jBL0wvT/Fl
 M9x5lTuXP+bH/HDalVnpaZKTwIUTssAG/yK6QoNURZnRbXx+jKAnkqPMVW/0JS+U
 gp1+xVhZFo0qdmXf1LU9qkM29Coh5iKQYDdj2iIw8dZ2OGbNZsAILRZhnd730sx7
 n//flDVRjFpA3cBIupQJikndmjhgvyTWOrxH9VUBYpEk7rtOwvyLYpr1TNisD6Xq
 OIxqTIUjMAfwOyNTDYB7Jdhah2h1ZB4P2q00/zpsryA30lR1om2G1h+RCwY8rN8V
 coqEKCrEUAQQq3n3qVC5K50nYgppzEaxOV/KzHVxwSaz3QoxhK6YpQLMFh1hiRXG
 O/SO7k9ctgNbtlzaSVYJmohLT5RU2cu7v49LpR8TNxTsiYQNFEVtoG5LkQJoNh9V
 0LJHF1zAjqeKoQ/Lvqta
 =tvqB
 -----END PGP SIGNATURE-----
 
 --dELi33nA3o0np29ums7angIT1boGC2Ee5--

From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?=
 <jean-sebastien.pedron@dumbbell.fr>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Mon, 07 Apr 2014 18:05:22 +0200

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --O8IPVSXTEQeDiIQ6a5eh0g6joiOc7621T
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Here's a refresh of the patch, following exiv2 shlib bump in r350164:
 http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update-1=
 41-staging-openmp.f.patch
 
 Otherwise, this is the same patch as the '.e' version.
 
 --=20
 Jean-S=C3=A9bastien P=C3=A9dron
 
 
 --O8IPVSXTEQeDiIQ6a5eh0g6joiOc7621T
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQIcBAEBAgAGBQJTQszHAAoJEDnpl2Gl/ZTMzpAP/iX7OyshNHnWrViXT1Tfq/vi
 vo7DObCFEO8oU8TefhOzahrjH+jwkhOHmMG8+AICj1l9LcUWL13Am10enX7d9cON
 X/y1LbhFjAOLMehR/rORmfXJQVD15uQun6JhgTtlChDD4OI8KCnj9hz+m5JJcA3J
 wNDiS+NO+13pwqfvToEbCpITLMjemptt8/6lIGB8mVT4LeXrzdr0YzKN7IqhOmf6
 oEFoTvZuOz7A2dfc9uCoDHoIiSBGVPQ1qJrobgfgNLYYd82+amvtEXR9fD8X0yI6
 1Jg+ah4eWWAYw1GgjN4pD6s1DOrjHcpQi8AXSrto6JwSD8SjgfVMZbIfRG33I9HG
 9EQJUp1zG9pgQQ/MD1Wj2Q6549VKD/+IdLCtJ8nVJvoPP56MaXic0B+bOl1uHkE9
 ZYFsHdrcJpmeEo7ZLX6a3hi5vIujv2Xz14DS8eLkGfkZAmCM08zBuLjzqqGiKcKc
 6Eawa7nqgL046q0hwBuIFrBXP0aF3ev1S81Ct76Dba8k1krM94Ivmt9TgpfBEdLE
 thPbVENobaaiokp6c/nqL3bVVuCRvp4yFJAwW1Jh5pJvz42VOtcQoBA5xLihLoJn
 vLx6DN8vu8SuTJL4WYa9g8P+KKjloFizUc/vR/206ipwqn4rttpm5ScrgZYJxrVx
 5S4cFC25549HUMZAdeBV
 =zuxr
 -----END PGP SIGNATURE-----
 
 --O8IPVSXTEQeDiIQ6a5eh0g6joiOc7621T--

From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Fri, 25 Apr 2014 11:01:19 +0200

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --MnTnS9GMx1qi2SM6vs3HVQis2LqgquaV2
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Here's a new patch, now that darktable 1.4.2 is released:
 http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update-1=
 42-staging-openmp.g.patch
 
 Compared to the previous patch:
     o  Update graphics/darktable to 1.4.2 instead of 1.4.1.
     o  WebP is now an option (enabled by default).
     o  OpenEXR is an option too (enabled by default).
     o  GCC is disabled, as it doesn't build anymore on my -CURRENT and
        darktable crashes on 10.0-RELEASE.
     o  The patch to FindLua52.cmake was upstreamed and is part of 1.4.2.
 
 --=20
 Jean-S=C3=A9bastien P=C3=A9dron
 
 
 --MnTnS9GMx1qi2SM6vs3HVQis2LqgquaV2
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQIcBAEBAgAGBQJTWiRqAAoJEDnpl2Gl/ZTM6T4QAMNr9y/V3qm+3nfRuPaD266X
 Gbsf3v3VPWxlMCi/3J6Efx2k2+UxVbL2T4aq8oZGY+HuQSuVkUxM2ayWCcY41SRt
 61odrjGLxSlkP/NScS0yP1DsKclxzczztNMXVroSn4uZiE/k/GUDmXIGu2Gv05Co
 qk7ODB+Nc0JhV/I0ViWg/3DCQetdm8wBMqhpOlHHHLjhL75e7FRqr8DvYT4SYYVe
 aYvfErucZviA2WcuopSY2AgQC2eqU+J5OTC/iXcVVQaMGXcMZs4rtJLg3fFoe4bY
 NH1oQPAlXJkd3RbThOSgbwF6mR6eQ+bMIhoYFMkhIbuMqwbup44xmPYD+gUliy5W
 sWfMWnNiOvqm8ymIpnAeNuWYu1ONBYcXo0ES9I1D3aO0AOiUyCW2JwSiYrgUGPF9
 YUMOAsaJcs3uriW878vkw81eadOhvEv06SMYhDgedOBOdf3vDNaN+OfE825UjOaS
 Rnbl7d8NxZgeACkc082G2BS3ulhgQ0x70DVmxIUjaidnixaoWXM2NmlalIiwvzNu
 rkZFuKH6TDaHuuEXagRT5Ye90i4+cLRgXtRzG4ggbfBdxEtM2sDwLl/GBzcg19ZH
 MsbS9fAv3wGdasIjhl3xmHH9YPNOuJFiZ+Rf46NnW64Xq596eqFt1jo5WGMU7xXi
 3npQPnovX2iwKZPHB7GX
 =B7DC
 -----END PGP SIGNATURE-----
 
 --MnTnS9GMx1qi2SM6vs3HVQis2LqgquaV2--

From: Matthieu Volat <mazhe@alkumuna.eu>
To: bug-followup@FreeBSD.org, dumbbell@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Sun, 11 May 2014 19:32:24 +0200

 --Sig_/R_rUqQKw5JLqZ+Cuv++WLyR
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 Please note that the webp option is a empty stub in darktable: when I
 sent a fix to the upstream
 (https://github.com/darktable-org/darktable/pull/453), it was decided
 that it would be rejected in the spirit of making codec dependencies
 non-optional in the future (quoting
 https://github.com/darktable-org/darktable/pull/377).
 
 There are also those two lines that must be moved from pkg-plist to the
 conditional expansion of PLIST_FILES with PORT_OPTIONS:MLUA, or else there =
 will be packaging problems if LUA is disabled:
 @dirrmtry %%DATADIR%%/lua/darktable
 @dirrmtry %%DATADIR%%/lua
 
 --=20
 Matthieu Volat <mazhe@alkumuna.eu>
 
 --Sig_/R_rUqQKw5JLqZ+Cuv++WLyR
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iEYEARECAAYFAlNvtC0ACgkQ+ENDeYKZi37m3wCfWKNq/eWI0idzdj8jClERxToL
 K3MAoKqi2vwCneiSPBJzsA4GsBDRcXPX
 =wwQZ
 -----END PGP SIGNATURE-----
 
 --Sig_/R_rUqQKw5JLqZ+Cuv++WLyR--

From: Martin Sugioarto <martin@sugioarto.com>
To: bug-followup@FreeBSD.org, dumbbell@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Wed, 14 May 2014 01:31:31 +0200

 --Sig_/XJPF7pQwKkpYmjF=Li+r3w=
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 
 Hi,
 
 small notice: Darktable 1.4.2 is available. It compiles fine and works
 without problems. I haven't seen that you are working at this port and
 I haven't tested your patches (I made simpler, quick'n'dirty changes).
 
 Compiling with GCC won't work anymore, in my opinion because there are
 dependencies on libs like exiv2 and it is usually compiled with CLANG.
 
 I am not sure, if this is also the problem why there is not threading
 on JPEG export (only available with OPENMP??). It is really bad that my
 CPU is at 12% load exporting images one by one.
 
 Thank you for supporting this port.
 
 --
 Martin
 
 --Sig_/XJPF7pQwKkpYmjF=Li+r3w=
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iQIcBAEBAgAGBQJTcqtXAAoJEF8wvLx/5p/7ykgQALqxHenXm2j5iMrP5SxDenqD
 Ry5wo19uaa96st1Wo/IBlFpsRzrsd9MVS3//cQ3jAegKi9fH5Q/4xF49uTu2V7fe
 PUfsd/Et4pnThPWLlfYDHCQx9MoUD9DAlmmG54SURgsD2w4UUVR+1kApT+v67rjp
 Sevd9LEBcp1HLT1V1NpibxpPwaxb4ZkSkCuw6MIGk2WjoOshH7WewFiFwieDQeXG
 H/rNRnRpZI7WBwOpfxADGdBa6rhlG1DMQcTHB3ah3x0/+jTDedecsmwPI/DgNYCy
 QPWVpwYtiQi1tOMn55CqXRQAy3We7k4oLAH0thTBqVtKFFPL882IBjdvSKTChOIG
 MbNOQPe0KIHawGyhjOo4sjH58suiDPFD6RgwtNKrOOL7zHaaTVyGiLdiM3tGVp86
 TkK5vFFot6O4nrNbhA1yfklVbfng9c8+bFPem/cLIb89Aobszwb5VvxWRKx9UCpt
 g8mqglC0AylcbXLgfcJnjBP4i1/T92UEhfG18EnUBke5oLLLot1fu2vEPjztuXVi
 CbmRNHOJL78OJ15BwUzhwQdZaQQDGrZjibq26Fqj22U9mySMMWgjOLcZgbYMZIKA
 otpzS9rHjAEjsywOVdrtQ9I392GuTfokCk60dmzpXvlAGlvp5TuShumWBPRWM7Or
 umjrzhQZkfR1KGYBb3an
 =3zbf
 -----END PGP SIGNATURE-----
 
 --Sig_/XJPF7pQwKkpYmjF=Li+r3w=--

From: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Thu, 22 May 2014 10:08:49 +0200

 On 11.05.2014 19:32, Matthieu Volat wrote:
 > Please note that the webp option is a empty stub in darktable: when
 > I sent a fix to the upstream 
 > (https://github.com/darktable-org/darktable/pull/453), it was
 > decided that it would be rejected in the spirit of making codec
 > dependencies non-optional in the future (quoting 
 > https://github.com/darktable-org/darktable/pull/377).
 
 Apparently, they changed their mind in revision 1a02bfb8, where the
 USE_WEBP flag was introduced, based on #377.
 
 > There are also those two lines that must be moved from pkg-plist to
 > the conditional expansion of PLIST_FILES with PORT_OPTIONS:MLUA, or
 > else there will be packaging problems if LUA is disabled:
 > @dirrmtry %%DATADIR%%/lua/darktable
 > @dirrmtry %%DATADIR%%/lua
 
 You previously mentionned that problem, but I'm unable to move those
 @dirrmtry entries to the Makefile: I get an error if I do so (but can't
 remember the message).
 
 -- 
 Jean-Sbastien Pdron

From: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Date: Thu, 22 May 2014 10:14:30 +0200

 On 14.05.2014 01:31, Martin Sugioarto wrote:
 > small notice: Darktable 1.4.2 is available. It compiles fine and works
 > without problems. I haven't seen that you are working at this port and
 > I haven't tested your patches (I made simpler, quick'n'dirty changes).
 
 My last patch updates the port to 1.4.2. I just didn't changed the PR's
 title.
 
 > Compiling with GCC won't work anymore, in my opinion because there are
 > dependencies on libs like exiv2 and it is usually compiled with CLANG.
 
 Yes. At some point, I could use a workaround suggested by bapt@ which
 allowed to build with GCC but still use libc++ as the standard library
 (instead of libstdc++). But lately, this doesn't work anymore for me.
 The option is still there (but disabled by default) for others to play
 with it and report.
 
 > I am not sure, if this is also the problem why there is not threading
 > on JPEG export (only available with OPENMP??). It is really bad that my
 > CPU is at 12% load exporting images one by one.
 
 I don't know if the JPEG export code can use OpenMP, but I'm looking
 forward to have OpenMP support in Clang to avoid the current solution! :)
 
 -- 
 Jean-Sbastien Pdron
>Unformatted:
