From swills@mouf.net  Thu Feb 13 22:43:03 2014
Return-Path: <swills@mouf.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 771B1BB5
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 Feb 2014 22:43:03 +0000 (UTC)
Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 34EFD1C6B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 Feb 2014 22:43:03 +0000 (UTC)
Received: from meatwad.mouf.net (cpe-107-015-170-205.nc.res.rr.com [107.15.170.205])
	by mouf.net (8.14.5/8.14.5) with ESMTP id s1DMgqA1095092
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Thu, 13 Feb 2014 22:42:58 GMT
	(envelope-from swills@meatwad.mouf.net)
Received: (from swills@localhost)
	by meatwad.mouf.net (8.14.7/8.14.5/Submit) id s1DMgkiY045947;
	Thu, 13 Feb 2014 22:42:46 GMT
	(envelope-from swills)
Message-Id: <201402132242.s1DMgkiY045947@meatwad.mouf.net>
Date: Thu, 13 Feb 2014 22:42:46 GMT
From: Steve Wills <swills@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: douglas@douglasthrift.net
Subject: [PATCH] www/ap22-mod_wsgi3: Fix packaging
X-Send-Pr-Version: 3.113
X-GNATS-Notify: douglas@douglasthrift.net

>Number:         186749
>Category:       ports
>Synopsis:       [PATCH] www/ap22-mod_wsgi3: Fix packaging
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 13 22:50:00 UTC 2014
>Closed-Date:    Fri Feb 14 19:31:20 UTC 2014
>Last-Modified:  Fri Feb 14 19:40:02 UTC 2014
>Originator:     Steve Wills
>Release:        FreeBSD 11.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD meatwad.mouf.net 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r260369M: Sat Jan 18 14:51:04 UTC
>Description:
- Fix packaging

When packaging with poudriere, poudriere complains:

====>> Error: Filesystem touched during stage (files must install to ${STAGEDIR}):
usr/local/etc/apache22/httpd.conf: 
	size (16915, 16974)

because apxs modifies the apache config. This is done in the pkg-plist @exec as
well, so there's no need to call it when packaging. So the attached patch takes
care of the issue.

Port maintainer (douglas@douglasthrift.net) is cc'd.

Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: SVN)
>How-To-Repeat:
>Fix:

--- ap22-mod_wsgi3-3.4_1.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 344153)
+++ Makefile	(working copy)
@@ -35,6 +35,8 @@
 	@${ECHO_MSG} "========================================================="
 
 post-install:
+.if !defined(PACKAGE_BUILDING)
 	@${APXS} -e -a -n "${SHORTMODNAME}" "${APACHEMODDIR}/${MODULENAME}.so"
+.endif
 
 .include <bsd.port.mk>
--- ap22-mod_wsgi3-3.4_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Feb 13 22:50:08 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186749 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: douglas@douglasthrift.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/186749: [PATCH] www/ap22-mod_wsgi3: Fix packaging
Date: Thu, 13 Feb 2014 22:50:08 UT

 Maintainer of www/mod_wsgi3,
 
 Please note that PR ports/186749 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186749
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Douglas Thrift <douglas@douglasthrift.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186749: [PATCH] www/ap22-mod_wsgi3: Fix packaging
Date: Thu, 13 Feb 2014 14:58:01 -0800

 Hello,
 
 This looks fine, I approve. Would this also apply to the mod_wsgi2 port
 as well?
 
 Thanks!
 
 Douglas William Thrift
 <douglas@douglasthrift.net>
 <http://douglasthrift.net/>
 
 On 2/13/2014 2:50 PM, Edwin Groothuis wrote:
 > Maintainer of www/mod_wsgi3,
 > 
 > Please note that PR ports/186749 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186749
 > 
State-Changed-From-To: feedback->open 
State-Changed-By: rm 
State-Changed-When: Fri Feb 14 09:05:17 UTC 2014 
State-Changed-Why:  
Maintainer approved. Assign to submitter. 


Responsible-Changed-From-To: freebsd-ports-bugs->swills 
Responsible-Changed-By: rm 
Responsible-Changed-When: Fri Feb 14 09:05:17 UTC 2014 
Responsible-Changed-Why:  
Maintainer approved. Assign to submitter. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186749 

From: Douglas Thrift <douglas@douglasthrift.net>
To: Steve Wills <swills@FreeBSD.org>, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186749: [PATCH] www/ap22-mod_wsgi3: Fix packaging
Date: Fri, 14 Feb 2014 11:04:23 -0800

 Yes, please do.
 
 Thanks!
 
 Douglas William Thrift
 <douglas@douglasthrift.net>
 <http://douglasthrift.net/>
 
 On 2/14/2014 11:03 AM, Steve Wills wrote:
 > Hi,
 > 
 > Yes, this would apply to the mod_wsgi2 port as well (and probably all ports
 > that call APXS, but that's a separate topic). Would you like me to go ahead and
 > commit the change there as well?
 > 
 > Steve
 > 

From: Steve Wills <swills@FreeBSD.org>
To: Douglas Thrift <douglas@douglasthrift.net>, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186749: [PATCH] www/ap22-mod_wsgi3: Fix packaging
Date: Fri, 14 Feb 2014 19:03:25 +0000

 Hi,
 
 Yes, this would apply to the mod_wsgi2 port as well (and probably all ports
 that call APXS, but that's a separate topic). Would you like me to go ahead and
 commit the change there as well?
 
 Steve
State-Changed-From-To: open->closed 
State-Changed-By: swills 
State-Changed-When: Fri Feb 14 19:31:19 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186749 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186749: commit references a PR
Date: Fri, 14 Feb 2014 19:31:14 +0000 (UTC)

 Author: swills
 Date: Fri Feb 14 19:31:07 2014
 New Revision: 344298
 URL: http://svnweb.freebsd.org/changeset/ports/344298
 QAT: https://qat.redports.org/buildarchive/r344298/
 
 Log:
   - Calling apxs when building packages breaks staging checks, so only do it if
     PACKAGE_BUILDING is not set.
   
   PR:		ports/186749
   Submitted by:	swills (myself)
   Approved by:	Douglas Thrift <douglas@douglasthrift.net> (maintainer)
 
 Modified:
   head/www/mod_wsgi2/Makefile
   head/www/mod_wsgi3/Makefile
 
 Modified: head/www/mod_wsgi2/Makefile
 ==============================================================================
 --- head/www/mod_wsgi2/Makefile	Fri Feb 14 19:22:27 2014	(r344297)
 +++ head/www/mod_wsgi2/Makefile	Fri Feb 14 19:31:07 2014	(r344298)
 @@ -37,6 +37,8 @@ pre-everything::
  	@${ECHO_MSG} "========================================================="
  
  post-install:
 +.if !defined(PACKAGE_BUILDING)
  	@${APXS} -e -a -n "${SHORTMODNAME}" "${APACHEMODDIR}/${MODULENAME}.so"
 +.endif
  
  .include <bsd.port.mk>
 
 Modified: head/www/mod_wsgi3/Makefile
 ==============================================================================
 --- head/www/mod_wsgi3/Makefile	Fri Feb 14 19:22:27 2014	(r344297)
 +++ head/www/mod_wsgi3/Makefile	Fri Feb 14 19:31:07 2014	(r344298)
 @@ -35,6 +35,8 @@ pre-everything::
  	@${ECHO_MSG} "========================================================="
  
  post-install:
 +.if !defined(PACKAGE_BUILDING)
  	@${APXS} -e -a -n "${SHORTMODNAME}" "${APACHEMODDIR}/${MODULENAME}.so"
 +.endif
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
