From nobody@FreeBSD.org  Tue Feb 11 13:48:40 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 0E469D74
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Feb 2014 13:48:40 +0000 (UTC)
Received: from newred.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id EB2EC1450
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Feb 2014 13:48:39 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by newred.freebsd.org (8.14.7/8.14.7) with ESMTP id s1BDmdvL098124
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Feb 2014 13:48:39 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.7/8.14.7/Submit) id s1BDmdxO098123;
	Tue, 11 Feb 2014 13:48:39 GMT
	(envelope-from nobody)
Message-Id: <201402111348.s1BDmdxO098123@cgiserv.freebsd.org>
Date: Tue, 11 Feb 2014 13:48:39 GMT
From: Vsevolod Volkov <vvv@colocall.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] net-im/licq-qt-gui: fix build on FreeBSD 10+
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         186650
>Category:       ports
>Synopsis:       [PATCH] net-im/licq-qt-gui: fix build on FreeBSD 10+
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 11 13:50:01 UTC 2014
>Closed-Date:    Thu Feb 13 22:08:55 CET 2014
>Last-Modified:  Thu Feb 13 21:10:01 UTC 2014
>Originator:     Vsevolod Volkov
>Release:        10.0-RELEASE
>Organization:
>Environment:
FreeBSD tea.colocall.net 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
1. USE_GCC shoud be removed because qt-gui plugin does not work with licq compiled with clang.

2. Building qt-gui with clang fails due to missing #include <time.h> in 2 headers.
>How-To-Repeat:
1. portmaster net-im/licq-qt-gui
2. Start licq
>Fix:
1. Apply patch to the port's Makefile:

--- Makefile.orig
+++ Makefile
@@ -3,7 +3,7 @@
 
 PORTNAME=      qt4-gui
 PORTVERSION=   1.8.0
-PORTREVISION=  1
+PORTREVISION=  2
 CATEGORIES=    net-im
 PKGNAMESUFFIX?=        ${KDE_SUFFIX}${PKGNAMESUFFIX2}
 
@@ -15,7 +15,6 @@
 LIB_DEPENDS=   libboost_regex.so:${PORTSDIR}/devel/boost-libs
 RUN_DEPENDS=   ${LOCALBASE}/lib/licq/protocol_icq.so:${PORTSDIR}/${LICQ_PORT}-i
 
-USE_GCC=       yes
 USE_XORG=      x11 xext ice xscrnsaver
 USES=          cmake
 USE_QT4=       qmake_build moc_build rcc_build uic_build linguist_build

2. Put the attached patch to /usr/ports/net-im/licq-qt-gui/files/ and rebuild net-im/licq-qt-gui port.

Patch attached with submission follows:

--- src/contactlist/contactuserdata.h.orig
+++ src/contactlist/contactuserdata.h
@@ -20,6 +20,8 @@
 #ifndef CONTACTUSERDATA_H
 #define CONTACTUSERDATA_H
 
+#include <time.h>
+
 #include <QList>
 #include <QString>
 #include <QTimer>
--- src/userevents/usereventcommon.h.orig
+++ src/userevents/usereventcommon.h
@@ -20,6 +20,8 @@
 #ifndef USEREVENTCOMMON_H
 #define USEREVENTCOMMON_H
 
+#include <time.h>
+
 #include <QWidget>
 
 #include <list>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Feb 11 13:50:14 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186650 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Thu Feb 13 22:08:47 CET 2014 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186650 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186650: commit references a PR
Date: Thu, 13 Feb 2014 21:07:52 +0000 (UTC)

 Author: dinoex
 Date: Thu Feb 13 21:07:44 2014
 New Revision: 344147
 URL: http://svnweb.freebsd.org/changeset/ports/344147
 QAT: https://qat.redports.org/buildarchive/r344147/
 
 Log:
   -  fix build with clang
   retry, cause svn failed
   PR:		186650
   Submitted by:	Vsevolod Volkov
 
 Modified:
   head/net-im/licq-qt-gui/Makefile
 
 Modified: head/net-im/licq-qt-gui/Makefile
 ==============================================================================
 --- head/net-im/licq-qt-gui/Makefile	Thu Feb 13 21:05:16 2014	(r344146)
 +++ head/net-im/licq-qt-gui/Makefile	Thu Feb 13 21:07:44 2014	(r344147)
 @@ -15,7 +15,6 @@ LICENSE=	GPLv2
  LIB_DEPENDS=	libboost_regex.so:${PORTSDIR}/devel/boost-libs
  RUN_DEPENDS=	${LOCALBASE}/lib/licq/protocol_icq.so:${PORTSDIR}/${LICQ_PORT}-icq
  
 -USE_GCC=	yes
  USE_XORG=	x11 xext ice xscrnsaver
  USES=		cmake
  USE_QT4=	qmake_build moc_build rcc_build uic_build linguist_build
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186650: commit references a PR
Date: Thu, 13 Feb 2014 21:05:24 +0000 (UTC)

 Author: dinoex
 Date: Thu Feb 13 21:05:16 2014
 New Revision: 344146
 URL: http://svnweb.freebsd.org/changeset/ports/344146
 QAT: https://qat.redports.org/buildarchive/r344146/
 
 Log:
   - fix build with clang
   PR:		186650
   Submitted by:	Vsevolod Volkov
 
 Added:
   head/net-im/licq-qt-gui/files/
   head/net-im/licq-qt-gui/files/patch-contactuserdata.h   (contents, props changed)
   head/net-im/licq-qt-gui/files/patch-usereventcommon.h   (contents, props changed)
 
 Added: head/net-im/licq-qt-gui/files/patch-contactuserdata.h
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/net-im/licq-qt-gui/files/patch-contactuserdata.h	Thu Feb 13 21:05:16 2014	(r344146)
 @@ -0,0 +1,11 @@
 +--- src/contactlist/contactuserdata.h.orig	2013-08-25 11:45:17.000000000 +0200
 ++++ src/contactlist/contactuserdata.h	2014-02-13 21:44:51.000000000 +0100
 +@@ -20,6 +20,8 @@
 + #ifndef CONTACTUSERDATA_H
 + #define CONTACTUSERDATA_H
 + 
 ++#include <time.h>
 ++
 + #include <QList>
 + #include <QString>
 + #include <QTimer>
 
 Added: head/net-im/licq-qt-gui/files/patch-usereventcommon.h
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/net-im/licq-qt-gui/files/patch-usereventcommon.h	Thu Feb 13 21:05:16 2014	(r344146)
 @@ -0,0 +1,11 @@
 +--- src/userevents/usereventcommon.h.orig	2013-08-25 11:45:17.000000000 +0200
 ++++ src/userevents/usereventcommon.h	2014-02-13 21:45:16.000000000 +0100
 +@@ -20,6 +20,8 @@
 + #ifndef USEREVENTCOMMON_H
 + #define USEREVENTCOMMON_H
 + 
 ++#include <time.h>
 ++
 + #include <QWidget>
 + 
 + #include <list>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
