From mi@privatelabs.com  Thu May 18 09:19:43 2000
Return-Path: <mi@privatelabs.com>
Received: from privatecube.privatelabs.com (privatecube.privatelabs.com [198.143.31.30])
	by hub.freebsd.org (Postfix) with ESMTP id 3143337BC5C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 18 May 2000 09:19:42 -0700 (PDT)
	(envelope-from mi@privatelabs.com)
Received: from misha.privatelabs.com (root@misha.privatelabs.com [198.143.31.6])
	by privatecube.privatelabs.com (8.9.2/8.9.2) with ESMTP id LAA26499;
	Thu, 18 May 2000 11:18:20 -0400 (EDT)
Received: (from root@localhost)
	by misha.privatelabs.com (8.9.3/8.9.3) id MAA00601;
	Thu, 18 May 2000 12:19:07 -0400 (EDT)
	(envelope-from mi)
Message-Id: <200005181619.MAA00601@misha.privatelabs.com>
Date: Thu, 18 May 2000 12:19:07 -0400 (EDT)
From: root@misha.privatelabs.com
Sender: mi@privatelabs.com
Reply-To: mi@aldan.algebra.com
To: FreeBSD-gnats-submit@freebsd.org
Cc: vince@blue-box.net
Subject: devel/libol port ignores CC/CFLAGS for some files
X-Send-Pr-Version: 3.2

>Number:         18659
>Category:       ports
>Synopsis:       devel/libol port ignores CC/CFLAGS for some files
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 18 09:20:00 PDT 2000
>Closed-Date:    Fri May 19 03:48:44 PDT 2000
>Last-Modified:  Fri May 19 08:40:05 PDT 2000
>Originator:     Mikhail Teterin
>Release:        FreeBSD 4.0-STABLE i386
>Organization:
Virtual Estates, Inc.
>Environment:

>Description:

	See synopsis. For the files in the src subdirectory, CFLAGS
	appear as ``-O2 -Wall'' from nowhere. Strange, because configure
	seems to set them properly.

>How-To-Repeat:

>Fix:

	In any case, the following should be put into patches/patch-aa

--- src/Makefile.in	Fri Feb 18 05:17:06 2000
+++ src/Makefile.in	Thu May 18 12:11:58 2000
@@ -62,3 +62,2 @@
 AS = @AS@
-CC = @CC@
 DLLTOOL = @DLLTOOL@
@@ -114,3 +113,2 @@
 pkt_buffer.lo resource.lo
-CFLAGS = @CFLAGS@
 COMPILE = $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: sobomax 
State-Changed-When: Fri May 19 03:48:44 PDT 2000 
State-Changed-Why:  
Proplem solved, though I have to generate my own patch. Thanks for reporting! 

From: mi@privatelabs.com
To: Vince Valenti <vince@bendnet.com>
Cc: Will Andrews <andrews@technologist.com>, mi@aldan.algebra.com,
	FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/18659: devel/libol port ignores CC/CFLAGS for some files
Date: Fri, 19 May 2000 11:39:22 -0400 (EDT)

 On 18 May, Vince Valenti wrote:
 = On Thu, 18 May 2000, Will Andrews wrote:
 = 
 = > On Thu, May 18, 2000 at 05:30:01PM -0700, Will Andrews wrote:
 = > > +	CFLAGS="${CFLAGS} -Wall $LIBOL_CFLAGS -D_GNU_SOURCE"
 = > 
 = > Actually,  doesn't this  sort  of thing  result  in make(1)  spewing
 = > something like "recursive variable CFLAGS"  or similar? This may not
 = > be the  best way to  implement enforced CFLAGS. You  probably should
 = > have  something like  ${PCFLAGS} here  instead, and  define PCFLAGS=
 = > ${CFLAGS} in the port Makefile.
 =
 = It seemed to work  when I ran the suggested patch...  I'd say go ahead
 = and commit it. If it would be better to have a PCFLAGS variable, I can
 = whip up a patch for that if you'd like.
 
 The  same problem  exists for  the devel/libol  (see ports/18659).  That
 software comes  from the  author, with  the same  bug in  the configure.
 Please, consider the same patch (line numbers may be different) :)
 
 	-mi
 
 
 
>Unformatted:
