From turutani@scphys.kyoto-u.ac.jp  Fri Feb  7 17:09:35 2014
Return-Path: <turutani@scphys.kyoto-u.ac.jp>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id CEB4EBF0
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 Feb 2014 17:09:35 +0000 (UTC)
Received: from smtp-auth.kuins.kyoto-u.ac.jp (smtp-auth.kuins.kyoto-u.ac.jp [133.3.248.237])
	by mx1.freebsd.org (Postfix) with ESMTP id 70FE9133C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 Feb 2014 17:09:35 +0000 (UTC)
Received: from smtp-auth.kuins.kyoto-u.ac.jp (smtp-auth.kuins.kyoto-u.ac.jp [127.0.0.1])
	by postfix.imss70 (Postfix) with ESMTP id 8141D2EC00A;
	Sat,  8 Feb 2014 02:09:34 +0900 (JST)
Received: from h120.65.226.10.32118.vlan.kuins.net (p17154-ipngn100402kyoto.kyoto.ocn.ne.jp [180.10.96.154])
	by smtp-auth.kuins.kyoto-u.ac.jp (Postfix) with ESMTP id 5DA272EC001;
	Sat,  8 Feb 2014 02:09:34 +0900 (JST)
Received: from h120.65.226.10.32118.vlan.kuins.net (localhost [127.0.0.1])
	by h120.65.226.10.32118.vlan.kuins.net (8.14.6/8.14.6/20071004-1) with ESMTP id s17H9Vkl081963;
	Sat, 8 Feb 2014 02:09:31 +0900 (JST)
	(envelope-from turutani@h120.65.226.10.32118.vlan.kuins.net)
Received: (from turutani@localhost)
	by h120.65.226.10.32118.vlan.kuins.net (8.14.6/8.14.6/Submit) id s17H9V7L081962;
	Sat, 8 Feb 2014 02:09:31 +0900 (JST)
	(envelope-from turutani)
Message-Id: <201402071709.s17H9V7L081962@h120.65.226.10.32118.vlan.kuins.net>
Date: Sat, 8 Feb 2014 02:09:31 +0900 (JST)
From: Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp>
Reply-To: Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp>
To: FreeBSD-gnats-submit@freebsd.org
Cc: turutani@scphys.kyoto-u.ac.jp
Subject: audio/sox installs symlink with non-existent target
X-Send-Pr-Version: 3.114
X-GNATS-Notify: dnelson@allantgroup.com

>Number:         186540
>Category:       ports
>Synopsis:       audio/sox installs symlink with non-existent target
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    riggs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 07 17:10:01 UTC 2014
>Closed-Date:    Sun Mar 02 12:03:16 UTC 2014
>Last-Modified:  Sun Mar 02 12:03:16 UTC 2014
>Originator:     Tsurutani Naoki
>Release:        FreeBSD 8.4-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD h120.65.226.10.32118.vlan.kuins.net 8.4-PRERELEASE FreeBSD 8.4-PRERELEASE #26 r249149: Fri Apr 5 22:13:25 JST 2013 turutani@h120.65.226.10.32118.vlan.kuins.net:/usr/local/work/usr/obj/usr/src/sys/POLYMER i386


	
>Description:
	audio/sox installs ${PREFIX}/man/man7/soxeffect.7.gz,
	which has non existing target of sox.1.gz .
	
>How-To-Repeat:
	
>Fix:
	bsd.stage.mk removes path information of the target file with symlink file
	while compressing man pages.
	hence, man7/soxeffect.7, symlink to ../man1/sox.1, was changed to the link
	like man7/soxeffect.7.gz -> sox.1.gz ; this is not correct.
	the following new patch file should be added as files/patch-Makefile.am;

--- Makefile.am.orig	2013-01-30 11:40:06.000000000 +0900
+++ Makefile.am	2014-02-08 01:46:11.000000000 +0900
@@ -118,7 +118,7 @@
 install-data-hook:
 	cd $(DESTDIR)$(mandir)/man1 && $(RM) play.1 && $(LN_S) sox.1 play.1
 	cd $(DESTDIR)$(mandir)/man1 && $(RM) rec.1 && $(LN_S) sox.1 rec.1
-	cd $(DESTDIR)$(mandir)/man7 && $(RM) soxeffect.7 && $(LN_S) ../man1/sox.1 soxeffect.7
+	cd $(DESTDIR)$(mandir)/man7 && $(RM) soxeffect.7 && $(LN_S) ../man1/sox.1.gz soxeffect.7.gz
 
 uninstall-hook:
 	$(RM) $(DESTDIR)$(mandir)/man1/play.1
	


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Feb 7 17:10:14 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186540 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: dnelson@allantgroup.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/186540: audio/sox installs symlink with non-existent target
Date: Fri, 7 Feb 2014 17:10:14 UT

 Maintainer of audio/sox,
 
 Please note that PR ports/186540 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186540
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Dan Nelson <dnelson@allantgroup.com>
To: bug-followup@FreeBSD.org, turutani@scphys.kyoto-u.ac.jp
Cc:  
Subject: Re: ports/186540: audio/sox installs symlink with non-existent target
Date: Fri, 7 Feb 2014 14:12:25 -0600

 --Qxx1br4bt0+wmkIi
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 
 Unfortunately, your patch doesn't fix the underlying problem, which is that
 the "compress-man" target of bsd.port.mk strips off the path of any symlink
 that is created.  It can't handle the case where you want to symlink a
 manpage from a different category.  The old-style MLINKS make variable did
 this correctly, which is why this problem only popped up after the switch to
 a staged buld.
 
 Modifying your patch to simply copy the file instead of symlink it
 (attached) works around the bug.
 
 
 --Qxx1br4bt0+wmkIi
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch-Makefile.am"
 
 
 Work around a ports bug wrt symlinking manpages in different
 categories, by copying the manpage instead.
 
 --- Makefile.am.orig	2013-01-30 11:40:06.000000000 +0900
 +++ Makefile.am	2014-02-08 01:46:11.000000000 +0900
 @@ -118,7 +118,7 @@
  install-data-hook:
  	cd $(DESTDIR)$(mandir)/man1 && $(RM) play.1 && $(LN_S) sox.1 play.1
  	cd $(DESTDIR)$(mandir)/man1 && $(RM) rec.1 && $(LN_S) sox.1 rec.1
 -	cd $(DESTDIR)$(mandir)/man7 && $(RM) soxeffect.7 && $(LN_S) ../man1/sox.1 soxeffect.7
 +	cd $(DESTDIR)$(mandir)/man7 && $(RM) soxeffect.7 && cp ../man1/sox.1 soxeffect.7
  
  uninstall-hook:
  	$(RM) $(DESTDIR)$(mandir)/man1/play.1
 --Qxx1br4bt0+wmkIi--

From: Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp>
To: Dan Nelson <dnelson@allantgroup.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/186540: audio/sox installs symlink with non-existent target
Date: Sat, 08 Feb 2014 06:41:01 +0900

 My patch worked fine on my host...
 I think already gziped files are not manipulated any more.
Responsible-Changed-From-To: freebsd-ports-bugs->riggs 
Responsible-Changed-By: riggs 
Responsible-Changed-When: Sun Mar 2 07:58:43 UTC 2014 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186540 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186540: commit references a PR
Date: Sun,  2 Mar 2014 11:29:41 +0000 (UTC)

 Author: riggs
 Date: Sun Mar  2 11:29:25 2014
 New Revision: 346756
 URL: http://svnweb.freebsd.org/changeset/ports/346756
 QAT: https://qat.redports.org/buildarchive/r346756/
 
 Log:
   - Fix symlink pointing to non-existing manpage
   - Bump PORTREVISION
   
   PR:		ports/186540
   Submitted by:	Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp>
   Approved by:	thierry (mentor), Dan Nelson <dnelson@allantgroup.com> (maintainer)
   MFH:		2014Q1
 
 Added:
   head/audio/sox/files/patch-Makefile.am   (contents, props changed)
 Modified:
   head/audio/sox/Makefile
 
 Modified: head/audio/sox/Makefile
 ==============================================================================
 --- head/audio/sox/Makefile	Sun Mar  2 10:58:50 2014	(r346755)
 +++ head/audio/sox/Makefile	Sun Mar  2 11:29:25 2014	(r346756)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	sox
  PORTVERSION=	14.4.1
 -PORTREVISION=	2
 +PORTREVISION=	3
  CATEGORIES=	audio
  MASTER_SITES=	SF
  
 
 Added: head/audio/sox/files/patch-Makefile.am
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/audio/sox/files/patch-Makefile.am	Sun Mar  2 11:29:25 2014	(r346756)
 @@ -0,0 +1,14 @@
 +Work around a ports bug wrt symlinking manpages in different
 +categories, by copying the manpage instead.
 +
 +--- Makefile.am.orig	2013-01-30 11:40:06.000000000 +0900
 ++++ Makefile.am	2014-02-08 01:46:11.000000000 +0900
 +@@ -118,7 +118,7 @@
 + install-data-hook:
 + 	cd $(DESTDIR)$(mandir)/man1 && $(RM) play.1 && $(LN_S) sox.1 play.1
 + 	cd $(DESTDIR)$(mandir)/man1 && $(RM) rec.1 && $(LN_S) sox.1 rec.1
 +-	cd $(DESTDIR)$(mandir)/man7 && $(RM) soxeffect.7 && $(LN_S) ../man1/sox.1 soxeffect.7
 ++	cd $(DESTDIR)$(mandir)/man7 && $(RM) soxeffect.7 && cp ../man1/sox.1 soxeffect.7
 + 
 + uninstall-hook:
 + 	$(RM) $(DESTDIR)$(mandir)/man1/play.1
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186540: commit references a PR
Date: Sun,  2 Mar 2014 11:56:20 +0000 (UTC)

 Author: riggs
 Date: Sun Mar  2 11:56:13 2014
 New Revision: 346757
 URL: http://svnweb.freebsd.org/changeset/ports/346757
 QAT: https://qat.redports.org/buildarchive/r346757/
 
 Log:
   MFH: r346756
   
   - Fix symlink pointing to non-existing manpage
   - Bump PORTREVISION
   
   PR:		ports/186540
   Submitted by:	Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp>
   Approved by:	portmgr (erwin), thierry (mentor), Dan Nelson <dnelson@allantgroup.com> (maintainer)
 
 Added:
   branches/2014Q1/audio/sox/files/patch-Makefile.am
      - copied unchanged from r346756, head/audio/sox/files/patch-Makefile.am
 Modified:
   branches/2014Q1/audio/sox/Makefile
 Directory Properties:
   branches/2014Q1/   (props changed)
 
 Modified: branches/2014Q1/audio/sox/Makefile
 ==============================================================================
 --- branches/2014Q1/audio/sox/Makefile	Sun Mar  2 11:29:25 2014	(r346756)
 +++ branches/2014Q1/audio/sox/Makefile	Sun Mar  2 11:56:13 2014	(r346757)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	sox
  PORTVERSION=	14.4.1
 -PORTREVISION=	1
 +PORTREVISION=	3
  CATEGORIES=	audio
  MASTER_SITES=	SF
  
 
 Copied: branches/2014Q1/audio/sox/files/patch-Makefile.am (from r346756, head/audio/sox/files/patch-Makefile.am)
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ branches/2014Q1/audio/sox/files/patch-Makefile.am	Sun Mar  2 11:56:13 2014	(r346757, copy of r346756, head/audio/sox/files/patch-Makefile.am)
 @@ -0,0 +1,14 @@
 +Work around a ports bug wrt symlinking manpages in different
 +categories, by copying the manpage instead.
 +
 +--- Makefile.am.orig	2013-01-30 11:40:06.000000000 +0900
 ++++ Makefile.am	2014-02-08 01:46:11.000000000 +0900
 +@@ -118,7 +118,7 @@
 + install-data-hook:
 + 	cd $(DESTDIR)$(mandir)/man1 && $(RM) play.1 && $(LN_S) sox.1 play.1
 + 	cd $(DESTDIR)$(mandir)/man1 && $(RM) rec.1 && $(LN_S) sox.1 rec.1
 +-	cd $(DESTDIR)$(mandir)/man7 && $(RM) soxeffect.7 && $(LN_S) ../man1/sox.1 soxeffect.7
 ++	cd $(DESTDIR)$(mandir)/man7 && $(RM) soxeffect.7 && cp ../man1/sox.1 soxeffect.7
 + 
 + uninstall-hook:
 + 	$(RM) $(DESTDIR)$(mandir)/man1/play.1
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: riggs 
State-Changed-When: Sun Mar 2 12:03:15 UTC 2014 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186540 
>Unformatted:
