From pi@f10.opsec.eu  Wed Feb  5 11:42:01 2014
Return-Path: <pi@f10.opsec.eu>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id C607320A;
	Wed,  5 Feb 2014 11:42:01 +0000 (UTC)
Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 84F561E16;
	Wed,  5 Feb 2014 11:42:01 +0000 (UTC)
Received: from pi by f10.opsec.eu with local (Exim 4.82 (FreeBSD))
	(envelope-from <pi@f10.opsec.eu>)
	id 1WB0rb-000HI2-EX; Wed, 05 Feb 2014 12:41:55 +0100
Message-Id: <E1WB0rb-000HI2-EX@f10.opsec.eu>
Date: Wed, 05 Feb 2014 12:41:55 +0100
From: Kurt Jaeger <fbsd-ports@opsec.eu>
Reply-To: Kurt Jaeger <fbsd-ports@opsec.eu>
To: FreeBSD-gnats-submit@freebsd.org
Cc: wg@freebsd.org, matthieu@labs.fr
Subject: [patch update] security/sslscan linker fix (adding -lcrypto)
X-Send-Pr-Version: 3.114
X-GNATS-Notify: matthieu@labs.fr

>Number:         186478
>Category:       ports
>Synopsis:       [patch update] security/sslscan linker fix (adding -lcrypto)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 05 11:50:00 UTC 2014
>Closed-Date:    Fri May 02 17:38:50 UTC 2014
>Last-Modified:  Fri May 02 17:38:50 UTC 2014
>Originator:     Kurt Jaeger
>Release:        FreeBSD 10.0-RELEASE amd64
>Organization:
-
>Environment:
System: FreeBSD f10.opsec.eu 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
	building sslscan fails with a linker error:

[...]
/usr/bin/ld:  : invalid DSO for symbol `BN_num_bits' definition
//usr/local/lib/libcrypto.so.8: could not read symbols: Bad value
cc: error: linker command failed with exit code 1 (use -v to see invocation)
[...]

Adding -lcrypto fixes this.

>How-To-Repeat:
	cd /usr/ports/security/sslscan
	make
>Fix:

diff -r -u -N security/sslscan/files/patch-Makefile /usr/home/pi/myp/security/sslscan/files/patch-Makefile
--- security/sslscan/files/patch-Makefile	2014-01-22 23:18:22.000000000 +0100
+++ /usr/home/pi/myp/security/sslscan/files/patch-Makefile	2014-02-05 12:38:18.000000000 +0100
@@ -10,7 +10,7 @@
  
  all:
 -	gcc -g -Wall -lssl -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
-+	${CC} -g -Wall -lssl -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
++	${CC} -g -Wall -lssl -lcrypto -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
  
  install:
 -	cp sslscan $(BINPATH)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wg 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Feb 5 11:50:08 UTC 2014 
Responsible-Changed-Why:  
wg@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186478 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Feb 5 11:50:09 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186478 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: matthieu@labs.fr
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/186478: [patch update] security/sslscan linker fix (adding -lcrypto)
Date: Wed, 5 Feb 2014 11:50:09 UT

 Maintainer of security/sslscan,
 
 Please note that PR ports/186478 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186478
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Matthieu BOUTHORS <matthieu@labs.fr>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/186478: [patch update] security/sslscan linker fix (adding -lcrypto)
Date: Thu, 6 Feb 2014 18:18:23 +0100

 --001a11c34dca8a81fa04f1c00fa1
 Content-Type: text/plain; charset=ISO-8859-1
 
 Hello,
 
 patch is ok for me. Compilation seems to fail only on FreeBSD 10 but patch
 does not cause trouble on previous version like 9.x. I've tested on a
 couple of boxes without any trouble. May you commit it in order to allow
 FreeBSD 10 users to use this port ?
 
 Best regards,
 Matthieu
 
 
 On Wed, Feb 5, 2014 at 12:50 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
 
 > Maintainer of security/sslscan,
 >
 > Please note that PR ports/186478 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186478
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 --001a11c34dca8a81fa04f1c00fa1
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 <div dir=3D"ltr">Hello,<div><br></div><div>patch is ok for me. Compilation =
 seems to fail only on FreeBSD 10 but patch does not cause trouble on previo=
 us version like 9.x. I&rsquo;ve tested on a couple of boxes without any tro=
 uble. May you commit it in order to allow FreeBSD 10 users to use this port=
  ?</div>
 <div><br></div><div>Best regards,</div><div>Matthieu</div></div><div class=
 =3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Wed, Feb 5, 2014 at =
 12:50 PM, Edwin Groothuis <span dir=3D"ltr">&lt;<a href=3D"mailto:edwin@fre=
 ebsd.org" target=3D"_blank">edwin@freebsd.org</a>&gt;</span> wrote:<br>
 <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
 x #ccc solid;padding-left:1ex">Maintainer of security/sslscan,<br>
 <br>
 Please note that PR ports/186478 has just been submitted.<br>
 <br>
 If it contains a patch for an upgrade, an enhancement or a bug fix<br>
 you agree on, reply to this email stating that you approve the patch<br>
 and a committer will take care of it.<br>
 <br>
 The full text of the PR can be found at:<br>
 &nbsp; &nbsp; <a href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports=
 /186478" target=3D"_blank">http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dpor=
 ts/186478</a><br>
 <span class=3D"HOEnZb"><font color=3D"#888888"><br>
 --<br>
 Edwin Groothuis via the GNATS Auto Assign Tool<br>
 edwin@FreeBSD.org<br>
 </font></span></blockquote></div><br></div>
 
 --001a11c34dca8a81fa04f1c00fa1--
Responsible-Changed-From-To: wg->pi 
Responsible-Changed-By: pi 
Responsible-Changed-When: Sat Apr 26 15:28:34 UTC 2014 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186478 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186478: commit references a PR
Date: Fri,  2 May 2014 17:23:57 +0000 (UTC)

 Author: pi
 Date: Fri May  2 17:23:53 2014
 New Revision: 352830
 URL: http://svnweb.freebsd.org/changeset/ports/352830
 QAT: https://qat.redports.org/buildarchive/r352830/
 
 Log:
   security/sslscan: linker fix for 10.0 (adding -lcrypto), staging,
                           pkg-descr reformatted (shorter lines)
   
   PR:             ports/186478
   Submitted by:   pi
   Approved by:    jadawin (mentor)
 
 Added:
   head/security/sslscan/pkg-plist   (contents, props changed)
 Modified:
   head/security/sslscan/Makefile
   head/security/sslscan/files/patch-Makefile
   head/security/sslscan/pkg-descr
 
 Modified: head/security/sslscan/Makefile
 ==============================================================================
 --- head/security/sslscan/Makefile	Fri May  2 17:07:03 2014	(r352829)
 +++ head/security/sslscan/Makefile	Fri May  2 17:23:53 2014	(r352830)
 @@ -10,10 +10,8 @@ EXTRACT_SUFX=	.tgz
  MAINTAINER=	matthieu@labs.fr
  COMMENT=	SSLScan is a fast SSL port scanner
  
 -MAKE_ARGS=	CC="${CC}" CFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib"
 +LICENSE=	GPLv3
  
 -MAN1=	sslscan.1
 -PLIST_FILES=	bin/sslscan
 +MAKE_ARGS=	STAGEDIR=${STAGEDIR} CC="${CC}" CFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib"
  
 -NO_STAGE=	yes
  .include <bsd.port.mk>
 
 Modified: head/security/sslscan/files/patch-Makefile
 ==============================================================================
 --- head/security/sslscan/files/patch-Makefile	Fri May  2 17:07:03 2014	(r352829)
 +++ head/security/sslscan/files/patch-Makefile	Fri May  2 17:23:53 2014	(r352830)
 @@ -4,13 +4,13 @@
   SRCS = sslscan.c
  -BINPATH = /usr/bin/
  -MANPATH = /usr/share/man/
 -+BINPATH = ${PREFIX}/bin/
 -+MANPATH = ${PREFIX}/man
 ++BINPATH = ${STAGEDIR}${PREFIX}/bin/
 ++MANPATH = ${STAGEDIR}${PREFIX}/man
  +CC =	${CC}
   
   all:
  -	gcc -g -Wall -lssl -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
 -+	${CC} -g -Wall -lssl -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
 ++	${CC} -g -Wall -lssl -lcrypto -o sslscan $(SRCS) $(LDFLAGS) $(CFLAGS)
   
   install:
  -	cp sslscan $(BINPATH)
 
 Modified: head/security/sslscan/pkg-descr
 ==============================================================================
 --- head/security/sslscan/pkg-descr	Fri May  2 17:07:03 2014	(r352829)
 +++ head/security/sslscan/pkg-descr	Fri May  2 17:23:53 2014	(r352830)
 @@ -1,4 +1,6 @@
 -SSLScan is a fast SSL port scanner. SSLScan connects to SSL ports and determines
 -what ciphers are supported, which are the servers prefered ciphers, which SSL
 -protocols are supported and returns the SSL certificate. Client certificates and
 -private key can be configured and output is to text / XML.
 +SSLScan is a fast SSL port scanner. SSLScan connects to SSL ports
 +and determines what ciphers are supported, which are the servers
 +prefered ciphers, which SSL protocols are supported and returns the
 +SSL certificate. Client certificates and private key can be configured
 +and output is to text / XML.
 +
 
 Added: head/security/sslscan/pkg-plist
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/security/sslscan/pkg-plist	Fri May  2 17:23:53 2014	(r352830)
 @@ -0,0 +1,2 @@
 +bin/sslscan
 +man/man1/sslscan.1.gz
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: pi 
State-Changed-When: Fri May 2 17:38:49 UTC 2014 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186478 
>Unformatted:
