From db@db.net  Tue Feb  4 02:31:53 2014
Return-Path: <db@db.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id D637313B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  4 Feb 2014 02:31:53 +0000 (UTC)
Received: from diana.db.net (unknown [IPv6:2620:64:0:1:223:7dff:fea2:c8f2])
	by mx1.freebsd.org (Postfix) with ESMTP id BFEB812BE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  4 Feb 2014 02:31:53 +0000 (UTC)
Received: from night.db.net (localhost [127.0.0.1])
	by diana.db.net (Postfix) with ESMTP id 27A1A2AA37C
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  3 Feb 2014 19:31:51 -0700 (MST)
Received: by night.db.net (Postfix, from userid 1000)
	id E025A1CC0B; Mon,  3 Feb 2014 21:31:14 -0500 (EST)
Message-Id: <20140204023114.E025A1CC0B@night.db.net>
Date: Mon,  3 Feb 2014 21:31:14 -0500 (EST)
From: Diane Bruce <db@db.net>
Reply-To: Diane Bruce <db@db.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: libiconv compile broken under clang simple fix
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         186437
>Category:       ports
>Synopsis:       libiconv compile broken under clang simple fix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 04 02:40:00 UTC 2014
>Closed-Date:    Tue Feb 04 22:35:31 UTC 2014
>Last-Modified:  Tue Feb 04 22:35:31 UTC 2014
>Originator:     Diane Bruce
>Release:        FreeBSD 11.0-CURRENT #34 r259888 amd64
>Organization:
I wish
>Environment:
System: FreeBSD odyssey 11.0-CURRENT FreeBSD 11.0-CURRENT #34 r259888: Wed Dec 25 18:14:38 EST 2013     root@odyssey:/usr/obj/home/db/svn/system/head/sys/GENERIC  amd64


	
>Description:
	
>How-To-Repeat:
	
>Fix:


Index: files/patch-lib_iconv.c
===================================================================
--- files/patch-lib_iconv.c	(revision 0)
+++ files/patch-lib_iconv.c	(working copy)
@@ -0,0 +1,12 @@
+--- lib/iconv.c.orig	2014-02-03 21:20:38.000000000 -0500
++++ lib/iconv.c	2014-02-03 21:20:54.000000000 -0500
+@@ -176,9 +176,6 @@
+ #include "aliases2.h"
+ #undef S
+ };
+-#ifdef __GNUC__
+-__inline
+-#endif
+ const struct alias *
+ aliases2_lookup (register const char *str)
+ {

Property changes on: files/patch-lib_iconv.c
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: svn:keywords
## -0,0 +1 ##
+FreeBSD=%H
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property

>Release-Note:
>Audit-Trail:

From: Tijl Coosemans <tijl@FreeBSD.org>
To: bug-followup@FreeBSD.org, db@db.net
Cc:  
Subject: Re: ports/186437: libiconv compile broken under clang simple fix
Date: Tue, 4 Feb 2014 12:20:28 +0100

 Can you copy-paste the error you're seeing because I cannot reproduce
 this.  All combinations of options work for me.

From: Tijl Coosemans <tijl@FreeBSD.org>
To: Diane Bruce <db@db.net>, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/186437: libiconv compile broken under clang simple fix
Date: Tue, 4 Feb 2014 14:56:57 +0100

 On Tue, 4 Feb 2014 07:56:34 -0500 Diane Bruce wrote:
 > On Tue, Feb 04, 2014 at 11:30:01AM +0000, Tijl Coosemans wrote:
 >> The following reply was made to PR ports/186437; it has been noted by GNATS.
 >> 
 >> From: Tijl Coosemans <tijl@FreeBSD.org>
 >> To: bug-followup@FreeBSD.org, db@db.net
 >> Cc:  
 >> Subject: Re: ports/186437: libiconv compile broken under clang simple fix
 >> Date: Tue, 4 Feb 2014 12:20:28 +0100
 >> 
 >>  Can you copy-paste the error you're seeing because I cannot reproduce
 >>  this.  All combinations of options work for me.
 >
 > checking for working fcntl.h... no (bad O_NOATIME)
 
 I think this is the problem.  There should be no O_NOATIME in fcntl.h.

From: Diane Bruce <db@db.net>
To: Tijl Coosemans <tijl@FreeBSD.org>
Cc: Diane Bruce <db@db.net>, bug-followup@FreeBSD.org
Subject: Re: ports/186437: libiconv compile broken under clang simple fix
Date: Tue, 4 Feb 2014 09:02:15 -0500

 On Tue, Feb 04, 2014 at 02:56:57PM +0100, Tijl Coosemans wrote:
 > On Tue, 4 Feb 2014 07:56:34 -0500 Diane Bruce wrote:
 > > On Tue, Feb 04, 2014 at 11:30:01AM +0000, Tijl Coosemans wrote:
 > >> The following reply was made to PR ports/186437; it has been noted by GNATS.
 > >> 
 > >> From: Tijl Coosemans <tijl@FreeBSD.org>
 > >> To: bug-followup@FreeBSD.org, db@db.net
 > >> Cc:  
 > >> Subject: Re: ports/186437: libiconv compile broken under clang simple fix
 > >> Date: Tue, 4 Feb 2014 12:20:28 +0100
 > >> 
 > >>  Can you copy-paste the error you're seeing because I cannot reproduce
 > >>  this.  All combinations of options work for me.
 > >
 > > checking for working fcntl.h... no (bad O_NOATIME)
 > 
 > I think this is the problem.  There should be no O_NOATIME in fcntl.h.
 
 I was about to close this PR. My system is obviously out of date.
 
 
 -- 
 - db@FreeBSD.org db@db.net http://www.db.net/~db
State-Changed-From-To: open->closed 
State-Changed-By: db 
State-Changed-When: Tue Feb 4 22:35:31 UTC 2014 
State-Changed-Why:  
problem disapeared after updating system. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186437 
>Unformatted:
