From m.seaman@infracaninophile.co.uk  Tue Jan 14 23:10:05 2014
Return-Path: <m.seaman@infracaninophile.co.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 9C7083A0
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 14 Jan 2014 23:10:05 +0000 (UTC)
Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 1728C13A2
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 14 Jan 2014 23:10:04 +0000 (UTC)
Received: from lucid-nonsense.infracaninophile.co.uk (localhost [IPv6:::1])
	by smtp.infracaninophile.co.uk (8.14.7/8.14.7) with ESMTP id s0EN9xJB004375
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 14 Jan 2014 23:09:59 GMT
	(envelope-from matthew@lucid-nonsense.infracaninophile.co.uk)
Received: (from matthew@localhost)
	by lucid-nonsense.infracaninophile.co.uk (8.14.7/8.14.7/Submit) id s0EN9xsQ004374;
	Tue, 14 Jan 2014 23:09:59 GMT
	(envelope-from matthew)
Message-Id: <201401142309.s0EN9xsQ004374@lucid-nonsense.infracaninophile.co.uk>
Date: Tue, 14 Jan 2014 23:09:59 GMT
From: Matthew Seaman <matthew@FreeBSD.org>
Reply-To: Matthew Seaman <matthew@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: securoty/p5-Crypt-X509 -- missing RUN_DEPENDS
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         185786
>Category:       ports
>Synopsis:       security/p5-Crypt-X509 -- missing RUN_DEPENDS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ashish
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 14 23:20:00 UTC 2014
>Closed-Date:    Thu Jan 16 05:24:08 UTC 2014
>Last-Modified:  Thu Jan 16 05:24:08 UTC 2014
>Originator:     Matthew Seaman
>Release:        FreeBSD 9.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lucid-nonsense.infracaninophile.co.uk 9.2-STABLE FreeBSD 9.2-STABLE #30 r259416: Sun Dec 15 18:37:44 GMT 2013 root@lucid-nonsense.infracaninophile.co.uk:/usr/obj/usr/src/sys/LUCID-NONSENSE amd64


	
>Description:
	

security/p5-Crypt-X509 has a BUILD_DEPENDS on
converters/p5-Convert-ASN1, but no matching RUN_DEPENDS.  Which is
necessary as the Crypt::X509 module uses Convert::ASN1

While here, stagify.

>How-To-Repeat:
	
>Fix:

	

--- p5-Crypt-X509.diff begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 339662)
+++ Makefile	(working copy)
@@ -11,11 +11,9 @@
 COMMENT=	Perl extension to parse X.509 certificates
 
 BUILD_DEPENDS=	p5-Convert-ASN1>=0:${PORTSDIR}/converters/p5-Convert-ASN1
+RUN_DEPENDS:=	${BUILD_DEPENDS}
 
 USES=		perl5
 USE_PERL5=	configure
 
-MAN3=		Crypt::X509.3
-
-NO_STAGE=	yes
 .include <bsd.port.mk>
Index: pkg-plist
===================================================================
--- pkg-plist	(revision 339662)
+++ pkg-plist	(working copy)
@@ -1,5 +1,6 @@
+%%PERL5_MAN3%%/Crypt::X509.3.gz
 %%SITE_PERL%%/Crypt/X509.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Crypt/X509/.packlist
-@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Crypt/X509/
+@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Crypt/X509
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Crypt
 @dirrmtry %%SITE_PERL%%/Crypt
--- p5-Crypt-X509.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ashish 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Jan 15 00:48:56 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185786 

From: ashish@FreeBSD.org (Ashish SHUKLA)
To: matthew@FreeBSD.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/185786: security/p5-Crypt-X509 -- missing RUN_DEPENDS
Date: Thu, 16 Jan 2014 10:09:34 +0530

 --=-=-=
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 Hi,
 
 Thanks for the diff. It seems to work fine on my 9.2-RELEASE host. I'll tes=
 t build
 on all platforms, and commit it when it completes successfully.
 
 Thanks!
 =2D-=20
 Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
 Sent from my Emacs
 
 --=-=-=
 Content-Type: application/pgp-signature; name="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iQIcBAEBCgAGBQJS12KKAAoJEMdGz6nnT6SwEMEQALbwu2teBEaOIzdMZ+asqQfM
 xAZODwWZFFojx6SWLfdDABBewfnb0equGkqyfAqGrCJi+r9B4DDPtqWq2H9UR6OB
 MK/V9fPUx2wyycMAXgcHnrRH4xJBr2Lbdv03jgSeuXG7u41yTtiRpZNWpmrRfLEH
 TwSn6ok+gKNY1IjcAOgBmSOOVwLHP0c5nuJNVVUvVDhOMABIV4tZ6jQS8RxMgsh8
 YWDyWQKKiRw9A9csH/tpBDas3kSYOYqhrIqYrFdnI2FdtWErIFLupUCxX75Ea/fo
 QKWjY7dPvEwvVT4c5C6D53iC4jngDjF13aLOWF3qrxNZXMPS4E2zXIv6Au8WtXWq
 LZwImJHZRPXlb0U/8u8Xa3rLQX3R9gnnMuDLW1a5ZFmWV7KDcEzwJMpeUrjNp+UX
 SMpD9T0AXHN0lXCp1zaxBvVPqZdRSTDfhl6YhNOVDn78xvY7SuPioJAZotafLWIT
 Hy7CKl5Lgc3g7TDGH4zTauDwZgCZwsCleHzsQVrwzhtQZ4Xcbl+hQvSGRUw+oFln
 YDUqqNLGjByL6S0LvKQ2k9PJXkJKgIwazsGSo2QZJovlJ0CLFhBunNQ6szuJv0qs
 kkvGJBC1iU4MehroARKtOOdVDlTFzaLAL92ukfIAd+PMkcaEOffPNljRnp1ICXcy
 NBP+ywqtchAsV8kC1lXl
 =Uw8A
 -----END PGP SIGNATURE-----
 --=-=-=--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/185786: commit references a PR
Date: Thu, 16 Jan 2014 05:01:02 +0000 (UTC)

 Author: ashish
 Date: Thu Jan 16 05:00:45 2014
 New Revision: 339891
 URL: http://svnweb.freebsd.org/changeset/ports/339891
 QAT: https://qat.redports.org/buildarchive/r339891/
 
 Log:
   - Add missing RUN_DEPENDS
   - Add STAGE support
   
   PR:		ports/185786
   Submitted by:	matthew
 
 Modified:
   head/security/p5-Crypt-X509/Makefile
   head/security/p5-Crypt-X509/pkg-plist
 
 Modified: head/security/p5-Crypt-X509/Makefile
 ==============================================================================
 --- head/security/p5-Crypt-X509/Makefile	Thu Jan 16 03:38:54 2014	(r339890)
 +++ head/security/p5-Crypt-X509/Makefile	Thu Jan 16 05:00:45 2014	(r339891)
 @@ -11,11 +11,9 @@ MAINTAINER=	ashish@FreeBSD.org
  COMMENT=	Perl extension to parse X.509 certificates
  
  BUILD_DEPENDS=	p5-Convert-ASN1>=0:${PORTSDIR}/converters/p5-Convert-ASN1
 +RUN_DEPENDS:=	${BUILD_DEPENDS}
  
  USES=		perl5
  USE_PERL5=	configure
  
 -MAN3=		Crypt::X509.3
 -
 -NO_STAGE=	yes
  .include <bsd.port.mk>
 
 Modified: head/security/p5-Crypt-X509/pkg-plist
 ==============================================================================
 --- head/security/p5-Crypt-X509/pkg-plist	Thu Jan 16 03:38:54 2014	(r339890)
 +++ head/security/p5-Crypt-X509/pkg-plist	Thu Jan 16 05:00:45 2014	(r339891)
 @@ -1,5 +1,6 @@
 +%%PERL5_MAN3%%/Crypt::X509.3.gz
  %%SITE_PERL%%/Crypt/X509.pm
  %%SITE_PERL%%/%%PERL_ARCH%%/auto/Crypt/X509/.packlist
 -@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Crypt/X509/
 +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Crypt/X509
  @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Crypt
  @dirrmtry %%SITE_PERL%%/Crypt
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: ashish 
State-Changed-When: Thu Jan 16 05:24:08 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185786 
>Unformatted:
