From nobody@FreeBSD.org  Tue Jan 14 20:03:36 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 645A125D
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Jan 2014 20:03:36 +0000 (UTC)
Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4EBD01D4B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Jan 2014 20:03:36 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id s0EK3Xv8092279
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Jan 2014 20:03:33 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id s0EK3X0O092278;
	Tue, 14 Jan 2014 20:03:33 GMT
	(envelope-from nobody)
Message-Id: <201401142003.s0EK3X0O092278@oldred.freebsd.org>
Date: Tue, 14 Jan 2014 20:03:33 GMT
From: Hardy Schumacher <hardy.schumacher@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [UPDATE] games/affenspiel, fix issues reported by portlint
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         185776
>Category:       ports
>Synopsis:       [UPDATE] games/affenspiel, fix issues reported by portlint
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ak
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 14 20:10:00 UTC 2014
>Closed-Date:    Fri Feb 07 12:54:44 UTC 2014
>Last-Modified:  Fri Feb  7 13:00:03 UTC 2014
>Originator:     Hardy Schumacher
>Release:        FreeBSD-9.2
>Organization:
>Environment:
FreeBSD gamma.low.org 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255996: Thu Oct  3 20:40:04 CEST 2013     root@gamma.low.org:/usr/obj/usr/src/sys/LOW_GAMMA  i386
>Description:
Portlint reported some issues related to new options framework and license settings.
>How-To-Repeat:
n/a
>Fix:


Patch attached with submission follows:

diff -ruN /usr/ports/games/affenspiel/Makefile ./affenspiel/Makefile
--- /usr/ports/games/affenspiel/Makefile	2013-11-07 19:22:28.000000000 +0100
+++ ./affenspiel/Makefile	2014-01-14 20:54:58.000000000 +0100
@@ -11,9 +11,9 @@
 COMMENT=	Little puzzle game with monkey for X Window System
 
 LICENSE=	unknown
-LICENSE_PERMS=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
-LICENSE_FILE=	${WRKSRC}/COPYRIGHT
 LICENSE_NAME=	just Copyright
+LICENSE_FILE=	${WRKSRC}/COPYRIGHT
+LICENSE_PERMS=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
 
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
@@ -28,10 +28,15 @@
 
 OPTIONS_DEFINE=	DOCS
 
+.include <bsd.port.options.mk>
+
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/affenspiel ${STAGEDIR}${PREFIX}/bin
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/COPYRIGHT ${STAGEDIR}${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}
+.for DOCFILE in PORTDOCS
+	${INSTALL_DATA} ${WRKSRC}/${DOCFILE} ${STAGEDIR}${DOCSDIR}
+.endfor
+.endif
 
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
Date: Wed, 5 Feb 2014 19:20:14 +0200
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Hardy Schumacher <hardy.schumacher@gmx.de>
Subject: Re: [UPDATE] games/affenspiel, fix issues

 Hi, Hardy
 
 There is no need to wrap docs installation in .if ${PORTS_OPTIONS:MDOCS}
 it's a bug in portlint, please see https://wiki.freebsd.org/ports/StageDir
 Also there is a handy trick for DOCS files installation:
 - ${INSTALL_DATA} ${WRKSRC}/COPYRIGHT ${STAGEDIR}${DOCSDIR}
 - ${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}
 + ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
 I'll commit these changes shortly, there is no need for you to update the patch.
 
 P.S. Perhaps you want to adopt this port?
 
 
 -- 
 Alex
Responsible-Changed-From-To: freebsd-ports-bugs->ak 
Responsible-Changed-By: ak 
Responsible-Changed-When: Fri Feb 7 12:54:35 UTC 2014 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185776 
State-Changed-From-To: open->closed 
State-Changed-By: ak 
State-Changed-When: Fri Feb 7 12:54:42 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185776 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/185776: commit references a PR
Date: Fri,  7 Feb 2014 12:52:58 +0000 (UTC)

 Author: ak
 Date: Fri Feb  7 12:52:51 2014
 New Revision: 343219
 URL: http://svnweb.freebsd.org/changeset/ports/343219
 QAT: https://qat.redports.org/buildarchive/r343219/
 
 Log:
   - Improve Makefile, pet portlint
   
   PR:	ports/185776 (based on)
   Submitted by:	Hardy Schumacher <hardy.schumacher@gmx.de>
 
 Modified:
   head/games/affenspiel/Makefile
 
 Modified: head/games/affenspiel/Makefile
 ==============================================================================
 --- head/games/affenspiel/Makefile	Fri Feb  7 12:41:40 2014	(r343218)
 +++ head/games/affenspiel/Makefile	Fri Feb  7 12:52:51 2014	(r343219)
 @@ -11,9 +11,9 @@ MAINTAINER=	ports@FreeBSD.org
  COMMENT=	Little puzzle game with monkey for X Window System
  
  LICENSE=	unknown
 -LICENSE_PERMS=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
 -LICENSE_FILE=	${WRKSRC}/COPYRIGHT
  LICENSE_NAME=	just Copyright
 +LICENSE_FILE=	${WRKSRC}/COPYRIGHT
 +LICENSE_PERMS=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
  
  WRKSRC=		${WRKDIR}/${PORTNAME}
  
 @@ -31,7 +31,6 @@ OPTIONS_DEFINE=	DOCS
  do-install:
  	${INSTALL_PROGRAM} ${WRKSRC}/affenspiel ${STAGEDIR}${PREFIX}/bin
  	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 -	${INSTALL_DATA} ${WRKSRC}/COPYRIGHT ${STAGEDIR}${DOCSDIR}
 -	${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}
 +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
