From root@ec-m.fr  Sun Jan 12 00:35:11 2014
Return-Path: <root@ec-m.fr>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 489407C2
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Jan 2014 00:35:11 +0000 (UTC)
Received: from melo.ec-m.fr (melo.ec-m.fr [147.94.19.139])
	by mx1.freebsd.org (Postfix) with ESMTP id 08B451346
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Jan 2014 00:35:10 +0000 (UTC)
Received: from amavis4.serv.int (amavis4.serv.int [10.3.0.48])
	by melo.ec-m.fr (GrosseBox 1743 XXL) with ESMTP id B3C3CACA7C;
	Sun, 12 Jan 2014 01:28:15 +0100 (CET)
Received: from melo.ec-m.fr ([10.3.0.13])
	by amavis4.serv.int (amavis4.serv.int [10.3.0.48]) (amavisd-new, port 10024)
	with LMTP id wTarjtUZlKtv; Sun, 12 Jan 2014 01:28:15 +0100 (CET)
Received: from dgeo.sysadm.ec-m.fr (dgeo.sysadm.ec-m.fr [147.94.19.169])
	by melo.ec-m.fr (GrosseBox 1743 XXL) with ESMTPS id 104FAAC9F2;
	Sun, 12 Jan 2014 01:28:15 +0100 (CET)
Received: (from root@localhost)
	by dgeo.sysadm.ec-m.fr (8.14.7/8.14.7/Submit) id s0C0SEUD012596;
	Sun, 12 Jan 2014 01:28:14 +0100 (CET)
	(envelope-from root)
Message-Id: <201401120028.s0C0SEUD012596@dgeo.sysadm.ec-m.fr>
Date: Sun, 12 Jan 2014 01:28:14 +0100 (CET)
From: Geoffroy Desvernay <dgeo@centrale-marseille.fr>
To: FreeBSD-gnats-submit@freebsd.org
Cc: hans@nordhaug.priv.no
Subject: [PATCH] www/piwik: add ctype and hash php deps
X-Send-Pr-Version: 3.113
X-GNATS-Notify: hans@nordhaug.priv.no

>Number:         185671
>Category:       ports
>Synopsis:       [PATCH] www/piwik: add ctype and hash php deps
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 12 00:40:00 UTC 2014
>Closed-Date:    Wed Jan 15 07:19:52 UTC 2014
>Last-Modified:  Wed Jan 15 07:19:52 UTC 2014
>Originator:     Geoffroy Desvernay
>Release:        FreeBSD 10.0-RC5 amd64
>Organization:
Ecole Centrale de Marseille
>Environment:
System: FreeBSD dgeo.sysadm.ec-m.fr 10.0-RC5 FreeBSD 10.0-RC5 #0 r260430: Wed Jan  8 05:10:04
>Description:
add two required php modules in deps

Port maintainer (hans@nordhaug.priv.no) is cc'd.

Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: SVN)
>How-To-Repeat:
try installing alone and look for missing functions in the logs (ans white page on the web side)
>Fix:
attached

--- piwik-2.0.2.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 339462)
+++ Makefile	(working copy)
@@ -13,7 +13,7 @@
 
 NO_BUILD=	yes
 SUB_FILES=	pkg-message
-USE_PHP=	dom gd iconv json session xml zlib
+USE_PHP=	dom gd iconv json session xml zlib ctype hash
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
 OPTIONS_DEFINE=	PHPPDOMYSQL PHPMYSQLI
--- piwik-2.0.2.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Jan 12 00:40:08 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185671 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: hans@nordhaug.priv.no
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/185671: [PATCH] www/piwik: add ctype and hash php deps
Date: Sun, 12 Jan 2014 00:40:08 UT

 Maintainer of www/piwik,
 
 Please note that PR ports/185671 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185671
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Hans Fr. Nordhaug" <hans@nordhaug.priv.no>
To: <bug-followup@FreeBSD.org>
Cc:  
Subject: Re: ports/185671: [PATCH] www/piwik: add ctype and hash php deps
Date: Sun, 12 Jan 2014 21:46:05 +0100

 Hi,
 
 I can confirm that the ctype and hash extensions are needed. Thx, Geoffroy!
 
 I accept the patch as it is, but prefer to have the list of extensions sorted:
 
     USE_PHP=    ctype dom gd hash iconv json session xml zlib
 
 Regards,
 Hans

From: "Hans Fr. Nordhaug" <hans@nordhaug.priv.no>
To: <bug-followup@FreeBSD.org>
Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>
Subject: Re: ports/185671: [PATCH] www/piwik: add ctype and hash php deps
Date: Tue, 14 Jan 2014 17:31:11 +0100

 I just got an email from Dag-Erling Smrgrav (des@) informing me that
 the filter extension also is needed. So the complete USE_PHP statement
 becomes:
 
     USE_PHP=    ctype dom filter gd hash iconv json session xml zlib
 
 Thx, Dag-Erling.
 
 Regards,
 Hans
 
 PS! There is a PR for updating Piwik to 2.0.3 too (ports/185739).
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Tue Jan 14 20:39:45 UTC 2014 
State-Changed-Why:  
Maintainer approved, but with changes. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185671 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Wed Jan 15 07:19:49 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185671 
>Unformatted:
