From root@adamw.org  Sat Jan 11 17:00:46 2014
Return-Path: <root@adamw.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 60DD46B4
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Jan 2014 17:00:46 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 1E2D810E7
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Jan 2014 17:00:45 +0000 (UTC)
Received: by apnoea.adamw.org (Postfix, from userid 0)
	id 1135311F892; Sat, 11 Jan 2014 12:00:39 -0500 (EST)
Message-Id: <20140111170039.1135311F892@apnoea.adamw.org>
Date: Sat, 11 Jan 2014 12:00:39 -0500 (EST)
From: Adam Weinberger <adamw@FreeBSD.org>
Reply-To: Adam Weinberger <adamw@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] devel/cmake does not respect unset=DOCS
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         185662
>Category:       ports
>Synopsis:       [patch] devel/cmake does not respect unset=DOCS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 11 17:10:01 UTC 2014
>Closed-Date:    Mon Mar 03 19:53:13 EST 2014
>Last-Modified:  Tue Mar  4 01:00:00 UTC 2014
>Originator:     Adam Weinberger
>Release:        FreeBSD 10.0-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD apnoea.adamw.org 10.0-PRERELEASE FreeBSD 10.0-PRERELEASE #1: Wed Jan 8 10:20:46 EST 2014 root@apnoea.adamw.org:/usr/obj/usr/src/sys/PEEP i386


	
>Description:

cmake forces docs installation even when explicitly unset by the user. It does
install a fairly large amount of documentation, so it'd be nice to be able to
prevent this.

Simply adding %%PORTDOCS%% in front of the applicable pkg-plist entries would
solve this.

>How-To-Repeat:
	
>Fix:

	

--- cmake-portdocs.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 339436)
+++ Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	cmake
 PORTVERSION=	2.8.12.1
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	http://downloads.cmake.org/files/v2.8/
 
Index: pkg-plist
===================================================================
--- pkg-plist	(revision 339436)
+++ pkg-plist	(working copy)
@@ -21,45 +21,45 @@
 %%DATADIR%%/editors/vim/cmake-indent.vim
 %%DATADIR%%/editors/vim/cmake-syntax.vim
 %%DATADIR%%/include/cmCPluginAPI.h
-%%DOCSDIR%%/Copyright.txt
-%%DOCSDIR%%/ccmake.docbook
-%%DOCSDIR%%/ccmake.html
-%%DOCSDIR%%/ccmake.txt
-%%DOCSDIR%%/cmake-commands.html
-%%DOCSDIR%%/cmake-commands.txt
-%%DOCSDIR%%/cmake-compatcommands.html
-%%DOCSDIR%%/cmake-compatcommands.txt
-%%DOCSDIR%%/cmake-modules.html
-%%DOCSDIR%%/cmake-modules.txt
-%%DOCSDIR%%/cmake-policies.html
-%%DOCSDIR%%/cmake-policies.txt
-%%DOCSDIR%%/cmake-properties.html
-%%DOCSDIR%%/cmake-properties.txt
-%%DOCSDIR%%/cmake-variables.html
-%%DOCSDIR%%/cmake-variables.txt
-%%DOCSDIR%%/cmake.docbook
-%%DOCSDIR%%/cmake.html
-%%DOCSDIR%%/cmake.txt
-%%DOCSDIR%%/cmcompress/Copyright.txt
-%%DOCSDIR%%/cmcurl/COPYING
-%%DOCSDIR%%/cmexpat/COPYING
-%%DOCSDIR%%/cmlibarchive/COPYING
-%%DOCSDIR%%/cmsys/Copyright.txt
-%%DOCSDIR%%/cmzlib/Copyright.txt
-%%DOCSDIR%%/cpack.docbook
-%%DOCSDIR%%/cpack.html
-%%DOCSDIR%%/cpack.txt
-%%DOCSDIR%%/ctest.docbook
-%%DOCSDIR%%/ctest.html
-%%DOCSDIR%%/ctest.txt
+%%PORTDOCS%%%%DOCSDIR%%/Copyright.txt
+%%PORTDOCS%%%%DOCSDIR%%/ccmake.docbook
+%%PORTDOCS%%%%DOCSDIR%%/ccmake.html
+%%PORTDOCS%%%%DOCSDIR%%/ccmake.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmake-commands.html
+%%PORTDOCS%%%%DOCSDIR%%/cmake-commands.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmake-compatcommands.html
+%%PORTDOCS%%%%DOCSDIR%%/cmake-compatcommands.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmake-modules.html
+%%PORTDOCS%%%%DOCSDIR%%/cmake-modules.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmake-policies.html
+%%PORTDOCS%%%%DOCSDIR%%/cmake-policies.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmake-properties.html
+%%PORTDOCS%%%%DOCSDIR%%/cmake-properties.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmake-variables.html
+%%PORTDOCS%%%%DOCSDIR%%/cmake-variables.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmake.docbook
+%%PORTDOCS%%%%DOCSDIR%%/cmake.html
+%%PORTDOCS%%%%DOCSDIR%%/cmake.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmcompress/Copyright.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmcurl/COPYING
+%%PORTDOCS%%%%DOCSDIR%%/cmexpat/COPYING
+%%PORTDOCS%%%%DOCSDIR%%/cmlibarchive/COPYING
+%%PORTDOCS%%%%DOCSDIR%%/cmsys/Copyright.txt
+%%PORTDOCS%%%%DOCSDIR%%/cmzlib/Copyright.txt
+%%PORTDOCS%%%%DOCSDIR%%/cpack.docbook
+%%PORTDOCS%%%%DOCSDIR%%/cpack.html
+%%PORTDOCS%%%%DOCSDIR%%/cpack.txt
+%%PORTDOCS%%%%DOCSDIR%%/ctest.docbook
+%%PORTDOCS%%%%DOCSDIR%%/ctest.html
+%%PORTDOCS%%%%DOCSDIR%%/ctest.txt
 share/emacs/site-lisp/cmake-mode.el
-@dirrm %%DOCSDIR%%/cmzlib
-@dirrm %%DOCSDIR%%/cmsys
-@dirrm %%DOCSDIR%%/cmlibarchive
-@dirrm %%DOCSDIR%%/cmexpat
-@dirrm %%DOCSDIR%%/cmcurl
-@dirrm %%DOCSDIR%%/cmcompress
-@dirrm %%DOCSDIR%%
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmzlib
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmsys
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmlibarchive
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmexpat
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmcurl
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmcompress
+%%PORTDOCS%%@dirrm %%DOCSDIR%%
 @dirrm %%DATADIR%%/include
 @dirrm %%DATADIR%%/editors/vim
 @dirrm %%DATADIR%%/editors/emacs
--- cmake-portdocs.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jan 11 17:10:14 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185662 

From: "Adam Weinberger" <adamw@adamw.org>
To: bug-followup@FreeBSD.org, adamw@FreeBSD.org, kde@freebsd.org
Cc:  
Subject: Re: ports/185662: [patch] devel/cmake does not respect unset=DOCS
Date: Mon, 03 Mar 2014 12:18:25 -0500

 Guys, any response on this? It's been 6 weeks with no response, and it's 
 a pretty trivial change. I'll commit this later today unless I hear 
 otherwise from the team.
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185662
 
 # Adam
 
 
 --
 Adam Weinberger
 adamw@adamw.org
 http://www.adamw.org
 
State-Changed-From-To: open->closed 
State-Changed-By: adamw 
State-Changed-When: Mon Mar 3 19:51:41 EST 2014 
State-Changed-Why:  
Committed, along with a PORTREVISION bump. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185662 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/185662: commit references a PR
Date: Tue,  4 Mar 2014 00:51:38 +0000 (UTC)

 Author: adamw
 Date: Tue Mar  4 00:51:30 2014
 New Revision: 346983
 URL: http://svnweb.freebsd.org/changeset/ports/346983
 QAT: https://qat.redports.org/buildarchive/r346983/
 
 Log:
   Add %%PORTDOCS%% to the plist, to honour UNSET=DOCS.
   PORTREVISION bump for the changed plist.
   
   PR:		ports/185662
   Approved by:	maintainer timeout (> 6 weeks)
 
 Modified:
   head/devel/cmake/Makefile
   head/devel/cmake/pkg-plist
 
 Modified: head/devel/cmake/Makefile
 ==============================================================================
 --- head/devel/cmake/Makefile	Tue Mar  4 00:48:17 2014	(r346982)
 +++ head/devel/cmake/Makefile	Tue Mar  4 00:51:30 2014	(r346983)
 @@ -3,6 +3,7 @@
  
  PORTNAME=	cmake
  PORTVERSION=	2.8.12.1
 +PORTREVISION?=	1
  CATEGORIES=	devel
  MASTER_SITES=	http://downloads.cmake.org/files/v2.8/
  
 
 Modified: head/devel/cmake/pkg-plist
 ==============================================================================
 --- head/devel/cmake/pkg-plist	Tue Mar  4 00:48:17 2014	(r346982)
 +++ head/devel/cmake/pkg-plist	Tue Mar  4 00:51:30 2014	(r346983)
 @@ -21,45 +21,45 @@ share/aclocal/cmake.m4
  %%DATADIR%%/editors/vim/cmake-indent.vim
  %%DATADIR%%/editors/vim/cmake-syntax.vim
  %%DATADIR%%/include/cmCPluginAPI.h
 -%%DOCSDIR%%/Copyright.txt
 -%%DOCSDIR%%/ccmake.docbook
 -%%DOCSDIR%%/ccmake.html
 -%%DOCSDIR%%/ccmake.txt
 -%%DOCSDIR%%/cmake-commands.html
 -%%DOCSDIR%%/cmake-commands.txt
 -%%DOCSDIR%%/cmake-compatcommands.html
 -%%DOCSDIR%%/cmake-compatcommands.txt
 -%%DOCSDIR%%/cmake-modules.html
 -%%DOCSDIR%%/cmake-modules.txt
 -%%DOCSDIR%%/cmake-policies.html
 -%%DOCSDIR%%/cmake-policies.txt
 -%%DOCSDIR%%/cmake-properties.html
 -%%DOCSDIR%%/cmake-properties.txt
 -%%DOCSDIR%%/cmake-variables.html
 -%%DOCSDIR%%/cmake-variables.txt
 -%%DOCSDIR%%/cmake.docbook
 -%%DOCSDIR%%/cmake.html
 -%%DOCSDIR%%/cmake.txt
 -%%DOCSDIR%%/cmcompress/Copyright.txt
 -%%DOCSDIR%%/cmcurl/COPYING
 -%%DOCSDIR%%/cmexpat/COPYING
 -%%DOCSDIR%%/cmlibarchive/COPYING
 -%%DOCSDIR%%/cmsys/Copyright.txt
 -%%DOCSDIR%%/cmzlib/Copyright.txt
 -%%DOCSDIR%%/cpack.docbook
 -%%DOCSDIR%%/cpack.html
 -%%DOCSDIR%%/cpack.txt
 -%%DOCSDIR%%/ctest.docbook
 -%%DOCSDIR%%/ctest.html
 -%%DOCSDIR%%/ctest.txt
 +%%PORTDOCS%%%%DOCSDIR%%/Copyright.txt
 +%%PORTDOCS%%%%DOCSDIR%%/ccmake.docbook
 +%%PORTDOCS%%%%DOCSDIR%%/ccmake.html
 +%%PORTDOCS%%%%DOCSDIR%%/ccmake.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-commands.html
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-commands.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-compatcommands.html
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-compatcommands.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-modules.html
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-modules.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-policies.html
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-policies.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-properties.html
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-properties.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-variables.html
 +%%PORTDOCS%%%%DOCSDIR%%/cmake-variables.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmake.docbook
 +%%PORTDOCS%%%%DOCSDIR%%/cmake.html
 +%%PORTDOCS%%%%DOCSDIR%%/cmake.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmcompress/Copyright.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmcurl/COPYING
 +%%PORTDOCS%%%%DOCSDIR%%/cmexpat/COPYING
 +%%PORTDOCS%%%%DOCSDIR%%/cmlibarchive/COPYING
 +%%PORTDOCS%%%%DOCSDIR%%/cmsys/Copyright.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cmzlib/Copyright.txt
 +%%PORTDOCS%%%%DOCSDIR%%/cpack.docbook
 +%%PORTDOCS%%%%DOCSDIR%%/cpack.html
 +%%PORTDOCS%%%%DOCSDIR%%/cpack.txt
 +%%PORTDOCS%%%%DOCSDIR%%/ctest.docbook
 +%%PORTDOCS%%%%DOCSDIR%%/ctest.html
 +%%PORTDOCS%%%%DOCSDIR%%/ctest.txt
  share/emacs/site-lisp/cmake-mode.el
 -@dirrm %%DOCSDIR%%/cmzlib
 -@dirrm %%DOCSDIR%%/cmsys
 -@dirrm %%DOCSDIR%%/cmlibarchive
 -@dirrm %%DOCSDIR%%/cmexpat
 -@dirrm %%DOCSDIR%%/cmcurl
 -@dirrm %%DOCSDIR%%/cmcompress
 -@dirrm %%DOCSDIR%%
 +%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmzlib
 +%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmsys
 +%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmlibarchive
 +%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmexpat
 +%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmcurl
 +%%PORTDOCS%%@dirrm %%DOCSDIR%%/cmcompress
 +%%PORTDOCS%%@dirrm %%DOCSDIR%%
  @dirrm %%DATADIR%%/include
  @dirrm %%DATADIR%%/editors/vim
  @dirrm %%DATADIR%%/editors/emacs
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
