From nobody@FreeBSD.org  Sun Jan  5 11:47:06 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id B0EB91D4
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  5 Jan 2014 11:47:06 +0000 (UTC)
Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 9C68F1836
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  5 Jan 2014 11:47:06 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id s05Bl6wE021961
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 5 Jan 2014 11:47:06 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id s05Bl6lS021952;
	Sun, 5 Jan 2014 11:47:06 GMT
	(envelope-from nobody)
Message-Id: <201401051147.s05Bl6lS021952@oldred.freebsd.org>
Date: Sun, 5 Jan 2014 11:47:06 GMT
From: Anton Sayetsky <vsjcfm@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] net/kdenetwork4: add optional dependency on knemo
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         185488
>Category:       ports
>Synopsis:       [patch] net/kdenetwork4: add optional dependency on knemo
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kde
>State:          suspended
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 05 11:50:00 UTC 2014
>Closed-Date:    
>Last-Modified:  Mon Mar 10 09:02:54 UTC 2014
>Originator:     Anton Sayetsky
>Release:        FreeBSD 9.2-RELEASE-p2 amd64
>Organization:
>Environment:
FreeBSD jnb.localdomain 9.2-RELEASE-p2 FreeBSD 9.2-RELEASE-p2 #0 r259302: Fri Dec 13 17:15:57 EET 2013     root@jnb.localdomain:/usr/obj/mnt/sysimage/usr/src/sys/JNB  amd64
>Description:
KNemo is must have KDE application, but not everyone knows about it. So I think that a dep should be added to kdenetwork4.
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
--- Makefile    (revision 338750)
+++ Makefile    (working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=      kdenetwork
 PORTVERSION=   ${KDE4_VERSION}
-PORTREVISION=  1
+PORTREVISION=  2
 CATEGORIES=    net kde ipv6
 MASTER_SITES=  ${MASTER_SITE_KDE}
 MASTER_SITE_SUBDIR=    ${KDE4_BRANCH}/${PORTVERSION}/src
@@ -38,8 +38,9 @@
                -DBUILD_krdc=off \
                -DBUILD_krfb=off
 
-OPTIONS_DEFINE=        KOPETE KRDC KRFB
+OPTIONS_DEFINE=        KNEMO KOPETE KRDC KRFB
 OPTIONS_DEFAULT=       ${OPTIONS_DEFINE}
+KNEMO_DESC=    KDE network monitor
 KOPETE_DESC=   Multi-protocol instant messenger
 KRDC_DESC=     RDP and VNC client for KDE
 KRFB_DESC=     VNC server for KDE
@@ -47,6 +48,10 @@
 NO_STAGE=      yes
 .include <bsd.port.options.mk>
 
+.if ${PORT_OPTIONS:MKNEMO}
+RUN_DEPENDS+=  ${KDE4_PREFIX}/bin/knemo:${PORTSDIR}/net/knemo-kde4
+.endif
+
 .if ${PORT_OPTIONS:MKOPETE}
 RUN_DEPENDS+=  ${KDE4_PREFIX}/bin/kopete:${PORTSDIR}/net-im/kopete-kde4
 .endif

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Jan 5 11:50:08 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185488 

From: Anton Sayetsky <vsjcfm@gmail.com>
To: Max Brazhnikov <makc@freebsd.org>, bug-followup@freebsd.org
Cc:  
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Fri, 10 Jan 2014 12:38:30 +0200

 2014/1/10 Max Brazhnikov <makc@freebsd.org>:
 > knemo is not a part of KDE SC, option for it in kdenetwork module could be misleading.
 But kdenetwork4 depends on Kopete, KRDC. These apps are listed here:
 http://kde.org/applications/internet/
 KNemo listed there also.

From: Max Brazhnikov <makc@freebsd.org>
To: bug-followup@freebsd.org, vsjcfm@gmail.com, kde-freebsd@kde.org
Cc:  
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Fri, 10 Jan 2014 10:35:21 +0000

 knemo is not a part of KDE SC, option for it in kdenetwork module could be misleading.
 
 Max

From: Anton Sayetsky <vsjcfm@gmail.com>
To: Max Brazhnikov <makc@freebsd.org>, bug-followup@freebsd.org
Cc:  
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Fri, 10 Jan 2014 14:13:13 +0200

 2014/1/10 Anton Sayetsky <vsjcfm@gmail.com>:
 > But kdenetwork4 depends on Kopete, KRDC. These apps are listed here:
 > http://kde.org/applications/internet/
 > KNemo listed there also.
 Yes, formally KNemo isn't a part of kdenetwork, it's a part of
 extragear. If your opinion about inclusion this dep won't change - PR
 may be closed.
 BTW, maybe we need meta-port named like "misc/kdeextragear4" as an alternative?

From: Max Brazhnikov <makc@freebsd.org>
To: Anton Sayetsky <vsjcfm@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Mon, 13 Jan 2014 10:22:16 +0000

 On Fri, 10 Jan 2014 14:13:13 +0200 Anton Sayetsky wrote:
 > 2014/1/10 Anton Sayetsky <vsjcfm@gmail.com>:
 > > But kdenetwork4 depends on Kopete, KRDC. These apps are listed here:
 > > http://kde.org/applications/internet/
 > > KNemo listed there also.
 
 Interesting turn :)
 
 > Yes, formally KNemo isn't a part of kdenetwork, it's a part of
 > extragear. If your opinion about inclusion this dep won't change - PR
 > may be closed.
 
 I actually like the idea to inform users about other KDE applications, but I
 don't think bloating port dependencies is appropriate way to do it.
 How about pkg-message with list of ports for the most popular apps (we can
 take above-mentioned from KDE site)?
 
 > BTW, maybe we need meta-port named like "misc/kdeextragear4" as an alternative?
 
 if you don't know about knemo, how would you know about kdeextragear4? :)
 
 Cheers,
 Max

From: Anton Sayetsky <vsjcfm@gmail.com>
To: Max Brazhnikov <makc@freebsd.org>, bug-followup@freebsd.org
Cc:  
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Tue, 14 Jan 2014 13:11:54 +0200

 2014/1/13 Max Brazhnikov <makc@freebsd.org>:
 > I actually like the idea to inform users about other KDE applications, but I
 > don't think bloating port dependencies is appropriate way to do it.
 > How about pkg-message with list of ports for the most popular apps (we can
 > take above-mentioned from KDE site)?
 
 > if you don't know about knemo, how would you know about kdeextragear4? :)
 
 I'll give you a single answer to above questions. :)
 I think that the best way is:
 1. Create meta-port for extragear (someone should find another
 extragear apps in ports tree).
 2. Add appropriate deps to it. (And remove duplicates from other kde*4 ports.)
 3. Add kdeextragear4 dep to x11/kde4.

From: Max Brazhnikov <makc@freebsd.org>
To: Anton Sayetsky <vsjcfm@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Wed, 15 Jan 2014 09:26:48 +0000

 On Tue, 14 Jan 2014 13:11:54 +0200 Anton Sayetsky wrote:
 > 2014/1/13 Max Brazhnikov <makc@freebsd.org>:
 > > I actually like the idea to inform users about other KDE applications, but I
 > > don't think bloating port dependencies is appropriate way to do it.
 > > How about pkg-message with list of ports for the most popular apps (we can
 > > take above-mentioned from KDE site)?
 > 
 > > if you don't know about knemo, how would you know about kdeextragear4? :)
 > 
 > I'll give you a single answer to above questions. :)
 > I think that the best way is:
 > 1. Create meta-port for extragear (someone should find another
 > extragear apps in ports tree).
 > 2. Add appropriate deps to it. (And remove duplicates from other kde*4 ports.)
 > 3. Add kdeextragear4 dep to x11/kde4.
 
 Fine! Are you willing to find all extragears in portstree and write a meta
 port?
 
 Max

From: Anton Sayetsky <vsjcfm@gmail.com>
To: Max Brazhnikov <makc@freebsd.org>, bug-followup@freebsd.org
Cc:  
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Wed, 15 Jan 2014 15:10:12 +0200

 2014/1/15 Max Brazhnikov <makc@freebsd.org>:
 > Fine! Are you willing to find all extragears in portstree and write a meta
 > port?
 Unforunately, I don't have a sufficient amount of time right now, but
 I can do this later.
 Should I send patch as followup to this PR or open new?
State-Changed-From-To: open->feedback 
State-Changed-By: makc 
State-Changed-When: Wed Jan 15 16:16:00 UTC 2014 
State-Changed-Why:  
Awaiting patch from submitter. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185488 

From: Max Brazhnikov <makc@freebsd.org>
To: Anton Sayetsky <vsjcfm@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Wed, 15 Jan 2014 16:14:10 +0000

 On Wed, 15 Jan 2014 15:10:12 +0200 Anton Sayetsky wrote:
 > 2014/1/15 Max Brazhnikov <makc@freebsd.org>:
 > > Fine! Are you willing to find all extragears in portstree and write a meta
 > > port?
 > Unforunately, I don't have a sufficient amount of time right now, but
 > I can do this later.
 > Should I send patch as followup to this PR or open new?
 
 No need for new PR, just send patch here.
 
 Max

From: Anton Sayetsky <vsjcfm@gmail.com>
To: Max Brazhnikov <makc@freebsd.org>, bug-followup@freebsd.org
Cc:  
Subject: Re: ports/185488: [patch] net/kdenetwork4: add optional dependency on knemo
Date: Tue, 4 Mar 2014 14:33:57 +0200

 2014-01-15 18:16 GMT+02:00  <makc@freebsd.org>:
 > Synopsis: [patch] net/kdenetwork4: add optional dependency on knemo
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: makc
 > State-Changed-When: Wed Jan 15 16:16:00 UTC 2014
 > State-Changed-Why:
 > Awaiting patch from submitter.
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=185488
 Please, suspend this PR - I cannot install current KDE so cannot test
 patch also. But don't close - maybe I'll solve this problem later or
 somebody else will write a patch.
State-Changed-From-To: feedback->suspended 
State-Changed-By: makc 
State-Changed-When: Mon Mar 10 09:02:53 UTC 2014 
State-Changed-Why:  
suspend till better times 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185488 
>Unformatted:
