From nobody@FreeBSD.org  Thu Jan  2 02:44:02 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id E768E828
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  2 Jan 2014 02:44:02 +0000 (UTC)
Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id D34221A8F
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  2 Jan 2014 02:44:02 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id s022i2Oi081766
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 2 Jan 2014 02:44:02 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id s022i2Vw081755;
	Thu, 2 Jan 2014 02:44:02 GMT
	(envelope-from nobody)
Message-Id: <201401020244.s022i2Vw081755@oldred.freebsd.org>
Date: Thu, 2 Jan 2014 02:44:02 GMT
From: Stephen Hurd <shurd@sasktel.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [Patch] sysutils/fonteditfs fix build when no GCC installed
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: uri@keves.org

>Number:         185405
>Category:       ports
>Synopsis:       [Patch] sysutils/fonteditfs fix build when no GCC installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marino
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 02 02:50:00 UTC 2014
>Closed-Date:    Sat Jan 25 14:43:18 UTC 2014
>Last-Modified:  Sat Jan 25 14:43:18 UTC 2014
>Originator:     Stephen Hurd
>Release:        10.0-RC3
>Organization:
>Environment:
FreeBSD portable 10.0-RC3 FreeBSD 10.0-RC3 #0 r259778: Mon Dec 23 23:27:58 UTC 2013     root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
sysutils/fonteditfs fails when no GCC is installed because "gcc" is hardcoded as the compiler.
>How-To-Repeat:
Build without gcc.
>Fix:
Patch attached.  Use ${CC}

Patch attached with submission follows:

Index: patch-Makefile
===================================================================
--- patch-Makefile	(revision 338414)
+++ patch-Makefile	(working copy)
@@ -1,6 +1,6 @@
---- Makefile.orig	2003-09-20 12:17:34.000000000 -0300
-+++ Makefile	2009-08-29 14:56:21.000000000 -0300
-@@ -2,12 +2,7 @@
+--- Makefile.orig	2003-09-20 08:17:34.000000000 -0700
++++ Makefile	2014-01-01 12:27:59.000000000 -0800
+@@ -2,14 +2,9 @@
  # - TODO: MAKE NEATER ONE 
  # This makefile should work under most POSIX OSes (at least FreeBSD)
  
@@ -12,8 +12,11 @@
 -
 +all: fnteditfs
  fnteditfs: fnteditfs.o font.o stack.o
- 	gcc -o fnteditfs fnteditfs.o font.o stack.o -lcurses
+-	gcc -o fnteditfs fnteditfs.o font.o stack.o -lcurses
++	${CC} -o fnteditfs fnteditfs.o font.o stack.o -lcurses
  	strip fnteditfs
+ 
+ fnteditfs.o: fnteditfs.c font.h stack.h
 @@ -17,8 +12,8 @@
  stack.o: stack.c stack.h
  


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jan 2 02:50:08 UTC 2014 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185405 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: uri@keves.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/185405: [Patch] sysutils/fonteditfs fix build when no GCC installed
Date: Thu, 2 Jan 2014 02:50:07 UT

 Maintainer of sysutils/fonteditfs,
 
 Please note that PR ports/185405 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185405
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Uri Shaked <uri@salsa4fun.co.il>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/185405: [Patch] sysutils/fonteditfs fix build when no GCC installed
Date: Tue, 7 Jan 2014 13:40:42 +0200

 --001a11c1bce8a5ade804ef5fd8d6
 Content-Type: text/plain; charset=ISO-8859-1
 
 I approve the patch.
 
 
 On Thu, Jan 2, 2014 at 4:50 AM, Edwin Groothuis <edwin@freebsd.org> wrote:
 
 > Maintainer of sysutils/fonteditfs,
 >
 > Please note that PR ports/185405 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185405
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 --001a11c1bce8a5ade804ef5fd8d6
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 <div dir=3D"ltr">I approve the patch.</div><div class=3D"gmail_extra"><br><=
 br><div class=3D"gmail_quote">On Thu, Jan 2, 2014 at 4:50 AM, Edwin Groothu=
 is <span dir=3D"ltr">&lt;<a href=3D"mailto:edwin@freebsd.org" target=3D"_bl=
 ank">edwin@freebsd.org</a>&gt;</span> wrote:<br>
 <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
 x #ccc solid;padding-left:1ex">Maintainer of sysutils/fonteditfs,<br>
 <br>
 Please note that PR ports/185405 has just been submitted.<br>
 <br>
 If it contains a patch for an upgrade, an enhancement or a bug fix<br>
 you agree on, reply to this email stating that you approve the patch<br>
 and a committer will take care of it.<br>
 <br>
 The full text of the PR can be found at:<br>
 =A0 =A0 <a href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/18540=
 5" target=3D"_blank">http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/185=
 405</a><br>
 <span class=3D"HOEnZb"><font color=3D"#888888"><br>
 --<br>
 Edwin Groothuis via the GNATS Auto Assign Tool<br>
 edwin@FreeBSD.org<br>
 </font></span></blockquote></div><br></div>
 
 --001a11c1bce8a5ade804ef5fd8d6--
State-Changed-From-To: feedback->open 
State-Changed-By: marino 
State-Changed-When: Sun Jan 19 14:48:59 UTC 2014 
State-Changed-Why:  
Maintainer has approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185405 
Responsible-Changed-From-To: freebsd-ports-bugs->marino 
Responsible-Changed-By: marino 
Responsible-Changed-When: Sat Jan 25 13:59:04 UTC 2014 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185405 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/185405: commit references a PR
Date: Sat, 25 Jan 2014 14:38:54 +0000 (UTC)

 Author: marino
 Date: Sat Jan 25 14:38:47 2014
 New Revision: 341040
 URL: http://svnweb.freebsd.org/changeset/ports/341040
 QAT: https://qat.redports.org/buildarchive/r341040/
 
 Log:
   sysutils/fonteditfs: Fix on FreeBSD 10+, support stage
   
   PR:		ports/185405
   Submitted by;	Stephen Hurd
   Approved by:	maintainer (Uri Shaked)
   Staged by:	marino@
 
 Modified:
   head/sysutils/fonteditfs/Makefile
   head/sysutils/fonteditfs/files/patch-Makefile
 
 Modified: head/sysutils/fonteditfs/Makefile
 ==============================================================================
 --- head/sysutils/fonteditfs/Makefile	Sat Jan 25 13:41:26 2014	(r341039)
 +++ head/sysutils/fonteditfs/Makefile	Sat Jan 25 14:38:47 2014	(r341040)
 @@ -6,17 +6,15 @@ PORTVERSION=	1.2
  CATEGORIES=	sysutils
  MASTER_SITES=	SF
  DISTNAME=	fnteditfs-${PORTVERSION}
 -EXTRACT_SUFX=.tgz
 +EXTRACT_SUFX=	.tgz
  
  MAINTAINER=	uri@keves.org
  COMMENT=	Full screen syscons font editor
  
 -MAN1=		fnteditfs.1
 -PLIST_FILES=	bin/fnteditfs
 +PLIST_FILES=	bin/fnteditfs man/man1/fnteditfs.1.gz
  
 -NO_STAGE=	yes
  post-patch:
 -	@${REINPLACE_CMD} -e 's|__PREFIX__|${PREFIX}|g ; \
 +	@${REINPLACE_CMD} -e 's|__PREFIX__|${STAGEDIR}${PREFIX}|g ; \
  		s|__INSTALL_MAN__|${INSTALL_MAN}|g ; \
  		s|__INSTALL_SCRIPT__|${INSTALL_SCRIPT}|g' ${WRKSRC}/Makefile
  
 
 Modified: head/sysutils/fonteditfs/files/patch-Makefile
 ==============================================================================
 --- head/sysutils/fonteditfs/files/patch-Makefile	Sat Jan 25 13:41:26 2014	(r341039)
 +++ head/sysutils/fonteditfs/files/patch-Makefile	Sat Jan 25 14:38:47 2014	(r341040)
 @@ -1,6 +1,6 @@
 ---- Makefile.orig	2003-09-20 12:17:34.000000000 -0300
 -+++ Makefile	2009-08-29 14:56:21.000000000 -0300
 -@@ -2,12 +2,7 @@
 +--- Makefile.orig	2003-09-20 08:17:34.000000000 -0700
 ++++ Makefile	2014-01-01 12:27:59.000000000 -0800
 +@@ -2,14 +2,9 @@
   # - TODO: MAKE NEATER ONE 
   # This makefile should work under most POSIX OSes (at least FreeBSD)
   
 @@ -12,8 +12,11 @@
  -
  +all: fnteditfs
   fnteditfs: fnteditfs.o font.o stack.o
 - 	gcc -o fnteditfs fnteditfs.o font.o stack.o -lcurses
 +-	gcc -o fnteditfs fnteditfs.o font.o stack.o -lcurses
 ++	${CC} -o fnteditfs fnteditfs.o font.o stack.o -lcurses
   	strip fnteditfs
 + 
 + fnteditfs.o: fnteditfs.c font.h stack.h
  @@ -17,8 +12,8 @@
   stack.o: stack.c stack.h
   
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: marino 
State-Changed-When: Sat Jan 25 14:43:17 UTC 2014 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185405 
>Unformatted:
