From rene@FreeBSD.org  Tue Dec 31 17:41:16 2013
Return-Path: <rene@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 8903C1C0
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Dec 2013 17:41:16 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 5C5C5131E
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Dec 2013 17:41:16 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rBVHfGYB024922
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Dec 2013 17:41:16 GMT
	(envelope-from rene@freefall.freebsd.org)
Received: (from rene@localhost)
	by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rBVHfGvB024921;
	Tue, 31 Dec 2013 17:41:16 GMT
	(envelope-from rene)
Message-Id: <201312311741.rBVHfGvB024921@freefall.freebsd.org>
Date: Tue, 31 Dec 2013 17:41:16 GMT
From: Rene Ladan <rene@freebsd.org>
Reply-To: Rene Ladan <rene@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: graphics/kix-kmod : stagify, cleanups
X-Send-Pr-Version: 3.114
X-GNATS-Notify: jon@witchspace.com

>Number:         185373
>Category:       ports
>Synopsis:       graphics/kix-kmod : stagify, cleanups
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rene
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 31 17:50:00 UTC 2013
>Closed-Date:    Tue Jan 07 17:45:03 UTC 2014
>Last-Modified:  Tue Jan  7 17:50:00 UTC 2014
>Originator:     Rene Ladan
>Release:        FreeBSD 11.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r259961: Fri Dec 27 21:56:39 UTC 2013 peter@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64

ports/head r338307
>Description:
- Stagify graphics/kix-kmod 
- cleanups for 'make check-sanity' and 'portlint -c'
- just include bsd.port.mk instead of bsd.{pre|post}.port.mk

The MASTER_SITES was defined wrongly, fixing that revealed a checksum mismatch (the file size is correct).
Can you verify that the changes are OK ?

Redports build: https://redports.org/buildarchive/20131231170201-61784

>How-To-Repeat:
Start removing NO_STAGE support from Mk/Uses/kmod.mk
>Fix:
Index: graphics/kix-kmod/Makefile
===================================================================
--- graphics/kix-kmod/Makefile	(revision 338307)
+++ graphics/kix-kmod/Makefile	(working copy)
@@ -5,17 +5,14 @@
 PORTVERSION=	1.0
 PORTREVISION=	1
 CATEGORIES=     graphics
-MASTER_SITES=   http://homepage.ntlworld.com/jon.belson/files/kix-1.0.tar.gz \
+MASTER_SITES=   http://homepage.ntlworld.com/jon.belson/files/ \
 	LOCAL/pgollucci
 PKGNAMESUFFIX=	-kmod
 
 MAINTAINER=	jon@witchspace.com
-COMMENT=	A graphical screensaver kernel module
+COMMENT=	Graphical screensaver kernel module
 
-NO_STAGE=	yes
-
 USES=		kmod
-.include <bsd.port.pre.mk>
 
 MAKE_ENV+=	WERROR=
 PLIST_FILES=	lib/kix_saver.ko
@@ -22,9 +19,6 @@
 SUB_FILES=	pkg-message
 
 do-install:
-	${INSTALL_KLD} ${WRKSRC}/kix_saver.ko ${PREFIX}/lib
+	${INSTALL_KLD} ${WRKSRC}/kix_saver.ko ${STAGEDIR}${PREFIX}/lib
 
-post-install:
-	@${CAT} ${PKGMESSAGE}
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
Index: graphics/kix-kmod/distinfo
===================================================================
--- graphics/kix-kmod/distinfo	(revision 338307)
+++ graphics/kix-kmod/distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (kix-1.0.tar.gz) = 372e7f294064fe7852086f7b977558339cf686c4d42a36d952d9479634aa475b
+SHA256 (kix-1.0.tar.gz) = 808f93721213a51251aa8614afa0b4852399eb7498bb20cd3410ad84c7645ce7
 SIZE (kix-1.0.tar.gz) = 3497
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Dec 31 17:50:07 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185373 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: jon@witchspace.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/185373: graphics/kix-kmod : stagify, cleanups
Date: Tue, 31 Dec 2013 17:50:06 UT

 Maintainer of graphics/kix-kmod,
 
 Please note that PR ports/185373 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185373
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->rene 
Responsible-Changed-By: rene 
Responsible-Changed-When: Tue Dec 31 18:26:45 UTC 2013 
Responsible-Changed-Why:  
Track 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185373 

From: Jonathan Belson <jon@witchspace.com>
To: bug-followup@FreeBSD.org,
 rene@freebsd.org
Cc:  
Subject: Re: ports/185373: graphics/kix-kmod : stagify, cleanups
Date: Tue, 7 Jan 2014 15:23:59 +0000

 Hiya
 
 [ Was it really a dozen years since I wrote this program!? :-O ]
 
 The changes look good, thanks.
 
 Cheers,
 
 =97Jon
 
State-Changed-From-To: feedback->closed 
State-Changed-By: rene 
State-Changed-When: Tue Jan 7 17:44:49 UTC 2014 
State-Changed-Why:  
Committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185373 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/185373: commit references a PR
Date: Tue,  7 Jan 2014 17:44:02 +0000 (UTC)

 Author: rene
 Date: Tue Jan  7 17:43:54 2014
 New Revision: 339014
 URL: http://svnweb.freebsd.org/changeset/ports/339014
 
 Log:
   - Stagify
   - Fix MASTER_SITES and recalculate SHA256 checksum
   - Pet portlint
   - Include bsd.port.mk once
   
   PR:		ports/185373
   Submitted by:	rene
   Approved by:	maintainer <jon@witchspace.com>
 
 Modified:
   head/graphics/kix-kmod/Makefile
   head/graphics/kix-kmod/distinfo
 
 Modified: head/graphics/kix-kmod/Makefile
 ==============================================================================
 --- head/graphics/kix-kmod/Makefile	Tue Jan  7 17:42:09 2014	(r339013)
 +++ head/graphics/kix-kmod/Makefile	Tue Jan  7 17:43:54 2014	(r339014)
 @@ -5,26 +5,20 @@ PORTNAME=       kix
  PORTVERSION=	1.0
  PORTREVISION=	1
  CATEGORIES=     graphics
 -MASTER_SITES=   http://homepage.ntlworld.com/jon.belson/files/kix-1.0.tar.gz \
 +MASTER_SITES=   http://homepage.ntlworld.com/jon.belson/files/ \
  	LOCAL/pgollucci
  PKGNAMESUFFIX=	-kmod
  
  MAINTAINER=	jon@witchspace.com
 -COMMENT=	A graphical screensaver kernel module
 -
 -NO_STAGE=	yes
 +COMMENT=	Graphical screensaver kernel module
  
  USES=		kmod
 -.include <bsd.port.pre.mk>
  
  MAKE_ENV+=	WERROR=
  PLIST_FILES=	lib/kix_saver.ko
  SUB_FILES=	pkg-message
  
  do-install:
 -	${INSTALL_KLD} ${WRKSRC}/kix_saver.ko ${PREFIX}/lib
 -
 -post-install:
 -	@${CAT} ${PKGMESSAGE}
 +	${INSTALL_KLD} ${WRKSRC}/kix_saver.ko ${STAGEDIR}${PREFIX}/lib
  
 -.include <bsd.port.post.mk>
 +.include <bsd.port.mk>
 
 Modified: head/graphics/kix-kmod/distinfo
 ==============================================================================
 --- head/graphics/kix-kmod/distinfo	Tue Jan  7 17:42:09 2014	(r339013)
 +++ head/graphics/kix-kmod/distinfo	Tue Jan  7 17:43:54 2014	(r339014)
 @@ -1,2 +1,2 @@
 -SHA256 (kix-1.0.tar.gz) = 372e7f294064fe7852086f7b977558339cf686c4d42a36d952d9479634aa475b
 +SHA256 (kix-1.0.tar.gz) = 808f93721213a51251aa8614afa0b4852399eb7498bb20cd3410ad84c7645ce7
  SIZE (kix-1.0.tar.gz) = 3497
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
