From delphij@FreeBSD.org  Mon Dec 30 20:48:37 2013
Return-Path: <delphij@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id EAA50681;
	Mon, 30 Dec 2013 20:48:37 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id D67DD1E60;
	Mon, 30 Dec 2013 20:48:37 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rBUKmbEj094203;
	Mon, 30 Dec 2013 20:48:37 GMT
	(envelope-from delphij@freefall.freebsd.org)
Received: (from delphij@localhost)
	by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rBUKmboh094202;
	Mon, 30 Dec 2013 20:48:37 GMT
	(envelope-from delphij)
Message-Id: <201312302048.rBUKmboh094202@freefall.freebsd.org>
Date: Mon, 30 Dec 2013 20:48:37 GMT
From: Xin LI <delphij@FreeBSD.org>
Reply-To: Xin LI <delphij@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: portmgr@FreeBSD.org
Subject: [PATCH] Mk/bsd.port.mk: add generic INSTALL_STRIPPED option for use with WITH_DEBUG
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         185309
>Category:       ports
>Synopsis:       [PATCH] Mk/bsd.port.mk: add generic INSTALL_STRIPPED option for use with WITH_DEBUG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 30 20:50:01 UTC 2013
>Closed-Date:    Wed May 28 15:59:58 UTC 2014
>Last-Modified:  Wed May 28 16:00:00 UTC 2014
>Originator:     Xin LI
>Release:        FreeBSD 11.0-CURRENT amd64
>Organization:
iXsystems, Inc.
>Environment:
System: FreeBSD freefall.freebsd.org 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r259961: Fri Dec 27 21:56:39 UTC 2013 peter@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64


>Description:
	(Note that this patch is from Alfred Perlstein).

	This proposed bsd.port.mk change adds a new option, INSTALL_STRIPPED,
which is intended to be used with WITH_DEBUG, allowing the system to build
packages with debugging symbols enabled and kept in build environment but
do not install them with the resulting binaries.

>How-To-Repeat:
>Fix:


--- bsd.port.mk.diff begins here ---
Index: Mk/bsd.port.mk
===================================================================
--- Mk/bsd.port.mk	(revision 337471)
+++ Mk/bsd.port.mk	(working copy)
@@ -1318,7 +1318,7 @@ WITH_DEBUG=	yes
 .endif
 
 # Reset value from bsd.own.mk.
-.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG)
+.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) && !defined(INSTALL_STRIPPED)
 STRIP=	#none
 .endif
 
@@ -1617,7 +1617,9 @@ CFLAGS:=	${CFLAGS:C/${_CPUCFLAGS}//}
 .endif
 
 .if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG)
+.if !defined(INSTALL_STRIPPED)
 STRIP_CMD=	${TRUE}
+.endif
 DEBUG_FLAGS?=	-g
 CFLAGS:=		${CFLAGS:N-O*:N-fno-strict*} ${DEBUG_FLAGS}
 .endif
--- bsd.port.mk.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Dec 30 20:50:08 UTC 2013 
Responsible-Changed-Why:  
bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185309 
State-Changed-From-To: open->closed 
State-Changed-By: bapt 
State-Changed-When: Wed May 28 15:59:57 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185309 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/185309: commit references a PR
Date: Wed, 28 May 2014 15:59:50 +0000 (UTC)

 Author: bapt
 Date: Wed May 28 15:59:47 2014
 New Revision: 355639
 URL: http://svnweb.freebsd.org/changeset/ports/355639
 QAT: https://qat.redports.org/buildarchive/r355639/
 
 Log:
   Add a new option, INSTALL_STRIPPED,
   which is intended to be used with WITH_DEBUG, allowing the system to build
   packages with debugging symbols enabled and kept in build environment but
   do not install them with the resulting binaries.
   
   PR:		ports/185309
   Submitted by:	delphij
   Reviewed by:	bdrewery
 
 Modified:
   head/Mk/bsd.port.mk
 
 Modified: head/Mk/bsd.port.mk
 ==============================================================================
 --- head/Mk/bsd.port.mk	Wed May 28 15:52:22 2014	(r355638)
 +++ head/Mk/bsd.port.mk	Wed May 28 15:59:47 2014	(r355639)
 @@ -1619,9 +1619,11 @@ CFLAGS:=	${CFLAGS:C/${_CPUCFLAGS}//}
  
  # Reset value from bsd.own.mk.
  .if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG)
 +.if !defined(INSTALL_STRIPPED)
  STRIP=	#none
  MAKE_ENV+=	DONTSTRIP=yes
  STRIP_CMD=	${TRUE}
 +.endif
  DEBUG_FLAGS?=	-g
  CFLAGS:=		${CFLAGS:N-O*:N-fno-strict*} ${DEBUG_FLAGS}
  .if defined(INSTALL_TARGET)
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
