From udvzsolt@gmail.com  Mon Dec 30 11:52:06 2013
Return-Path: <udvzsolt@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 3FBDB815
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 30 Dec 2013 11:52:06 +0000 (UTC)
Received: from mail-ea0-x22e.google.com (mail-ea0-x22e.google.com [IPv6:2a00:1450:4013:c01::22e])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id CB95115C3
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 30 Dec 2013 11:52:05 +0000 (UTC)
Received: by mail-ea0-f174.google.com with SMTP id b10so5036208eae.33
        for <FreeBSD-gnats-submit@freebsd.org>; Mon, 30 Dec 2013 03:52:03 -0800 (PST)
Received: from bsd-zsolt (91.82.104.15.pool.invitel.hu. [91.82.104.15])
        by mx.google.com with ESMTPSA id p45sm108032558eeg.1.2013.12.30.03.52.00
        for <multiple recipients>
        (version=TLSv1 cipher=RC4-SHA bits=128/128);
        Mon, 30 Dec 2013 03:52:02 -0800 (PST)
Received: by bsd-zsolt (sSMTP sendmail emulation); Mon, 30 Dec 2013 12:51:40 +0100
Message-Id: <52c15e62.456c0e0a.0893.42a6@mx.google.com>
Date: Mon, 30 Dec 2013 12:51:40 +0100
From: Zsolt Udvari <udvzsolt@gmail.com>
Reply-To: Zsolt Udvari <udvzsolt@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: <udvzsolt@gmail.com>
Subject: www/newsbeuter stage support, nls and podbeuter option
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         185289
>Category:       ports
>Synopsis:       www/newsbeuter stage support, nls and podbeuter option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    arved
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 30 12:00:00 UTC 2013
>Closed-Date:    Mon Dec 30 15:54:21 UTC 2013
>Last-Modified:  Mon Dec 30 16:00:00 UTC 2013
>Originator:     Zsolt Udvari
>Release:        FreeBSD 9.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD bsd-zsolt 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013 root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
www/newsbeuter support STAGEDIR (its Makefile uses DESTDIR), can build package as regular user (non-root).
Introduced NLS option support and PODCASTER option (install or not podbeuter-releated stuffs).
>How-To-Repeat:
>Fix:

--- newsbeuter-stage-nls.patch begins here ---
diff -ur /usr/ports/www/newsbeuter/Makefile newsbeuter/Makefile
--- /usr/ports/www/newsbeuter/Makefile	2013-11-09 16:57:18.000000000 +0100
+++ newsbeuter/Makefile	2013-12-30 12:39:33.000000000 +0100
@@ -17,15 +17,29 @@
 LICENSE=	MIT
 LICENSE_FILE=	${WRKSRC}/LICENSE
 
-USES=		gettext iconv ncurses gmake pkgconfig perl5
+OPTIONS_DEFINE= PODCAST
+PODCAST_DESC=	Podcast client (podbeuter)
+
+USES=		iconv ncurses gmake pkgconfig perl5
 USE_PERL5=	build
 USE_SQLITE=	yes
 USE_GNOME=	libxml2
 USE_GCC=	any
 
-MAN1=	newsbeuter.1 podbeuter.1
+.include  <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MNLS}
+PLIST_SUB+=	NLS=""
+USES+=gettext
+.else
+PLIST_SUB+= NLS="@comment "
+.endif
 
-NO_STAGE=	yes
+.if ${PORT_OPTIONS:MPODCAST}
+PLIST_SUB+=	PODCAST=""
+.else
+PLIST_SUB+=	PODCAST="@comment "
+.endif
 
 post-patch:
 	${REINPLACE_CMD} -e "s,share/man,man,; \
diff -ur /usr/ports/www/newsbeuter/pkg-plist newsbeuter/pkg-plist
--- /usr/ports/www/newsbeuter/pkg-plist	2013-04-02 12:02:19.000000000 +0200
+++ newsbeuter/pkg-plist	2013-12-30 12:40:19.000000000 +0100
@@ -1,23 +1,25 @@
 bin/newsbeuter
-bin/podbeuter
-share/locale/de/LC_MESSAGES/newsbeuter.mo
-share/locale/es/LC_MESSAGES/newsbeuter.mo
-share/locale/es_ES/LC_MESSAGES/newsbeuter.mo
-share/locale/fr/LC_MESSAGES/newsbeuter.mo
-share/locale/hu/LC_MESSAGES/newsbeuter.mo
-share/locale/it/LC_MESSAGES/newsbeuter.mo
-share/locale/nb/LC_MESSAGES/newsbeuter.mo
-share/locale/nl/LC_MESSAGES/newsbeuter.mo
-share/locale/pl/LC_MESSAGES/newsbeuter.mo
-share/locale/pt_BR/LC_MESSAGES/newsbeuter.mo
-share/locale/ru/LC_MESSAGES/newsbeuter.mo
-share/locale/sv/LC_MESSAGES/newsbeuter.mo
-share/locale/tr/LC_MESSAGES/newsbeuter.mo
-share/locale/uk/LC_MESSAGES/newsbeuter.mo
-share/locale/zh/LC_MESSAGES/newsbeuter.mo
-share/locale/zh_TW/LC_MESSAGES/newsbeuter.mo
+%%PODCAST%%bin/podbeuter
+%%NLS%%share/locale/de/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/es/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/es_ES/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/fr/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/hu/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/it/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/nb/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/nl/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/pl/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/pt_BR/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/ru/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/sv/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/tr/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/uk/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/zh/LC_MESSAGES/newsbeuter.mo
+%%NLS%%share/locale/zh_TW/LC_MESSAGES/newsbeuter.mo
 share/doc/newsbeuter/docbook-xsl.css
 share/doc/newsbeuter/newsbeuter.html
 share/doc/newsbeuter/examples/config
+man/man1/newsbeuter.1.gz
+%%PODCAST%%man/man1/podbeuter.1.gz
 @dirrm share/doc/newsbeuter/examples
 @dirrm share/doc/newsbeuter
--- newsbeuter-stage-nls.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->arved 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Dec 30 12:00:09 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185289 

From: =?ISO-8859-1?Q?Tilman_Keskin=F6z?= <arved@FreeBSD.org>
To: bug-followup@FreeBSD.org, udvzsolt@gmail.com
Cc:  
Subject: Re: ports/185289: www/newsbeuter stage support, nls and podbeuter
 option
Date: Mon, 30 Dec 2013 14:47:56 +0100

 Disabling NLS option results in:
 "msgfmt: Command not found" buildfailure
 
 Because of this failure i can not commit it, please provide an updated
 patch.
 
 Nice to have:
 * Please run portlint before submitting a patch
 * Please don't change the default installation (e.g. use OPTIONS_DEFAULT
 = PODCAST)
 

From: Zsolt Udvari <udvzsolt@gmail.com>
To: =?ISO-8859-1?Q?Tilman_Keskin=F6z?= <arved@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/185289: www/newsbeuter stage support, nls and podbeuter option
Date: Mon, 30 Dec 2013 15:24:36 +0100

 --047d7b33d7a819579804eec1348a
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Sorry, this was my failure. I think because of newsbeuter's Makefile
 isn't too easy to introduce NLS option into port.
 
 I've ran portlint and applied suggested modifications too. I hope it's
 perfect now.
 
 Thanks for feedback and corrections!
 
 
 2013/12/30 Tilman Keskin=F6z <arved@freebsd.org>:
 > Disabling NLS option results in:
 > "msgfmt: Command not found" buildfailure
 >
 > Because of this failure i can not commit it, please provide an updated
 > patch.
 >
 > Nice to have:
 > * Please run portlint before submitting a patch
 > * Please don't change the default installation (e.g. use OPTIONS_DEFAULT
 > =3D PODCAST)
 >
 
 --047d7b33d7a819579804eec1348a
 Content-Type: text/plain; charset=US-ASCII; name="newsbeuter.diff"
 Content-Disposition: attachment; filename="newsbeuter.diff"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_hptthffw0
 
 ZGlmZiAtdXIgL3Vzci9wb3J0cy93d3cvbmV3c2JldXRlci9NYWtlZmlsZSBuZXdzYmV1dGVyL01h
 a2VmaWxlCi0tLSAvdXNyL3BvcnRzL3d3dy9uZXdzYmV1dGVyL01ha2VmaWxlCTIwMTMtMTEtMDkg
 MTY6NTc6MTguMDAwMDAwMDAwICswMTAwCisrKyBuZXdzYmV1dGVyL01ha2VmaWxlCTIwMTMtMTIt
 MzAgMTU6MjI6MDAuMDAwMDAwMDAwICswMTAwCkBAIC0xMCwxMiArMTAsMTcgQEAKIE1BSU5UQUlO
 RVI9CWFydmVkQEZyZWVCU0Qub3JnCiBDT01NRU5UPQlBbiBSU1MgZmVlZCByZWFkZXIgZm9yIHRo
 ZSB0ZXh0IGNvbnNvbGUKIAotTElCX0RFUEVORFM9CXN0ZmwuMToke1BPUlRTRElSfS9kZXZlbC9z
 dGZsIFwKK0xJQ0VOU0U9CU1JVAorTElDRU5TRV9GSUxFPQkke1dSS1NSQ30vTElDRU5TRQorCitM
 SUJfREVQRU5EUz0Jc3RmbDoke1BPUlRTRElSfS9kZXZlbC9zdGZsIFwKIAkJY3VybDoke1BPUlRT
 RElSfS9mdHAvY3VybCBcCiAJCWxpYmpzb24uc286JHtQT1JUU0RJUn0vZGV2ZWwvanNvbi1jCiAK
 LUxJQ0VOU0U9CU1JVAotTElDRU5TRV9GSUxFPQkke1dSS1NSQ30vTElDRU5TRQorT1BUSU9OU19E
 RUZJTkU9IFBPRENBU1QKK1BPRENBU1RfREVTQz0JUG9kY2FzdCBjbGllbnQgKHBvZGJldXRlcikK
 KworT1BUSU9OU19ERUZBVUxUPSBQT0RDQVNUCiAKIFVTRVM9CQlnZXR0ZXh0IGljb252IG5jdXJz
 ZXMgZ21ha2UgcGtnY29uZmlnIHBlcmw1CiBVU0VfUEVSTDU9CWJ1aWxkCkBAIC0yMyw5ICsyOCwx
 MyBAQAogVVNFX0dOT01FPQlsaWJ4bWwyCiBVU0VfR0NDPQlhbnkKIAotTUFOMT0JbmV3c2JldXRl
 ci4xIHBvZGJldXRlci4xCisuaW5jbHVkZSAgPGJzZC5wb3J0Lm9wdGlvbnMubWs+CiAKLU5PX1NU
 QUdFPQl5ZXMKKy5pZiAke1BPUlRfT1BUSU9OUzpNUE9EQ0FTVH0KK1BMSVNUX1NVQis9CVBPRENB
 U1Q9IiIKKy5lbHNlCitQTElTVF9TVUIrPQlQT0RDQVNUPSJAY29tbWVudCAiCisuZW5kaWYKIAog
 cG9zdC1wYXRjaDoKIAkke1JFSU5QTEFDRV9DTUR9IC1lICJzLHNoYXJlL21hbixtYW4sOyBcCmRp
 ZmYgLXVyIC91c3IvcG9ydHMvd3d3L25ld3NiZXV0ZXIvcGtnLWRlc2NyIG5ld3NiZXV0ZXIvcGtn
 LWRlc2NyCi0tLSAvdXNyL3BvcnRzL3d3dy9uZXdzYmV1dGVyL3BrZy1kZXNjcgkyMDEyLTA3LTE0
 IDE2OjI5OjE4LjAwMDAwMDAwMCArMDIwMAorKysgbmV3c2JldXRlci9wa2ctZGVzY3IJMjAxMy0x
 Mi0zMCAxNDo1OTowNy4wMDAwMDAwMDAgKzAxMDAKQEAgLTEsNCArMSw0IEBACiBOZXdzYmV1dGVy
 IGlzIGFuIFJTUyBmZWVkIHJlYWRlciBmb3IgdGhlIHRleHQgY29uc29sZS4KIAogQXV0aG9yOglB
 bmRyZWFzIEtyZW5ubWFpcgotV1dXOglodHRwOi8vbmV3c2JldXRlci5vcmcvCitXV1c6IGh0dHA6
 Ly9uZXdzYmV1dGVyLm9yZy8KZGlmZiAtdXIgL3Vzci9wb3J0cy93d3cvbmV3c2JldXRlci9wa2ct
 cGxpc3QgbmV3c2JldXRlci9wa2ctcGxpc3QKLS0tIC91c3IvcG9ydHMvd3d3L25ld3NiZXV0ZXIv
 cGtnLXBsaXN0CTIwMTMtMDQtMDIgMTI6MDI6MTkuMDAwMDAwMDAwICswMjAwCisrKyBuZXdzYmV1
 dGVyL3BrZy1wbGlzdAkyMDEzLTEyLTMwIDE1OjE1OjU5LjAwMDAwMDAwMCArMDEwMApAQCAtMSw1
 ICsxLDUgQEAKIGJpbi9uZXdzYmV1dGVyCi1iaW4vcG9kYmV1dGVyCislJVBPRENBU1QlJWJpbi9w
 b2RiZXV0ZXIKIHNoYXJlL2xvY2FsZS9kZS9MQ19NRVNTQUdFUy9uZXdzYmV1dGVyLm1vCiBzaGFy
 ZS9sb2NhbGUvZXMvTENfTUVTU0FHRVMvbmV3c2JldXRlci5tbwogc2hhcmUvbG9jYWxlL2VzX0VT
 L0xDX01FU1NBR0VTL25ld3NiZXV0ZXIubW8KQEAgLTE5LDUgKzE5LDcgQEAKIHNoYXJlL2RvYy9u
 ZXdzYmV1dGVyL2RvY2Jvb2steHNsLmNzcwogc2hhcmUvZG9jL25ld3NiZXV0ZXIvbmV3c2JldXRl
 ci5odG1sCiBzaGFyZS9kb2MvbmV3c2JldXRlci9leGFtcGxlcy9jb25maWcKK21hbi9tYW4xL25l
 d3NiZXV0ZXIuMS5negorJSVQT0RDQVNUJSVtYW4vbWFuMS9wb2RiZXV0ZXIuMS5negogQGRpcnJt
 IHNoYXJlL2RvYy9uZXdzYmV1dGVyL2V4YW1wbGVzCiBAZGlycm0gc2hhcmUvZG9jL25ld3NiZXV0
 ZXIK
 --047d7b33d7a819579804eec1348a--
State-Changed-From-To: open->closed 
State-Changed-By: arved 
State-Changed-When: Mon Dec 30 15:54:16 UTC 2013 
State-Changed-Why:  
committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185289 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/185289: commit references a PR
Date: Mon, 30 Dec 2013 15:54:11 +0000 (UTC)

 Author: arved
 Date: Mon Dec 30 15:53:58 2013
 New Revision: 338124
 URL: http://svnweb.freebsd.org/changeset/ports/338124
 
 Log:
   * Support Stagedir
   * Add Option to disable Podcast client
   
   PR:		185289
   Submitted by:	 	Zsolt Udvari <udvzsolt@gmail.com>
 
 Modified:
   head/www/newsbeuter/Makefile
   head/www/newsbeuter/pkg-descr
   head/www/newsbeuter/pkg-plist
 
 Modified: head/www/newsbeuter/Makefile
 ==============================================================================
 --- head/www/newsbeuter/Makefile	Mon Dec 30 15:49:37 2013	(r338123)
 +++ head/www/newsbeuter/Makefile	Mon Dec 30 15:53:58 2013	(r338124)
 @@ -10,12 +10,17 @@ MASTER_SITES=	http://newsbeuter.org/down
  MAINTAINER=	arved@FreeBSD.org
  COMMENT=	An RSS feed reader for the text console
  
 -LIB_DEPENDS=	stfl.1:${PORTSDIR}/devel/stfl \
 +LICENSE=	MIT
 +LICENSE_FILE=	${WRKSRC}/LICENSE
 +
 +LIB_DEPENDS=	stfl:${PORTSDIR}/devel/stfl \
  		curl:${PORTSDIR}/ftp/curl \
  		libjson.so:${PORTSDIR}/devel/json-c
  
 -LICENSE=	MIT
 -LICENSE_FILE=	${WRKSRC}/LICENSE
 +OPTIONS_DEFINE= PODCAST
 +PODCAST_DESC=	Podcast client (podbeuter)
 +
 +OPTIONS_DEFAULT= PODCAST
  
  USES=		gettext iconv ncurses gmake pkgconfig perl5
  USE_PERL5=	build
 @@ -23,9 +28,13 @@ USE_SQLITE=	yes
  USE_GNOME=	libxml2
  USE_GCC=	any
  
 -MAN1=	newsbeuter.1 podbeuter.1
 +.include  <bsd.port.options.mk>
  
 -NO_STAGE=	yes
 +.if ${PORT_OPTIONS:MPODCAST}
 +PLIST_SUB+=	PODCAST=""
 +.else
 +PLIST_SUB+=	PODCAST="@comment "
 +.endif
  
  post-patch:
  	${REINPLACE_CMD} -e "s,share/man,man,; \
 
 Modified: head/www/newsbeuter/pkg-descr
 ==============================================================================
 --- head/www/newsbeuter/pkg-descr	Mon Dec 30 15:49:37 2013	(r338123)
 +++ head/www/newsbeuter/pkg-descr	Mon Dec 30 15:53:58 2013	(r338124)
 @@ -1,4 +1,4 @@
  Newsbeuter is an RSS feed reader for the text console.
  
  Author:	Andreas Krennmair
 -WWW:	http://newsbeuter.org/
 +WWW: http://newsbeuter.org/
 
 Modified: head/www/newsbeuter/pkg-plist
 ==============================================================================
 --- head/www/newsbeuter/pkg-plist	Mon Dec 30 15:49:37 2013	(r338123)
 +++ head/www/newsbeuter/pkg-plist	Mon Dec 30 15:53:58 2013	(r338124)
 @@ -1,5 +1,5 @@
  bin/newsbeuter
 -bin/podbeuter
 +%%PODCAST%%bin/podbeuter
  share/locale/de/LC_MESSAGES/newsbeuter.mo
  share/locale/es/LC_MESSAGES/newsbeuter.mo
  share/locale/es_ES/LC_MESSAGES/newsbeuter.mo
 @@ -19,5 +19,7 @@ share/locale/zh_TW/LC_MESSAGES/newsbeute
  share/doc/newsbeuter/docbook-xsl.css
  share/doc/newsbeuter/newsbeuter.html
  share/doc/newsbeuter/examples/config
 +man/man1/newsbeuter.1.gz
 +%%PODCAST%%man/man1/podbeuter.1.gz
  @dirrm share/doc/newsbeuter/examples
  @dirrm share/doc/newsbeuter
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
