From cmt@elch.exwg.net  Sat Dec 28 22:45:55 2013
Return-Path: <cmt@elch.exwg.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 4B62651B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 28 Dec 2013 22:45:55 +0000 (UTC)
Received: from smtp.burggraben.net (base.exwg.net [IPv6:2a01:4f8:140:50a2::2])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 07A9B1118
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 28 Dec 2013 22:45:55 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by smtp.burggraben.net (Postfix) with ESMTP id A46C96003CF
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 28 Dec 2013 23:45:52 +0100 (CET)
Received: from smtp.burggraben.net ([127.0.0.1])
	by localhost (ns.burggraben.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id izzb44yBZGdE for <FreeBSD-gnats-submit@freebsd.org>;
	Sat, 28 Dec 2013 23:45:52 +0100 (CET)
Received: from elch.exwg.net (elch.exwg.net [IPv6:2001:470:7b43:1:6a05:caff:fe01:aae9])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "elch.exwg.net", Issuer "Christoph Moench-Tegeder" (verified OK))
	by smtp.burggraben.net (Postfix) with ESMTPS
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 28 Dec 2013 23:45:52 +0100 (CET)
Received: by elch.exwg.net (Postfix, from userid 1000)
	id B6FF4313DD; Sat, 28 Dec 2013 23:45:51 +0100 (CET)
Message-Id: <20131228224551.B6FF4313DD@elch.exwg.net>
Date: Sat, 28 Dec 2013 23:45:51 +0100 (CET)
From: Christoph Moench-Tegeder <cmt@burggraben.net>
Reply-To: Christoph Moench-Tegeder <cmt@burggraben.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: shells/ksh93 : fix exec/unexec entries in pkg-plist
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         185255
>Category:       ports
>Synopsis:       shells/ksh93 : fix exec/unexec entries in pkg-plist
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 28 22:50:00 UTC 2013
>Closed-Date:    Tue Dec 31 13:51:57 UTC 2013
>Last-Modified:  Tue Dec 31 14:00:00 UTC 2013
>Originator:     Christoph Moench-Tegeder
>Release:        FreeBSD 9.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD elch.exwg.net 9.2-RELEASE FreeBSD 9.2-RELEASE #11 r255911: Fri Sep 27 17:09:40 CEST 2013 cmt@elch.exwg.net:/usr/obj/usr/src/sys/ELCH amd64

shells/ksh93       ksh93-20120801_1

>Description:
	Installing ksh93 adds the manpage (/usr/local/man/man1/ksh93.1.gz)
	to /etc/shells, which is not very helpful.
>How-To-Repeat:

>Fix:
	According to the documentation in https://wiki.freebsd.org/ports/StageDir
	and pkg_create(1)/pkg-create(1), the @exec command corresponds to the
	last installed file, and the @unexec command should go before that
	file in pkg-plist.

Index: pkg-plist
===================================================================
--- pkg-plist	(revision 337927)
+++ pkg-plist	(working copy)
@@ -1,7 +1,7 @@
+@unexec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells
 bin/ksh93
+@exec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells; echo %D/%F >> /etc/shells
 man/man1/ksh93.1.gz
-@exec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells; echo %D/%F >> /etc/shells
-@unexec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/dirs
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/popd
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/pushd


Regards,
Christoph
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Dec 28 22:50:09 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185255 
State-Changed-From-To: open->closed 
State-Changed-By: sunpoet 
State-Changed-When: Tue Dec 31 13:51:56 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185255 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/185255: commit references a PR
Date: Tue, 31 Dec 2013 13:51:53 +0000 (UTC)

 Author: sunpoet
 Date: Tue Dec 31 13:51:46 2013
 New Revision: 338305
 URL: http://svnweb.freebsd.org/changeset/ports/338305
 
 Log:
   - Fix /etc/shells manipulation
   
   PR:		ports/185255
   Submitted by:	Christoph Moench-Tegeder <cmt@burggraben.net>
 
 Modified:
   head/shells/ksh93/pkg-plist   (contents, props changed)
 
 Modified: head/shells/ksh93/pkg-plist
 ==============================================================================
 --- head/shells/ksh93/pkg-plist	Tue Dec 31 13:35:06 2013	(r338304)
 +++ head/shells/ksh93/pkg-plist	Tue Dec 31 13:51:46 2013	(r338305)
 @@ -1,7 +1,7 @@
 +@unexec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells
  bin/ksh93
 -man/man1/ksh93.1.gz
  @exec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells; echo %D/%F >> /etc/shells
 -@unexec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells
 +man/man1/ksh93.1.gz
  %%PORTEXAMPLES%%%%EXAMPLESDIR%%/dirs
  %%PORTEXAMPLES%%%%EXAMPLESDIR%%/popd
  %%PORTEXAMPLES%%%%EXAMPLESDIR%%/pushd
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
