From nobody@FreeBSD.org  Thu Dec 12 13:20:21 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id C02D16CF
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 12 Dec 2013 13:20:21 +0000 (UTC)
Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 93F9C1108
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 12 Dec 2013 13:20:21 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rBCDKLCh022820
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 12 Dec 2013 13:20:21 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rBCDKLQJ022807;
	Thu, 12 Dec 2013 13:20:21 GMT
	(envelope-from nobody)
Message-Id: <201312121320.rBCDKLQJ022807@oldred.freebsd.org>
Date: Thu, 12 Dec 2013 13:20:21 GMT
From: Reed Loefgren <rloefgren@forethought.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Issue with libscrypt port
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: horia@racoviceanu.com

>Number:         184723
>Category:       ports
>Synopsis:       Issue with security/libscrypt
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nemysis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 12 13:30:01 UTC 2013
>Closed-Date:    Mon Dec 16 16:49:53 UTC 2013
>Last-Modified:  Mon Dec 16 17:00:00 UTC 2013
>Originator:     Reed Loefgren
>Release:        9.2 in a jail
>Organization:
>Environment:
FreeBSD auden.jmla.com 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255937M: Sun Sep 29 12:13:37 MDT 2013     x@blah.blaher.com:/usr/obj/u1/src/sys/GENERIC  amd6
>Description:
Probably nothing but last night when doing a make clean on the ports directory it failed with this error:
..
===>  Cleaning for libp11-0.2.8
===> security/libprelude
===>  Cleaning for libprelude-1.0.1_3
===> security/libpreludedb
===>  Cleaning for libpreludedb-1.0.1p1_2
===> security/libpwstor
===>  Cleaning for libpwstor-0.1
===> security/libscrypt
Unknown modifier 't'

"Makefile", line 37: Malformed conditional (!empty(CCVERSION:tl:M*gcc*))
"Makefile", line 40: if-less endif
make: fatal errors encountered -- cannot continue
*** Error code 1

Stop in /usr/ports/security.
*** Error code 1

Stop in /usr/ports.

So I went there:

orange [128] [12:22am] [/usr/ports]$ mv security/libscrypt /tmp/libscrypt
orange [129] [6:04am] [/usr/ports]$ less /tmp/libscrypt/Makefile 
# Created by: Horia Racoviceanu <horia@racoviceanu.com>
# $FreeBSD: head/security/libscrypt/Makefile 333338 2013-11-09 21:30:28Z jpaetzel $

PORTNAME=       libscrypt
PORTVERSION=    1.14
CATEGORIES=     security

MAINTAINER=     horia@racoviceanu.com
COMMENT=        C library for the scrypt key derivation function

LICENSE=        BSD

NO_STAGE=       yes
USE_LDCONFIG=   yes
USE_GITHUB=     yes
GH_ACCOUNT=     technion
GH_COMMIT=      8e6966e
GH_TAGNAME=     ${GH_COMMIT}

PLIST_FILES=    include/libscrypt.h \
                lib/libscrypt.a \
                lib/libscrypt.so \
                lib/libscrypt.so.0

.include <bsd.port.pre.mk>

post-patch:
        @${REINPLACE_CMD} -e '/^CC=gcc/d' -e '/CFLAGS=/s,$$, ${CFLAGS},' \
..skipping...
.if !empty(CCVERSION:tl:M*gcc*)
CFLAGS+=    -fno-stack-protector
.endif
                -e 's,$$(LDFLAGS),,' ${WRKSRC}/Makefile

regression-test: build
        (cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} check)

.if ${ARCH} == i386
CCVERSION!= ${CC} --version
.if !empty(CCVERSION:tl:M*gcc*)
CFLAGS+=    -fno-stack-protector
.endif
.endif

.include <bsd.port.post.mk>
~
~
<end>

Probably just a corrupt svn update. I'd done several, trying to get owncloud to cut it out with the blank screen (FWIW, known, and to be fixed in the next update). I'm programming ignorant but think I see the problem. Something so obvious in a Makefile?

Kindest regards,

Reed
>How-To-Repeat:
Don't know. Move port, re-svn and compare Makefiles.
>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Dec 12 13:49:53 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=184723 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: horia@racoviceanu.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/184723: Issue with security/libscrypt
Date: Thu, 12 Dec 2013 13:49:52 UT

 Maintainer of security/libscrypt,
 
 Please note that PR ports/184723 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184723
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->nemysis 
Responsible-Changed-By: nemysis 
Responsible-Changed-When: Fri Dec 13 10:32:34 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=184723 

From: Horia Racoviceanu <horia@racoviceanu.com>
To: bug-followup@FreeBSD.org, rloefgren@forethought.net
Cc:  
Subject: Re: ports/184723: Issue with security/libscrypt
Date: Fri, 13 Dec 2013 13:13:31 +0000

 --047d7b5d5a4295474d04ed6a3ac3
 Content-Type: text/plain; charset=ISO-8859-1
 
 - Bump PORTREVISION
 - Change license BSD --> BSD2CLAUSE
 - Change REINPLACE_CMD
 - Fix tabs
 - Remove NO_STAGE
 
 Build log:
 https://redports.org/buildarchive/20131213084819-49003/
 
 I could not reproduce:
 Unknown modifier 't'
 
 :tl Converts variable to lower-case letters.
 http://www.freebsd.org/cgi/man.cgi?query=make
 
 --047d7b5d5a4295474d04ed6a3ac3
 Content-Type: text/plain; charset=US-ASCII; name="libscrypt.diff"
 Content-Disposition: attachment; filename="libscrypt.diff"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_hp57vtl10
 
 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1ha2VmaWxlCShyZXZpc2lvbiAzMzYzMzEp
 CisrKyBNYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMywxOSArMywxOSBAQAogCiBQT1JUTkFN
 RT0JbGlic2NyeXB0CiBQT1JUVkVSU0lPTj0JMS4xNAorUE9SVFJFVklTSU9OPQkxCiBDQVRFR09S
 SUVTPQlzZWN1cml0eQogCiBNQUlOVEFJTkVSPQlob3JpYUByYWNvdmljZWFudS5jb20KIENPTU1F
 TlQ9CUMgbGlicmFyeSBmb3IgdGhlIHNjcnlwdCBrZXkgZGVyaXZhdGlvbiBmdW5jdGlvbgogCi1M
 SUNFTlNFPQlCU0QKK0xJQ0VOU0U9CUJTRDJDTEFVU0UKIAotTk9fU1RBR0U9CXllcwogVVNFX0xE
 Q09ORklHPQl5ZXMKIFVTRV9HSVRIVUI9CXllcwogR0hfQUNDT1VOVD0JdGVjaG5pb24KK0dIX1RB
 R05BTUU9CSR7R0hfQ09NTUlUfQogR0hfQ09NTUlUPQk4ZTY5NjZlCi1HSF9UQUdOQU1FPQkke0dI
 X0NPTU1JVH0KIAogUExJU1RfRklMRVM9CWluY2x1ZGUvbGlic2NyeXB0LmggXAogCQlsaWIvbGli
 c2NyeXB0LmEgXApAQCAtMjUsMTggKzI1LDE5IEBACiAuaW5jbHVkZSA8YnNkLnBvcnQucHJlLm1r
 PgogCiBwb3N0LXBhdGNoOgotCUAke1JFSU5QTEFDRV9DTUR9IC1lICcvXkNDPWdjYy9kJyAtZSAn
 L0NGTEFHUz0vcywkJCwgJHtDRkxBR1N9LCcgXAotCQktZSAncywvdXNyL2xvY2FsLCR7UFJFRklY
 fSwnIC1lICdzLGluc3RhbGw6IGxpYnJhcnksJiBpbnN0YWxsLXN0YXRpYywnIFwKLQkJLWUgJ3Ms
 JCQoTERGTEFHUyksLCcgJHtXUktTUkN9L01ha2VmaWxlCisJQCR7UkVJTlBMQUNFX0NNRH0gLWUg
 Jy9eQ0M9Z2NjL2QnIC1lICcvQ0ZMQUdTPS9zfCQkfCAke0NGTEFHU318JyBcCisJCS1lICdzfC91
 c3IvbG9jYWx8JHtQUkVGSVh9fCA7IFwKKwkJc3xpbnN0YWxsOiBsaWJyYXJ5fCYgaW5zdGFsbC1z
 dGF0aWN8IDsgXAorCQlzfCQkKExERkxBR1MpfHwnICR7V1JLU1JDfS9NYWtlZmlsZQogCiByZWdy
 ZXNzaW9uLXRlc3Q6IGJ1aWxkCiAJKGNkICR7V1JLU1JDfSAmJiAke1NFVEVOVn0gJHtNQUtFX0VO
 Vn0gJHtNQUtFfSBjaGVjaykKIAogLmlmICR7QVJDSH0gPT0gaTM4NgotQ0NWRVJTSU9OIT0gJHtD
 Q30gLS12ZXJzaW9uCi0uaWYgIWVtcHR5KENDVkVSU0lPTjp0bDpNKmdjYyopCi1DRkxBR1MrPSAg
 ICAtZm5vLXN0YWNrLXByb3RlY3RvcgorQ0NWRVJTSU9OIT0JJHtDQ30gLS12ZXJzaW9uCisuIGlm
 ICFlbXB0eShDQ1ZFUlNJT046dGw6TSpnY2MqKQorQ0ZMQUdTKz0JLWZuby1zdGFjay1wcm90ZWN0
 b3IKKy4gZW5kaWYKIC5lbmRpZgotLmVuZGlmCiAKIC5pbmNsdWRlIDxic2QucG9ydC5wb3N0Lm1r
 Pgo=
 --047d7b5d5a4295474d04ed6a3ac3--
State-Changed-From-To: feedback->closed 
State-Changed-By: nemysis 
State-Changed-When: Mon Dec 16 16:49:52 UTC 2013 
State-Changed-Why:  
Maintainer have fixed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=184723 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/184723: commit references a PR
Date: Mon, 16 Dec 2013 16:50:06 +0000 (UTC)

 Author: nemysis
 Date: Mon Dec 16 16:49:59 2013
 New Revision: 336645
 URL: http://svnweb.freebsd.org/changeset/ports/336645
 
 Log:
   - Bump PORTREVISION
   - Change license BSD --> BSD2CLAUSE
   - Add USES compiler
   - Add DOCS and Option
   - Change REINPLACE_CMD
   - Fix build, tabs
   - Support STAGEDIR
   
   PR:		ports/184723
   Submitted by:	Reed Loefgren <rloefgren@forethought.net>
   Approved by:	wg (mentor)
 
 Modified:
   head/security/libscrypt/Makefile
 
 Modified: head/security/libscrypt/Makefile
 ==============================================================================
 --- head/security/libscrypt/Makefile	Mon Dec 16 15:49:55 2013	(r336644)
 +++ head/security/libscrypt/Makefile	Mon Dec 16 16:49:59 2013	(r336645)
 @@ -3,40 +3,47 @@
  
  PORTNAME=	libscrypt
  PORTVERSION=	1.14
 +PORTREVISION=	1
  CATEGORIES=	security
  
  MAINTAINER=	horia@racoviceanu.com
  COMMENT=	C library for the scrypt key derivation function
  
 -LICENSE=	BSD
 +LICENSE=	BSD2CLAUSE
  
 -NO_STAGE=	yes
 +USES=		compiler
  USE_LDCONFIG=	yes
  USE_GITHUB=	yes
  GH_ACCOUNT=	technion
 -GH_COMMIT=	8e6966e
  GH_TAGNAME=	${GH_COMMIT}
 +GH_COMMIT=	8e6966e
  
  PLIST_FILES=	include/libscrypt.h \
  		lib/libscrypt.a \
  		lib/libscrypt.so \
  		lib/libscrypt.so.0
  
 -.include <bsd.port.pre.mk>
 +PORTDOCS=	README.md
 +
 +OPTIONS_DEFINE=	DOCS
  
  post-patch:
 -	@${REINPLACE_CMD} -e '/^CC=gcc/d' -e '/CFLAGS=/s,$$, ${CFLAGS},' \
 -		-e 's,/usr/local,${PREFIX},' -e 's,install: library,& install-static,' \
 -		-e 's,$$(LDFLAGS),,' ${WRKSRC}/Makefile
 +	@${REINPLACE_CMD} -e '/^CC=gcc/d' -e '/CFLAGS=/s|$$| ${CFLAGS}|' \
 +		-e 's|/usr/local|${PREFIX}| ; \
 +		s|install: library|& install-static| ; \
 +		s|$$(LDFLAGS)||' ${WRKSRC}/Makefile
  
  regression-test: build
  	(cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} check)
  
 -.if ${ARCH} == i386
 -CCVERSION!= ${CC} --version
 -.if !empty(CCVERSION:tl:M*gcc*)
 -CFLAGS+=    -fno-stack-protector
 -.endif
 +post-install:
 +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 +
 +.include <bsd.port.pre.mk>
 +
 +.if ${ARCH} == i386 && ${COMPILER_TYPE} == gcc
 +CFLAGS+=	-fno-stack-protector
  .endif
  
  .include <bsd.port.post.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
