From amdmi3@amdmi3.ru  Thu Nov 28 04:36:47 2013
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 3B1FCE7;
	Thu, 28 Nov 2013 04:36:47 +0000 (UTC)
Received: from smtpout1.timeweb.ru (smtpout1.timeweb.ru [92.53.117.15])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id E80D412B8;
	Thu, 28 Nov 2013 04:36:46 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.76)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1VltLH-0000Fa-Cc; Thu, 28 Nov 2013 08:36:43 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 08E131C3A;
	Thu, 28 Nov 2013 08:36:43 +0400 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id F2215429; Thu, 28 Nov 2013 08:36:42 +0400 (MSK)
Message-Id: <20131128043642.F2215429@hades.panopticon>
Date: Thu, 28 Nov 2013 08:36:42 +0400 (MSK)
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: joemann@beefree.free.de, tota@FreeBSD.org, mat@FreeBSD.org
Subject: [PATCH] ports-mgmt/porttools: incorrect svn detection
X-Send-Pr-Version: 3.113
X-GNATS-Notify: joemann@beefree.free.de

>Number:         184346
>Category:       ports
>Synopsis:       [PATCH] ports-mgmt/porttools: incorrect svn detection
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 28 04:40:01 UTC 2013
>Closed-Date:    Sat Feb 15 08:23:37 UTC 2014
>Last-Modified:  Sat Feb 15 08:23:37 UTC 2014
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 10.0-BETA3 amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 10.0-BETA3 FreeBSD 10.0-BETA3 #0 r258666: Wed Nov 27 03:06:10 MSK
>Description:

Porttools check for .svn subdirectory in the port's dir to check
whether SVN diff method should be used. With newer svn versions
(1.7, 1.8) this check will fail, as there's only single .svn directory
in the working directory root but not in the subdirectories. Probably
`svn info` output should be checked instead.

With this bug, `port submit` produces patches with simple diff which
contain RCS id changes ($FreeBSD$) - with these, patch usually does
not apply making life harder for committers, so this should be fixed
pretty much as soon as possible.

It'd also be useful to add --ignore-properties to svn diff here.

Port maintainer (joemann@beefree.free.de) is cc'd.

Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: SVN)
>How-To-Repeat:
>Fix:

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Nov 28 04:40:08 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=184346 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: joemann@beefree.free.de
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/184346: [PATCH] ports-mgmt/porttools: incorrect svn detection
Date: Thu, 28 Nov 2013 04:40:07 UT

 Maintainer of ports-mgmt/porttools,
 
 Please note that PR ports/184346 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184346
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: koobs 
State-Changed-When: Sat Feb 15 08:23:35 UTC 2014 
State-Changed-Why:  
Superceded by ports/186372 

http://www.freebsd.org/cgi/query-pr.cgi?pr=184346 
>Unformatted:
