From rodrigo@bebik.net  Wed Nov 27 12:40:20 2013
Return-Path: <rodrigo@bebik.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id D36CF26A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Nov 2013 12:40:20 +0000 (UTC)
Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [IPv6:2a01:e0c:1:1599::10])
	by mx1.freebsd.org (Postfix) with ESMTP id 6A9402D4C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Nov 2013 12:40:18 +0000 (UTC)
Received: from oldfaithful.bebik.local (unknown [82.227.164.69])
	by smtp1-g21.free.fr (Postfix) with ESMTP id 3678B94020E
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Nov 2013 13:40:12 +0100 (CET)
Received: by oldfaithful.bebik.local (Postfix, from userid 1001)
	id 7CB83890440; Wed, 27 Nov 2013 13:32:31 +0100 (CET)
Message-Id: <20131127123231.7CB83890440@oldfaithful.bebik.local>
Date: Wed, 27 Nov 2013 13:32:31 +0100 (CET)
From: Rodrigo Osorio <rodrigo@bebik.net>
Reply-To: Rodrigo Osorio <rodrigo@bebik.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: net/tcpdump and net/libpcap port upgrade 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         184325
>Category:       ports
>Synopsis:       net/tcpdump and net/libpcap port upgrade
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 27 12:50:00 UTC 2013
>Closed-Date:    Sun Dec 29 20:47:04 UTC 2013
>Last-Modified:  Sun Dec 29 20:50:00 UTC 2013
>Originator:     Rodrigo (ros) OSORIO
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD sisko 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:
 	Update tcpdump from 4.4.0 to 4.5.1
	Update libpcap from 1.4.0 to 1.5.1

	Latest tcpdump releases commes with an new switch
	(-P) to filter the direction of the capture performed by
	tcpdump : in/out/inout.
	This feature is required at work for our testbed.

	The tcpdump compiles and works without error or warning after upgrade.

	I also remove NO_STAGE flag and fix install path, tcpdump and libpcat are stage ready !
	  	
	
>How-To-Repeat:
	
>Fix:

	



--- tcpdump-4.5.1.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 334952)
+++ Makefile	(working copy)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	tcpdump
-PORTVERSION=	4.4.0
+PORTVERSION=	4.5.1
 CATEGORIES=	net ipv6
 MASTER_SITES=	http://www.tcpdump.org/release/
 
@@ -29,12 +29,13 @@
 USER_DESC=	Drop privileges to nobody
 CHROOT_DESC=	Chroot to /var/run/tcpdump (set CHROOTDIR to change)
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 # The --without-crypto flag needs to be explicitly specified. The
 # configure script gets confused if you specify --with-crypto and
 # thinks this means you *don't* want crypto.
 #
+
+CONFIGURE_ARGS+=	--enable-pcap_setdirection --with-pcap_setdirection
 .if ${PORT_OPTIONS:MCRYPTO}
 USE_OPENSSL=	yes
 .else
@@ -72,7 +73,7 @@
 	@${REINPLACE_CMD} -e "s,\./\.\./${LIBPCAP_FORCE_VER}/libpcap\.a,${LOCALBASE}/lib/libpcap.so.1," ${WRKSRC}/Makefile
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/tcpdump ${PREFIX}/sbin
-	${INSTALL_MAN} ${WRKSRC}/tcpdump.1 ${MAN1PREFIX}/man/man1
+	${INSTALL_PROGRAM} ${WRKSRC}/tcpdump ${STAGEDIR}${PREFIX}/sbin
+	${INSTALL_MAN} ${WRKSRC}/tcpdump.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
 
 .include <bsd.port.post.mk>
Index: distinfo
===================================================================
--- distinfo	(revision 334952)
+++ distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (tcpdump-4.4.0.tar.gz) = 12274bed2cb89098dadf00a022b4d40853c5108369f3b3117aedf21ec61530bd
-SIZE (tcpdump-4.4.0.tar.gz) = 915381
+SHA256 (tcpdump-4.5.1.tar.gz) = 14ab39657128f3a650aed4cf455f76c7590601087b6101c253d698f6e73f0b96
+SIZE (tcpdump-4.5.1.tar.gz) = 1024455
--- tcpdump-4.5.1.patch ends here ---

--- libpcap-1.5.1.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 334952)
+++ Makefile	(working copy)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	libpcap
-PORTVERSION=	1.4.0
+PORTVERSION=	1.5.1
 CATEGORIES=	net ipv6
 MASTER_SITES=	http://www.tcpdump.org/release/
 
@@ -114,7 +114,7 @@
 
 OPTIONS_DEFAULT=	IPV6
 
-NO_STAGE=	yes
+#NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MIPV6}
Index: distinfo
===================================================================
--- distinfo	(revision 334952)
+++ distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (libpcap-1.4.0.tar.gz) = 7c6a2a4f71e8ab09804e6b4fb3aff998c5583108ac42c0e2967eee8e1dbc7406
-SIZE (libpcap-1.4.0.tar.gz) = 619045
+SHA256 (libpcap-1.5.1.tar.gz) = 259db4fe1e9f0b6b9c43a057ec5916dec7d0a821b00d6d6c4dff7db2445fa7e4
+SIZE (libpcap-1.5.1.tar.gz) = 640233
Index: files/patch-Makefile.in
===================================================================
--- files/patch-Makefile.in	(revision 334952)
+++ files/patch-Makefile.in	(working copy)
@@ -1,6 +1,6 @@
---- ./Makefile.in.orig	2012-01-07 23:10:56.713381055 -0500
-+++ ./Makefile.in	2012-01-07 23:10:38.819379443 -0500
-@@ -548,52 +548,19 @@
+--- Makefile.in.orig
++++ Makefile.in
+@@ -564,49 +564,19 @@
  		    $(DESTDIR)$(includedir)/$$i; done
  	[ -d $(DESTDIR)$(bindir) ] || \
  	    (mkdir -p $(DESTDIR)$(bindir); chmod 755 $(DESTDIR)$(bindir))
@@ -19,42 +19,39 @@
 +		j=$$(echo $$i | sed -e 's/3pcap/3/') ; \
  		$(INSTALL_DATA) $$i \
 -		    $(DESTDIR)$(mandir)/man3/$$i; done
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_datalink_val_to_description.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_datalink_val_to_name.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_datalink_val_to_description.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_dump_fopen.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_dump_open.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_dump_fopen.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_freealldevs.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_findalldevs.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_freealldevs.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_perror.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_geterr.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_perror.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_sendpacket.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_inject.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_sendpacket.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_free_datalinks.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_list_datalinks.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_free_datalinks.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_free_tstamp_types.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_list_tstamp_types.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_free_tstamp_types.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_dispatch.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_loop.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_dispatch.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_minor_version.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_major_version.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_minor_version.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_next.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_next_ex.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_next.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_fopen_offline.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_open_offline.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_fopen_offline.3pcap
--	rm -f $(DESTDIR)$(mandir)/man3/pcap_getnonblock.3pcap
--	ln $(DESTDIR)$(mandir)/man3/pcap_setnonblock.3pcap \
--		 $(DESTDIR)$(mandir)/man3/pcap_getnonblock.3pcap
+-	(cd $(DESTDIR)$(mandir)/man3 && \
+-	rm -f pcap_datalink_val_to_description.3pcap && \
+-	$(LN_S) pcap_datalink_val_to_name.3pcap \
+-		 pcap_datalink_val_to_description.3pcap && \
+-	rm -f pcap_dump_fopen.3pcap && \
+-	$(LN_S) pcap_dump_open.3pcap pcap_dump_fopen.3pcap && \
+-	rm -f pcap_freealldevs.3pcap && \
+-	$(LN_S) pcap_findalldevs.3pcap pcap_freealldevs.3pcap && \
+-	rm -f pcap_perror.3pcap && \
+-	$(LN_S) pcap_geterr.3pcap pcap_perror.3pcap && \
+-	rm -f pcap_sendpacket.3pcap && \
+-	$(LN_S) pcap_inject.3pcap pcap_sendpacket.3pcap && \
+-	rm -f pcap_free_datalinks.3pcap && \
+-	$(LN_S) pcap_list_datalinks.3pcap pcap_free_datalinks.3pcap && \
+-	rm -f pcap_free_tstamp_types.3pcap && \
+-	$(LN_S) pcap_list_tstamp_types.3pcap pcap_free_tstamp_types.3pcap && \
+-	rm -f pcap_dispatch.3pcap && \
+-	$(LN_S) pcap_loop.3pcap pcap_dispatch.3pcap && \
+-	rm -f pcap_minor_version.3pcap && \
+-	$(LN_S) pcap_major_version.3pcap pcap_minor_version.3pcap && \
+-	rm -f pcap_next.3pcap && \
+-	$(LN_S) pcap_next_ex.3pcap pcap_next.3pcap && \
+-	rm -f pcap_open_dead_with_tstamp_precision.3pcap && \
+-	$(LN_S) pcap_open_dead.3pcap \
+-		 pcap_open_dead_with_tstamp_precision.3pcap && \
+-	rm -f pcap_open_offline_with_tstamp_precision.3pcap && \
+-	$(LN_S) pcap_open_offline.3pcap pcap_open_offline_with_tstamp_precision.3pcap && \
+-	rm -f pcap_fopen_offline.3pcap && \
+-	$(LN_S) pcap_open_offline.3pcap pcap_fopen_offline.3pcap && \
+-	rm -f pcap_fopen_offline_with_tstamp_precision.3pcap && \
+-	$(LN_S) pcap_open_offline.3pcap pcap_fopen_offline_with_tstamp_precision.3pcap && \
+-	rm -f pcap_getnonblock.3pcap && \
+-	$(LN_S) pcap_setnonblock.3pcap pcap_getnonblock.3pcap)
 +		    $(DESTDIR)$(mandir)/man3/$$j; done
  	for i in $(MANFILE); do \
  		$(INSTALL_DATA) `echo $$i | sed 's/.manfile.in/.manfile/'` \
--- libpcap-1.5.1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Nov 27 12:50:09 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=184325 

From: Rodrigo Osorio <rodrigo@bebik.net>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/184325: net/tcpdump and net/libpcap port upgrade
Date: Wed, 27 Nov 2013 14:01:10 +0100

 Oups! I comment but forgot to remove NO_STAGE in libpcap.
 
State-Changed-From-To: open->closed 
State-Changed-By: wxs 
State-Changed-When: Sun Dec 29 20:47:03 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=184325 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/184325: commit references a PR
Date: Sun, 29 Dec 2013 20:44:28 +0000 (UTC)

 Author: wxs
 Date: Sun Dec 29 20:44:20 2013
 New Revision: 338042
 URL: http://svnweb.freebsd.org/changeset/ports/338042
 
 Log:
   Make stage aware and turn on pcap_setdirection.
   
   PR:		ports/184325
   Submitted by:	Rodrigo Osorio <rodrigo@bebik.net>
 
 Modified:
   head/net/tcpdump/Makefile
 
 Modified: head/net/tcpdump/Makefile
 ==============================================================================
 --- head/net/tcpdump/Makefile	Sun Dec 29 20:37:27 2013	(r338041)
 +++ head/net/tcpdump/Makefile	Sun Dec 29 20:44:20 2013	(r338042)
 @@ -29,8 +29,10 @@ SMI_DESC=	Allow MIBs to be loaded on the
  USER_DESC=	Drop privileges to nobody
  CHROOT_DESC=	Chroot to /var/run/tcpdump (set CHROOTDIR to change)
  
 -NO_STAGE=	yes
  .include <bsd.port.options.mk>
 +
 +CONFIGURE_ARGS+=	--enable-pcap_setdirection --with-pcap_setdirection
 +
  # The --without-crypto flag needs to be explicitly specified. The
  # configure script gets confused if you specify --with-crypto and
  # thinks this means you *don't* want crypto.
 @@ -65,14 +67,14 @@ CONFIGURE_ARGS+=	--with-chroot=${CHROOTD
  
  .include <bsd.port.pre.mk>
  
 -MAN1=		tcpdump.1
 -PLIST_FILES=	sbin/tcpdump
 +PLIST_FILES=	sbin/tcpdump \
 +		man/man1/tcpdump.1.gz
  
  post-configure:
  	@${REINPLACE_CMD} -e "s,\./\.\./${LIBPCAP_FORCE_VER}/libpcap\.a,${LOCALBASE}/lib/libpcap.so.1," ${WRKSRC}/Makefile
  
  do-install:
 -	${INSTALL_PROGRAM} ${WRKSRC}/tcpdump ${PREFIX}/sbin
 -	${INSTALL_MAN} ${WRKSRC}/tcpdump.1 ${MAN1PREFIX}/man/man1
 +	${INSTALL_PROGRAM} ${WRKSRC}/tcpdump ${STAGEDIR}/${PREFIX}/sbin
 +	${INSTALL_MAN} ${WRKSRC}/tcpdump.1 ${STAGEDIR}/${MAN1PREFIX}/man/man1
  
  .include <bsd.port.post.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
