From nobody@FreeBSD.org  Wed Nov 13 19:16:47 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 6808ADED
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Nov 2013 19:16:47 +0000 (UTC)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 56A5B291B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Nov 2013 19:16:47 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rADJGk8v094000
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Nov 2013 19:16:46 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rADJGkZi093996;
	Wed, 13 Nov 2013 19:16:46 GMT
	(envelope-from nobody)
Message-Id: <201311131916.rADJGkZi093996@oldred.freebsd.org>
Date: Wed, 13 Nov 2013 19:16:46 GMT
From: Matthieu Volat <mazhe@alkumuna.eu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] net-p2p/transmission-qt4 and freebsd 10.0 (libc++)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         183935
>Category:       ports
>Synopsis:       [patch] net-p2p/transmission-qt4 and freebsd 10.0 (libc++)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 13 19:20:00 UTC 2013
>Closed-Date:    Wed Nov 13 19:46:53 UTC 2013
>Last-Modified:  Wed Nov 13 19:50:01 UTC 2013
>Originator:     Matthieu Volat
>Release:        10.0-BETA3
>Organization:
>Environment:
FreeBSD justice.alkumuna.eu 10.0-BETA3 FreeBSD 10.0-BETA3 #0 r257580: Sun Nov  3 19:43:01 UTC 2013     root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Here's a minor problem building transmission-qt4 on FreeBSD 10.0 with the new libc++ library:

c++ -c -O2 -pipe -fno-strict-aliasing -g -pthread -D_THREAD_SAFE -Wall -W -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/local/share/qt4/mkspecs/freebsd-clang -I. -I/usr/local/include/qt4/QtCore -I/usr/local/include/qt4/QtNetwork -I/usr/local/include/qt4/QtGui -I/usr/local/include/qt4/QtDBus -I/usr/local/include/qt4 -I/include -I.. -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/event2/compat -I. -I. -I/usr/local/include/qt4 -I/usr/local/include -o app.o app.cc
In file included from app.cc:34:
./app.h:40:10: warning: 'MyApp::notify' hides overloaded virtual function [-Woverloaded-virtual]
    bool notify (const QString& title, const QString& body) const;
         ^
/usr/local/include/qt4/QtGui/qapplication.h:289:10: note: hidden overloaded virtual function 'QApplication::notify' declared here: type mismatch at 1st
      parameter ('QObject *' vs 'const QString &')
    bool notify(QObject *, QEvent *);
         ^
1 warning generated.
c++ -c -O2 -pipe -fno-strict-aliasing -g -pthread -D_THREAD_SAFE -Wall -W -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/local/share/qt4/mkspecs/freebsd-clang -I. -I/usr/local/include/qt4/QtCore -I/usr/local/include/qt4/QtNetwork -I/usr/local/include/qt4/QtGui -I/usr/local/include/qt4/QtDBus -I/usr/local/include/qt4 -I/include -I.. -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/event2/compat -I. -I. -I/usr/local/include/qt4 -I/usr/local/include -o dbus-adaptor.o dbus-adaptor.cc
In file included from dbus-adaptor.cc:14:
./app.h:54:5: error: unknown type name 'time_t'
    time_t myLastFullUpdateTime;
    ^
./app.h:40:10: warning: 'MyApp::notify' hides overloaded virtual function [-Woverloaded-virtual]
    bool notify (const QString& title, const QString& body) const;
         ^
/usr/local/include/qt4/QtGui/qapplication.h:289:10: note: hidden overloaded virtual function 'QApplication::notify' declared here: type mismatch at 1st
      parameter ('QObject *' vs 'const QString &')
    bool notify(QObject *, QEvent *);
         ^
dbus-adaptor.cc:18:5: error: no matching constructor for initialization of 'QDBusAbstractAdaptor'
    QDBusAbstractAdaptor( app ),
    ^                     ~~~
/usr/local/include/qt4/QtDBus/qdbusabstractadaptor.h:57:21: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from
      'MyApp *' to 'const QDBusAbstractAdaptor' for 1st argument
class Q_DBUS_EXPORT QDBusAbstractAdaptor: public QObject
                    ^
/usr/local/include/qt4/QtDBus/qdbusabstractadaptor.h:61:5: note: candidate constructor not viable: no known conversion from 'MyApp *' to 'QObject *' for 1st
      argument
    QDBusAbstractAdaptor(QObject *parent);
    ^
1 warning and 2 errors generated.
gmake[2]: *** [dbus-adaptor.o] Error 1
gmake[2]: Leaving directory `/usr/ports/net-p2p/transmission-qt4/work/transmission-2.82/qt'
*** Error code 2

Stop.
>How-To-Repeat:
On a 10.0-BETA3 system, try to build net-p2p/transmission-qt4
>Fix:
Simply including <ctime> in qt/app.h solves the problem (patch enclosed).

If paranoid, the patch should be applied depending on the version of the host system, but I think that it is overkill seeing its simplicity :)

Patch attached with submission follows:

--- qt/app.h.orig	2013-11-13 20:00:41.000000000 +0100
+++ qt/app.h	2013-11-13 20:00:51.000000000 +0100
@@ -13,6 +13,7 @@
 #ifndef QTR_APP_H
 #define QTR_APP_H
 
+#include <ctime>
 #include <QApplication>
 #include <QSet>
 #include <QTimer>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Nov 13 19:20:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183935 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Wed Nov 13 19:46:52 UTC 2013 
State-Changed-Why:  
Thanks a lot, I hadn't had time to figure that one out.  Appreciated :) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183935 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/183935: commit references a PR
Date: Wed, 13 Nov 2013 19:46:04 +0000 (UTC)

 Author: crees
 Date: Wed Nov 13 19:45:57 2013
 New Revision: 333720
 URL: http://svnweb.freebsd.org/changeset/ports/333720
 
 Log:
   Fix -qt4 build on 10.0-BETA3
   
   PR:		ports/183935
   Submitted by:	Matthieu Volat <mazhe@alkumuna.eu>
 
 Added:
   head/net-p2p/transmission-cli/files/patch-qt-app-h   (contents, props changed)
 Modified:
   head/net-p2p/transmission-cli/Makefile
 
 Modified: head/net-p2p/transmission-cli/Makefile
 ==============================================================================
 --- head/net-p2p/transmission-cli/Makefile	Wed Nov 13 19:40:51 2013	(r333719)
 +++ head/net-p2p/transmission-cli/Makefile	Wed Nov 13 19:45:57 2013	(r333720)
 @@ -32,8 +32,8 @@ NO_STAGE=	yes
  LIB_DEPENDS?=	${GEN_LIB_DEPENDS}
  
  # General dependencies
 -GEN_LIB_DEPENDS=curl:${PORTSDIR}/ftp/curl \
 -		event-2.0.6:${PORTSDIR}/devel/libevent2
 +GEN_LIB_DEPENDS=libcurl.so:${PORTSDIR}/ftp/curl \
 +		libevent-2.0.so.6:${PORTSDIR}/devel/libevent2
  GEN_RUN_DEPENDS=${LOCALBASE}/share/transmission/web/index.html:${PORTSDIR}/www/transmission-web
  
  # This is master port of transmission-*, so don't override USES definition 
 
 Added: head/net-p2p/transmission-cli/files/patch-qt-app-h
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/net-p2p/transmission-cli/files/patch-qt-app-h	Wed Nov 13 19:45:57 2013	(r333720)
 @@ -0,0 +1,10 @@
 +--- qt/app.h.orig	2013-11-13 20:00:41.000000000 +0100
 ++++ qt/app.h	2013-11-13 20:00:51.000000000 +0100
 +@@ -13,6 +13,7 @@
 + #ifndef QTR_APP_H
 + #define QTR_APP_H
 + 
 ++#include <ctime>
 + #include <QApplication>
 + #include <QSet>
 + #include <QTimer>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
