From mat@aragorn.in.absolight.net  Tue Nov 12 14:15:36 2013
Return-Path: <mat@aragorn.in.absolight.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 29E14AA
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Nov 2013 14:15:36 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25])
	(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id CF1A12F6D
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Nov 2013 14:15:35 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
	by prod2.absolight.net (Postfix) with ESMTP id 74DADBDC70
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Nov 2013 15:15:33 +0100 (CET)
Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified))
	by prod2.absolight.net (Postfix) with ESMTPSA id 4E1DFBDC6B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Nov 2013 15:15:33 +0100 (CET)
Received: from aragorn.in.absolight.net (aragorn.in.absolight.net [79.143.241.225])
	by gw.in.absolight.net (Postfix) with ESMTP id 500C16122
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Nov 2013 15:15:32 +0100 (CET)
Received: by aragorn.in.absolight.net (Postfix, from userid 1000)
	id 4DDFB14269C; Tue, 12 Nov 2013 15:15:31 +0100 (CET)
Message-Id: <20131112141531.4DDFB14269C@aragorn.in.absolight.net>
Date: Tue, 12 Nov 2013 15:15:31 +0100 (CET)
From: Mathieu Arnold <mat@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] www/squid: Fixup build with ECAP.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         183894
>Category:       ports
>Synopsis:       [PATCH] www/squid: Fixup build with ECAP.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tmseck
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 12 14:20:00 UTC 2013
>Closed-Date:    Tue Nov 26 14:57:15 UTC 2013
>Last-Modified:  Tue Nov 26 15:00:01 UTC 2013
>Originator:     Mathieu Arnold
>Release:        FreeBSD 9.2-RELEASE i386
>Organization:
Absolight
>Environment:
System: FreeBSD aragorn.in.absolight.net 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Fri Sep 27 03:52:52 UTC
>Description:
Fixup build with ECAP.

USES can't be fiddled with after bsd.port.pre.mk.

www/squid32 has the same problem.

Generated with FreeBSD Port Tools 0.99_9 (mode: change, diff: SVN)
>How-To-Repeat:
>Fix:

--- squid-3.3.10.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 333573)
+++ Makefile	(working copy)
@@ -107,6 +107,8 @@
 OPTIONS_DEFAULT=	AUTH_KERB AUTH_NIS FS_AUFS HTCP IDENT KQUEUE \
 			SNMP WCCP WCCPV2
 
+ECAP_USES=		pkgconfig:build
+
 etc_files=	squid/cachemgr.conf.default \
 		squid/errorpage.css.default \
 		squid/mib.txt \
@@ -433,7 +435,6 @@
 LIB_DEPENDS+=	ecap:${PORTSDIR}/www/libecap
 CFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
-USES+=		pkgconfig:build
 .else
 CONFIGURE_ARGS+=	--disable-ecap
 .endif
--- squid-3.3.10.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->tmseck 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Nov 12 14:20:07 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183894 
State-Changed-From-To: open->closed 
State-Changed-By: mat 
State-Changed-When: Tue Nov 26 14:57:14 UTC 2013 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183894 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/183894: commit references a PR
Date: Tue, 26 Nov 2013 14:57:52 +0000 (UTC)

 Author: mat
 Date: Tue Nov 26 14:57:45 2013
 New Revision: 334940
 URL: http://svnweb.freebsd.org/changeset/ports/334940
 
 Log:
   Fix build with ECAP.
   
   USES can't be fiddled with after including bsd.port.pre.mk.
   
   maintainer timeout
   
   PR:		ports/183894
   Submitted by:	mat
 
 Modified:
   head/www/squid32/Makefile
   head/www/squid33/Makefile
 
 Modified: head/www/squid32/Makefile
 ==============================================================================
 --- head/www/squid32/Makefile	Tue Nov 26 14:57:00 2013	(r334939)
 +++ head/www/squid32/Makefile	Tue Nov 26 14:57:45 2013	(r334940)
 @@ -101,6 +101,8 @@ WCCP_DESC=	Enable Web Cache Coordination
  OPTIONS_DEFAULT=	AUTH_KERB AUTH_NIS FS_AUFS HTCP IDENT KQUEUE \
  			SNMP WCCP WCCPV2
  
 +ECAP_USES=		pkgconfig:build
 +
  etc_files=	squid/cachemgr.conf.default \
  		squid/errorpage.css.default \
  		squid/mib.txt \
 @@ -423,7 +425,6 @@ CONFIGURE_ARGS+=	--enable-ecap
  LIB_DEPENDS+=	ecap:${PORTSDIR}/www/libecap
  CFLAGS+=	-I${LOCALBASE}/include
  LDFLAGS+=	-L${LOCALBASE}/lib
 -USES+=		pkgconfig:build
  .else
  CONFIGURE_ARGS+=	--disable-ecap
  .endif
 
 Modified: head/www/squid33/Makefile
 ==============================================================================
 --- head/www/squid33/Makefile	Tue Nov 26 14:57:00 2013	(r334939)
 +++ head/www/squid33/Makefile	Tue Nov 26 14:57:45 2013	(r334940)
 @@ -107,6 +107,8 @@ WCCP_DESC=	Enable Web Cache Coordination
  OPTIONS_DEFAULT=	AUTH_KERB AUTH_NIS FS_AUFS HTCP IDENT KQUEUE \
  			SNMP WCCP WCCPV2
  
 +ECAP_USES=		pkgconfig:build
 +
  etc_files=	squid/cachemgr.conf.default \
  		squid/errorpage.css.default \
  		squid/mib.txt \
 @@ -433,7 +435,6 @@ CONFIGURE_ARGS+=	--enable-ecap
  LIB_DEPENDS+=	ecap:${PORTSDIR}/www/libecap
  CFLAGS+=	-I${LOCALBASE}/include
  LDFLAGS+=	-L${LOCALBASE}/lib
 -USES+=		pkgconfig:build
  .else
  CONFIGURE_ARGS+=	--disable-ecap
  .endif
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
