From nobody@FreeBSD.org  Sat Nov  2 09:12:46 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id DD495FA4
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Nov 2013 09:12:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id BC5EA2A4E
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Nov 2013 09:12:45 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rA29Cj6N079518
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 2 Nov 2013 09:12:45 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rA29CjWg079511;
	Sat, 2 Nov 2013 09:12:45 GMT
	(envelope-from nobody)
Message-Id: <201311020912.rA29CjWg079511@oldred.freebsd.org>
Date: Sat, 2 Nov 2013 09:12:45 GMT
From: Peter Wullinger <peter.wullinger+freebsd@googlemail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] vlc 2.1.0 port requires pulse, works fine with oss, too
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         183586
>Category:       ports
>Synopsis:       [patch] multimedia/vlc 2.1.0 port requires pulse, works fine with oss, too
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 02 09:20:03 UTC 2013
>Closed-Date:    Sat Nov 02 12:13:01 UTC 2013
>Last-Modified:  Sat Nov 02 16:55:25 UTC 2013
>Originator:     Peter Wullinger
>Release:        9.2-STABLE
>Organization:
>Environment:
FreeBSD kaliope.home 9.2-STABLE FreeBSD 9.2-STABLE #34 r255964M: Tue Oct  1 12:12:55 CEST 2013     src@kaliope.home:/usr/obj/usr/src/sys/KALIOPE_MONO  amd64

>Description:
Since the update to 2.1.0 The multimedia/vlc port now requires pulseaudio.

The relevant commit states

- Disable OSS (it is broken in vlc 2.1.0 and FreeBSD #9760)

This may as well be true, but the port still works perfectly
on older versions of FreeBSD.

I'd suggest either making this change dependent on the installed
FreeBSD version or making pulseaudio the default with OSS still
being an option (even though I do not like that option either).
>How-To-Repeat:
Install port multimedia/vlc

# cd /usr/ports/multimedia/vlc
# make install
>Fix:
Apply the attached patch and rebuild multimedia/vlc

# cd /usr/ports/multimedia/vlc
# make && make deinstall reinstall


Patch attached with submission follows:

--- Makefile.orig	2013-11-01 08:03:19.101369627 +0100
+++ Makefile	2013-11-01 08:27:54.321389004 +0100
@@ -17,8 +17,7 @@
 
 LIB_DEPENDS=	libgcrypt.so:${PORTSDIR}/security/libgcrypt \
 		libproxy.so:${PORTSDIR}/net/libproxy \
-		libdvbpsi.so:${PORTSDIR}/multimedia/libdvbpsi \
-		libpulse.so:${PORTSDIR}/audio/pulseaudio
+		libdvbpsi.so:${PORTSDIR}/multimedia/libdvbpsi
 BUILD_DEPENDS=	ffmpeg>=2.0:${PORTSDIR}/multimedia/ffmpeg
 RUN_DEPENDS=	ffmpeg>=2.0:${PORTSDIR}/multimedia/ffmpeg
 
@@ -30,7 +29,8 @@
 		SAMBA SCHROED SDL SHOUTCAST SKINS STREAM SPEEX SVG \
 		TAGLIB THEORA TWOLAME UPNP V4L VAAPI VCD VORBIS \
 		X11 X264 ZVBI SERVER_ONLY DEBUG \
-		GME NO_DVD LIBBLURAY SAMPLERATE SIDPLAY
+		GME NO_DVD LIBBLURAY SAMPLERATE SIDPLAY \
+		PULSE
 OPTIONS_DEFAULT=A52 AVAHI DBUS DTS DVDREAD DVDNAV FAAD FLAC GNUTLS \
 		HTTPD LUA MAD MATROSKA MPEG2 OGG OPUS PNG QT4 REALAUDIO \
 		SDL SKINS STREAM SPEEX TAGLIB THEORA TWOLAME V4L \
@@ -59,6 +59,7 @@
 ZVBI_DESC=	VBI decoding support
 SERVER_ONLY_DESC=	Only build server parts
 NO_DVD_DESC=	disable DVD specific features
+PULSE_DESC=	use pulseaudio
 
 QT4_CONFIGURE_ENABLE=	qt
 
@@ -182,8 +183,8 @@
 PNG_LIB_DEPENDS=	libpng15.so:${PORTSDIR}/graphics/png
 PNG_CONFIGURE_ENABLE=	png
 
-#PULSEAUDIO_LIB_DEPENDS=	libpulse.so:${PORTSDIR}/audio/pulseaudio
-#PULSEAUDIO_CONFIGURE_ENABLE=	pulse
+PULSEAUDIO_LIB_DEPENDS=	libpulse.so:${PORTSDIR}/audio/pulseaudio
+PULSEAUDIO_CONFIGURE_ENABLE=	pulse
 
 REALAUDIO_CONFIGURE_ENABLE=	realrtsp
 
@@ -258,17 +259,17 @@
 CONFIGURE_ARGS+=	--enable-vlc \
 			--enable-avcodec \
 			--enable-avformat \
+			--enable-oss \
 			--enable-postproc \
-			--enable-pulse \
 			--enable-sftp \
 			--enable-libgcrypt \
 			--disable-alsa \
 			--disable-dc1394 \
 			--disable-directfb \
-			--disable-oss \
 			--disable-projectm \
 			--disable-telx \
 			--disable-tremor \
+			--disable-libvnc \
 			--disable-udev \
 			--disable-update-check
 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: wg 
State-Changed-When: Sat Nov 2 12:13:01 UTC 2013 
State-Changed-Why:  
It does not works fine with OSS, 
https://trac.videolan.org/vlc/ticket/9760#ticket 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183586 

From: William Grzybowski <william88@gmail.com>
To: Peter Wullinger <peter.wullinger+freebsd@googlemail.com>
Cc: bug-followup@freebsd.org, William Grzybowski <wg@freebsd.org>
Subject: Re: ports/183586: [patch] vlc 2.1.0 port requires pulse, works fine
 with oss, too
Date: Sat, 2 Nov 2013 11:22:33 -0200

 On Sat, Nov 2, 2013 at 11:21 AM, Peter Wullinger
 <peter.wullinger+freebsd@googlemail.com> wrote:
 > I cannot verify that, I have audio playing via oss perfectly
 > just right now.
 >
 > % vlc --version
 > VLC media player 2.1.0 Rincewind (revision 2.1.0-0-gedd8835)
 > VLC-Version 2.1.0 Rincewind (2.1.0-0-gedd8835)
 > % pkg info vlc
 > vlc-2.1.0_3,4
 > % pkg info -x pulse
 > pkg: No package(s) matching pulse
 >
 > vlc -vvvv audiofile.ogg
 > [...]
 > [0x8021b1050] oss audio output debug: using OSS device: /dev/dsp
 > [...]
 >
 > This is with the native FreeBSD audio drivers.
 > Audio plays fine without hickups. I cannot notice any
 > problems.
 
 It works until it doesn't, try playing MP3 file.
 
 
 
 -- 
 William Grzybowski
 ------------------------------------------
 Curitiba/PR - Brasil

From: Peter Wullinger <peter.wullinger+freebsd@googlemail.com>
To: bug-followup@freebsd.org
Cc: wg@freebsd.org
Subject: Re: ports/183586: [patch] vlc 2.1.0 port requires pulse, works fine
 with oss, too
Date: Sat, 2 Nov 2013 14:21:06 +0100

 I cannot verify that, I have audio playing via oss perfectly 
 just right now. 
 
 % vlc --version
 VLC media player 2.1.0 Rincewind (revision 2.1.0-0-gedd8835)
 VLC-Version 2.1.0 Rincewind (2.1.0-0-gedd8835)
 % pkg info vlc   
 vlc-2.1.0_3,4
 % pkg info -x pulse
 pkg: No package(s) matching pulse
 
 vlc -vvvv audiofile.ogg
 [...]
 [0x8021b1050] oss audio output debug: using OSS device: /dev/dsp
 [...]
 
 This is with the native FreeBSD audio drivers.
 Audio plays fine without hickups. I cannot notice any
 problems.

From: William Grzybowski <william88@gmail.com>
To: Peter Wullinger <peter.wullinger+freebsd@googlemail.com>
Cc: William Grzybowski <wg@freebsd.org>, bug-followup@freebsd.org
Subject: Re: ports/183586: [patch] vlc 2.1.0 port requires pulse, works fine
 with oss, too
Date: Sat, 2 Nov 2013 11:46:52 -0200

 On Sat, Nov 2, 2013 at 11:40 AM, Peter Wullinger
 <peter.wullinger+freebsd@googlemail.com> wrote:
 >
 >>
 >> It works until it doesn't, try playing MP3 file.
 >
 > That seems to be repeatable. Playing an .mp3 causes the problem
 > to appear immediately. I also get a lot of warnings
 >
 > TagLib: MPEG::Header::parse() -- Invalid sample rate.
 >
 > which I've never seen before. Still, other audio seems to play just fine.
 > I've been listening to half an hour of .ogg tracks now and there
 > seem to be no issues with that.
 >
 > So it's not that it does not work at all, rather some parameter
 > combinations/plugins seem to work together in a bad way.  My concern
 > simply is, that I would very much prefer not to _enforce_ pulseaudio on
 > anyone if that can be avoided.
 
 I understand, but it won't happen until OSS is completely fixed.
 
 Thanks for under understanding.
 
 
 
 -- 
 William Grzybowski
 ------------------------------------------
 Curitiba/PR - Brasil

From: Peter Wullinger <peter.wullinger+freebsd@googlemail.com>
To: William Grzybowski <wg@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/183586: [patch] vlc 2.1.0 port requires pulse, works fine
 with oss, too
Date: Sat, 2 Nov 2013 14:40:05 +0100

 >=20
 > It works until it doesn't, try playing MP3 file.
 
 That seems to be repeatable. Playing an .mp3 causes the problem
 to appear immediately. I also get a lot of warnings=20
 
 TagLib: MPEG::Header::parse() -- Invalid sample rate.
 
 which I've never seen before. Still, other audio seems to play just fine.
 I've been listening to half an hour of .ogg tracks now and there
 seem to be no issues with that.=20
 
 So it's not that it does not work at all, rather some parameter
 combinations/plugins seem to work together in a bad way.  My concern
 simply is, that I would very much prefer not to _enforce_ pulseaudio on
 anyone if that can be avoided.
 
 > --=20
 > William Grzybowski
 > ------------------------------------------
 > Curitiba/PR - Brasil
 
 --=20
 Wait for a time, exactly under the star. Then, if a little man appears
 who laughs, who has golden hair and who refuses to answer questions, you
 will know who he is. If this should happen, please comfort me.  Send me
 word that he has come back. =20
 	-- Antoine Jean Baptiste Marie Roger de Saint-Exup=E9ry
>Unformatted:
