From nobody@FreeBSD.org  Tue Oct 22 16:39:38 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id C478EBC
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Oct 2013 16:39:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id B117826F3
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Oct 2013 16:39:38 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r9MGdcvG063717
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Oct 2013 16:39:38 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r9MGdcsN063716;
	Tue, 22 Oct 2013 16:39:38 GMT
	(envelope-from nobody)
Message-Id: <201310221639.r9MGdcsN063716@oldred.freebsd.org>
Date: Tue, 22 Oct 2013 16:39:38 GMT
From: Alan Somers <asomers@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] sysutils/mkfile-1.1.1 no longer accepts the default unit suffix
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         183207
>Category:       ports
>Synopsis:       [patch] sysutils/mkfile-1.1.1 no longer accepts the default unit suffix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 22 16:40:00 UTC 2013
>Closed-Date:    Sun Dec 08 05:09:56 UTC 2013
>Last-Modified:  Sun Dec 08 05:09:56 UTC 2013
>Originator:     Alan Somers
>Release:        9.1 and 10.0-Alpha5
>Organization:
>Environment:
# uname -a
FreeBSD alans-fbsd10 10.0-ALPHA5 FreeBSD 10.0-ALPHA5 #1 r256272M: Thu Oct 10 14:48:02 MDT 2013     alans@ns1.eng.sldomain.com:/vmpool/obj/usr/home/alans/freebsd/base/projects/zfsd/head/sys/GENERIC  amd64
>Description:
According to the man page, mkfile(8) will assume that the first argument is in units of bytes unless the user specifies an explicit argument.  The man page matched the behavior of mkfile-1.1.  However, mkfile-1.1.1 no longer accepts an empty unit size suffix.
>How-To-Repeat:
# ./mkfile 100 /tmp/bar
100: Invalid argument
>Fix:
Apply the attached patch to mkfile.c.

Patch attached with submission follows:

--- mkfile.c.orig	2013-06-21 18:19:30.000000000 -0600
+++ mkfile.c	2013-10-22 10:06:39.089650473 -0600
@@ -96,6 +96,9 @@
 	case 'b':	/* Blocks. */
 		sh = 9;
 		break;
+	case '\0':	/* Implicit bytes */
+		sh = 0;
+		break;
 	default:	/* Unknown... */
 		errno = EINVAL;
 		return 0;


>Release-Note:
>Audit-Trail:

From: HATANO Tomomi <hatanou@infolab.ne.jp>
To: bug-followup@FreeBSD.org, asomers@FreeBSD.org
Cc: hatanou@infolab.ne.jp
Subject: Re: ports/183207: [patch] sysutils/mkfile-1.1.1 no longer accepts
 the default unix suffix
Date: Sun, 08 Dec 2013 06:23:26 +0900 (JST)

 This problem was already fixed by ports/183315.
 --
 HATANO Tomomi
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sun Dec 8 05:09:34 UTC 2013 
State-Changed-Why:  
apparently fixed in ports/183315. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183207 
>Unformatted:
