From mat@aragorn.in.absolight.net  Mon Oct 21 16:30:27 2013
Return-Path: <mat@aragorn.in.absolight.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 85463E94;
	Mon, 21 Oct 2013 16:30:27 +0000 (UTC)
	(envelope-from mat@aragorn.in.absolight.net)
Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25])
	(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 49C4D2377;
	Mon, 21 Oct 2013 16:30:26 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
	by prod2.absolight.net (Postfix) with ESMTP id 908B4BDC5E;
	Mon, 21 Oct 2013 18:30:25 +0200 (CEST)
Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified))
	by prod2.absolight.net (Postfix) with ESMTPSA id 68818BDC5D;
	Mon, 21 Oct 2013 18:30:25 +0200 (CEST)
Received: from aragorn.in.absolight.net (aragorn.in.absolight.net [79.143.241.225])
	by gw.in.absolight.net (Postfix) with ESMTP id C4CB960E8;
	Mon, 21 Oct 2013 18:30:19 +0200 (CEST)
Received: by aragorn.in.absolight.net (Postfix, from userid 1000)
	id 2E63914269C; Mon, 21 Oct 2013 18:30:19 +0200 (CEST)
Message-Id: <20131021163019.2E63914269C@aragorn.in.absolight.net>
Date: Mon, 21 Oct 2013 18:30:19 +0200 (CEST)
From: Mathieu Arnold <mat@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: sylvio@FreeBSD.org
Subject: [PATCH] audio/mp3info: Fix WITH=GTK2, Stagify, Use new options.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         183160
>Category:       ports
>Synopsis:       [PATCH] audio/mp3info: Fix WITH=GTK2, Stagify, Use new options.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sylvio
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 21 16:40:00 UTC 2013
>Closed-Date:    Wed Nov 06 12:14:53 UTC 2013
>Last-Modified:  Wed Nov  6 12:20:02 UTC 2013
>Originator:     Mathieu Arnold
>Release:        FreeBSD 9.2-RELEASE i386
>Organization:
Absolight
>Environment:
System: FreeBSD aragorn.in.absolight.net 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Fri Sep 27 03:52:52 UTC
>Description:
- Fix WITH=GTK2
- Stagify
- Use new options framework.

Port maintainer (sylvio@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- mp3info-0.8.5.patch begins here ---
diff -ruN /usr/ports/audio/mp3info/Makefile ./Makefile
--- /usr/ports/audio/mp3info/Makefile	2013-10-04 10:52:32.000000000 +0200
+++ ./Makefile	2013-10-21 18:18:35.000000000 +0200
@@ -19,35 +19,28 @@
 PORTDOCS=	ChangeLog README mp3info.txt
 
 OPTIONS_DEFINE=	GTK2
 GTK2_DESC=	Enable to have the gmp3info
 
-PLIST_FILES=	bin/mp3info \
-		%%WITH_GTK%%bin/gmp3info
+GTK2_USES=		pkgconfig
+GTK2_USE=		GNOME=gtk20
+GTK2_ALL_TARGET=	gmp3info
+GTK2_PLIST_FILES=	bin/gmp3info
 
-MAN1=		mp3info.1
-NO_STAGE=	yes
+PLIST_FILES=	bin/mp3info man/man1/mp3info.1.gz
 
 ALL_TARGET=	doc mp3info
 
 .include <bsd.port.options.mk>
 
+do-install:
+	${INSTALL_PROGRAM} ${WRKSRC}/mp3info ${STAGEDIR}${PREFIX}/bin
+	${INSTALL_MAN} ${WRKSRC}/mp3info.1 ${STAGEDIR}${PREFIX}/man/man1
 .if ${PORT_OPTIONS:MGTK2}
-USE_GNOME+=	gtk20
-ALL_TARGET+=	gmp3info
-MAKE_ARGS=	install-gmp3info
-PLIST_SUB+=	WITH_GTK=""
-.else
-PLIST_SUB+=	WITH_GTK="@comment "
+	${INSTALL_PROGRAM} ${WRKSRC}/gmp3info ${STAGEDIR}${PREFIX}/bin
 .endif
-
-do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/mp3info ${PREFIX}/bin
-	${INSTALL_MAN} ${WRKSRC}/mp3info.1 ${PREFIX}/man/man1
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-.for docs in ${PORTDOCS}
-	${INSTALL_DATA} ${WRKSRC}/${docs} ${DOCSDIR}
-.endfor
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
--- mp3info-0.8.5.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sylvio 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Oct 21 16:40:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183160 
State-Changed-From-To: open->closed 
State-Changed-By: mat 
State-Changed-When: Wed Nov 6 12:14:48 UTC 2013 
State-Changed-Why:  
Committed.


http://www.freebsd.org/cgi/query-pr.cgi?pr=183160 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/183160: commit references a PR
Date: Wed,  6 Nov 2013 12:14:55 +0000 (UTC)

 Author: mat
 Date: Wed Nov  6 12:14:48 2013
 New Revision: 332970
 URL: http://svnweb.freebsd.org/changeset/ports/332970
 
 Log:
   - Fix WITH=GTK2
   - Stagify
   - Use new options framework.
   
   maintainer timeout.
   
   PR:		ports/183160
   Submitted by:	mat
 
 Modified:
   head/audio/mp3info/Makefile
 
 Modified: head/audio/mp3info/Makefile
 ==============================================================================
 --- head/audio/mp3info/Makefile	Wed Nov  6 12:12:45 2013	(r332969)
 +++ head/audio/mp3info/Makefile	Wed Nov  6 12:14:48 2013	(r332970)
 @@ -21,33 +21,26 @@ PORTDOCS=	ChangeLog README mp3info.txt
  OPTIONS_DEFINE=	GTK2
  GTK2_DESC=	Enable to have the gmp3info
  
 -PLIST_FILES=	bin/mp3info \
 -		%%WITH_GTK%%bin/gmp3info
 +GTK2_USES=		pkgconfig
 +GTK2_USE=		GNOME=gtk20
 +GTK2_ALL_TARGET=	gmp3info
 +GTK2_PLIST_FILES=	bin/gmp3info
  
 -MAN1=		mp3info.1
 -NO_STAGE=	yes
 +PLIST_FILES=	bin/mp3info man/man1/mp3info.1.gz
  
  ALL_TARGET=	doc mp3info
  
  .include <bsd.port.options.mk>
  
 +do-install:
 +	${INSTALL_PROGRAM} ${WRKSRC}/mp3info ${STAGEDIR}${PREFIX}/bin
 +	${INSTALL_MAN} ${WRKSRC}/mp3info.1 ${STAGEDIR}${PREFIX}/man/man1
  .if ${PORT_OPTIONS:MGTK2}
 -USE_GNOME+=	gtk20
 -ALL_TARGET+=	gmp3info
 -MAKE_ARGS=	install-gmp3info
 -PLIST_SUB+=	WITH_GTK=""
 -.else
 -PLIST_SUB+=	WITH_GTK="@comment "
 +	${INSTALL_PROGRAM} ${WRKSRC}/gmp3info ${STAGEDIR}${PREFIX}/bin
  .endif
 -
 -do-install:
 -	${INSTALL_PROGRAM} ${WRKSRC}/mp3info ${PREFIX}/bin
 -	${INSTALL_MAN} ${WRKSRC}/mp3info.1 ${PREFIX}/man/man1
 -.if !defined(NOPORTDOCS)
 -	@${MKDIR} ${DOCSDIR}
 -.for docs in ${PORTDOCS}
 -	${INSTALL_DATA} ${WRKSRC}/${docs} ${DOCSDIR}
 -.endfor
 +.if ${PORT_OPTIONS:MDOCS}
 +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 +	cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR}
  .endif
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
