From bdrewery@FreeBSD.org  Sat Oct 12 10:30:21 2013
Return-Path: <bdrewery@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id CDFD557E
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Oct 2013 10:30:21 +0000 (UTC)
	(envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 9DB652619
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Oct 2013 10:30:21 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9CAUL9h084042
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Oct 2013 10:30:21 GMT
	(envelope-from bdrewery@freefall.freebsd.org)
Received: (from bdrewery@localhost)
	by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9CAULve084039
	for FreeBSD-gnats-submit@freebsd.org; Sat, 12 Oct 2013 10:30:21 GMT
	(envelope-from bdrewery)
Received: (qmail 43866 invoked from network); 12 Oct 2013 05:30:19 -0500
Received: from unknown (HELO test8.xzibition.com) (10.10.0.34)
  by sweb.xzibition.com with SMTP; 12 Oct 2013 05:30:19 -0500
Received: by test8.xzibition.com (sSMTP sendmail emulation); Sat, 12 Oct 2013 05:30:17 -0500
Message-Id: <201310121030.r9CAULve084039@freefall.freebsd.org>
Date: Sat, 12 Oct 2013 05:30:17 -0500
From: Bryan Drewery <bdrewery@FreeBSD.org>
Reply-To: Bryan Drewery <bdrewery@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: portmgr@FreeBSD.org
Subject: [PATCH] [ports-mgmt/portlint] port standard updates and maintainership to portmgr
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         182919
>Category:       ports
>Synopsis:       [PATCH] [ports-mgmt/portlint] port standard updates and maintainership to portmgr
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 12 10:40:00 UTC 2013
>Closed-Date:    Sat Oct 12 16:34:29 UTC 2013
>Last-Modified:  Tue Oct 15 04:58:57 UTC 2013
>Originator:     Bryan Drewery
>Release:        FreeBSD 8.3-RELEASE-p5 i386
>Organization:
>Environment:

	
>Description:
	portlint is a critical tool for port development. We have been making a lot of changes lately that
	portlint fails to properly find or recommend. The recent ports/181359 one that recommended
	USES=gmake to use USES=${GMAKE} and USE_GMAKE was especially wrong. We need more people to be able
	to approve or work on getting updates into portlint faster.

	- Support staging
	- Remove indefinite article from COMMENT
	- Pass maintainership to portmgr
>How-To-Repeat:
	
>Fix:

	

--- portlint-updates-portmgr.txt begins here ---

Index: Makefile
===================================================================
--- Makefile	(revision 330124)
+++ Makefile	(working copy)
@@ -7,8 +7,8 @@ CATEGORIES=	ports-mgmt
 MASTER_SITES=	# none
 DISTFILES=	# none
 
-MAINTAINER=	marcus@FreeBSD.org
-COMMENT=	A verifier for FreeBSD port directory
+MAINTAINER=	portmgr@FreeBSD.org
+COMMENT=	Verifier for FreeBSD port directory
 
 NO_BUILD=	yes
 WRKSRC=		${WRKDIR}/src
@@ -17,15 +17,16 @@ USE_PERL5=	run
 
 SRC=		${.CURDIR}/src
 
-MAN1=		portlint.1
-PLIST_FILES=	bin/portlint
+PLIST_FILES=	bin/portlint \
+		man/man1/portlint.1.gz
 
-.if !defined(NOPORTEXAMPLES)
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MEXAMPLES}
 PLIST_FILES+=	%%EXAMPLESDIR%%/portlintgrep
 PLIST_DIRS=	%%EXAMPLESDIR%%
 .endif
 
-NO_STAGE=	yes
 do-fetch:
 	@${DO_NADA}
 
@@ -38,11 +39,15 @@ post-patch:
 		${WRKSRC}/portlintgrep.pl
 
 do-install:
-	${INSTALL_SCRIPT} ${WRKSRC}/portlint.pl ${PREFIX}/bin/portlint
-	${INSTALL_MAN} ${WRKSRC}/portlint.1 ${MAN1PREFIX}/man/man1
-.if !defined(NOPORTEXAMPLES)
-	${INSTALL} -o ${SHAREOWN} -g ${SHAREGRP} -m ${BINMODE} -d ${EXAMPLESDIR}
-	${INSTALL_SCRIPT} ${WRKSRC}/portlintgrep.pl ${EXAMPLESDIR}/portlintgrep
+	${INSTALL_SCRIPT} ${WRKSRC}/portlint.pl \
+	    ${STAGEDIR}${PREFIX}/bin/portlint
+	${INSTALL_MAN} ${WRKSRC}/portlint.1 \
+	    ${STAGEDIR}${MAN1PREFIX}/man/man1
+.if ${PORT_OPTIONS:MEXAMPLES}
+	${INSTALL} -o ${SHAREOWN} -g ${SHAREGRP} -m ${BINMODE} -d \
+	    ${STAGEDIR}${EXAMPLESDIR}
+	${INSTALL_SCRIPT} ${WRKSRC}/portlintgrep.pl \
+	    ${STAGEDIR}${EXAMPLESDIR}/portlintgrep
 .endif
 
 .include <bsd.port.mk>
--- portlint-updates-portmgr.txt ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marcus 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Oct 12 13:26:49 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182919 

Date: Sat, 12 Oct 2013 12:17:35 -0400
From: Joe Marcus Clarke <marcus@marcuscom.com>
To: Bryan Drewery <bdrewery@FreeBSD.org>, FreeBSD-gnats-submit@freebsd.org
Subject: Re: [PATCH] Portlint port standard updates and maintainership to
 portmgr

 > 	- Support staging
 > 	- Remove indefinite article from COMMENT
 > 	- Pass maintainership to portmgr
 
 I have been maintaining portlint for a while now, and I do my best to 
 batch changes to avoid a lot of constant churn.  I would appreciate not 
 being summarily replaced as maintainer.
 
 Joe
 
 -- 
 PGP Key : http://www.marcuscom.com/pgp.asc

Date: Sat, 12 Oct 2013 11:25:41 -0500
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Joe Marcus Clarke <marcus@marcuscom.com>, FreeBSD-gnats-submit@freebsd.org
Subject: Re: [PATCH] Portlint port standard updates and maintainership to
 portmgr

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --2hNFvGpwCRU9RxJ8Nmv7Aho1qMU601vjc
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 > I have been maintaining portlint for a while now, and I do my best to
 > batch changes to avoid a lot of constant churn.  I would appreciate not
 > being summarily replaced as maintainer.
 
 I don't think you understand. In just 2 months now, it has become
 unusable, wrong, and more and more irrelevant. We need to be able to
 update it more frequently. It is not OK to sit on valid patches for
 months at a time just to avoid updating a port that has 0 build time.
 Porters need this tool updated ASAP when we make framework changes.
 
 
 --=20
 Regards,
 Bryan Drewery
 
 
 --2hNFvGpwCRU9RxJ8Nmv7Aho1qMU601vjc
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (MingW32)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQIcBAEBAgAGBQJSWXgGAAoJEG54KsA8mwz5kCMP/0/bSbKHIaIeF5nmyAhUTGD+
 0at8f4TCO+oKAj6Q9h9UMm6guZWIMC0ePeioOqkiO7XtG/uQmBmf4fEBQ96c4Itl
 5/pdDrF5y4Le+Yr3aBdhxMob39E4T8NBGxg2/LjhZItapRkfLcYcunD9LJMqwcFC
 DoLaOfwdIkhao2PYn+5VCc5zgsjPh0Wqeqipm+354xVnZs+1KilNtT5127XkzPdx
 f0oQB+715eQwwLIx/Ewmc6+NhD5xKSji9FpEmnR741jeXCHk4UQ+M+qyBU3TbrQ5
 37z9Y7hPyA42BZb/hyYwbTpWPFDJkEc/Dad4fvakyeJv3uAgbYLOpbLRf2ft5tMH
 Xcu2/M/6y0XGUCbNHJJ5s5l470j06xHseoAAkt4AJvgxJ1g4raC0QQvXTenyuo3G
 pKifhCt4jtqe3RbDBnjDbKdqt3Ne4/PkcNj64f0eWr8ZOmyRsxDOsmAUDHfVU8X7
 gcI6+XU3Nt0dIVA+oMx283gZbpxf4NsjKfd+7vleJKHNw3N+lu/rmtIgVgpnajtj
 U4alM3hd8TV6/pprSuULuQbIwoIBXFfADQFeTFS91h1h2V1WMzVGMcRQKWJyoAUO
 dpv78tF934ycCAkbYHFbSoW/UKnMoXeoW7HNKqgEUkowVndL9snfcALnkz6XjBK1
 K3x8YqCZHQIV93pi4pM7
 =PGHN
 -----END PGP SIGNATURE-----
 
 --2hNFvGpwCRU9RxJ8Nmv7Aho1qMU601vjc--
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Sat Oct 12 16:34:06 UTC 2013 
State-Changed-Why:  
Committed, retaining maintainership.  Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182919 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/182919: commit references a PR
Date: Sat, 12 Oct 2013 16:34:07 +0000 (UTC)

 Author: marcus
 Date: Sat Oct 12 16:33:59 2013
 New Revision: 330137
 URL: http://svnweb.freebsd.org/changeset/ports/330137
 
 Log:
   * Support staging
   * Adjust COMMENT
   
   PR:		182919
   Submitted by:	bdrewery
 
 Modified:
   head/ports-mgmt/portlint/Makefile
 
 Modified: head/ports-mgmt/portlint/Makefile
 ==============================================================================
 --- head/ports-mgmt/portlint/Makefile	Sat Oct 12 16:15:07 2013	(r330136)
 +++ head/ports-mgmt/portlint/Makefile	Sat Oct 12 16:33:59 2013	(r330137)
 @@ -8,7 +8,7 @@ MASTER_SITES=	# none
  DISTFILES=	# none
  
  MAINTAINER=	marcus@FreeBSD.org
 -COMMENT=	A verifier for FreeBSD port directory
 +COMMENT=	Verifier for FreeBSD port directory
  
  NO_BUILD=	yes
  WRKSRC=		${WRKDIR}/src
 @@ -17,15 +17,16 @@ USE_PERL5=	run
  
  SRC=		${.CURDIR}/src
  
 -MAN1=		portlint.1
 -PLIST_FILES=	bin/portlint
 +PLIST_FILES=	bin/portlint \
 +		man/man1/portlint.1.gz
  
 -.if !defined(NOPORTEXAMPLES)
 +.include <bsd.port.options.mk>
 +
 +.if ${PORT_OPTIONS:MEXAMPLES}
  PLIST_FILES+=	%%EXAMPLESDIR%%/portlintgrep
  PLIST_DIRS=	%%EXAMPLESDIR%%
  .endif
  
 -NO_STAGE=	yes
  do-fetch:
  	@${DO_NADA}
  
 @@ -38,11 +39,15 @@ post-patch:
  		${WRKSRC}/portlintgrep.pl
  
  do-install:
 -	${INSTALL_SCRIPT} ${WRKSRC}/portlint.pl ${PREFIX}/bin/portlint
 -	${INSTALL_MAN} ${WRKSRC}/portlint.1 ${MAN1PREFIX}/man/man1
 -.if !defined(NOPORTEXAMPLES)
 -	${INSTALL} -o ${SHAREOWN} -g ${SHAREGRP} -m ${BINMODE} -d ${EXAMPLESDIR}
 -	${INSTALL_SCRIPT} ${WRKSRC}/portlintgrep.pl ${EXAMPLESDIR}/portlintgrep
 +	${INSTALL_SCRIPT} ${WRKSRC}/portlint.pl \
 +	    ${STAGEDIR}${PREFIX}/bin/portlint
 +	${INSTALL_MAN} ${WRKSRC}/portlint.1 \
 +	    ${STAGEDIR}${MAN1PREFIX}/man/man1
 +.if ${PORT_OPTIONS:MEXAMPLES}
 +	${INSTALL} -o ${SHAREOWN} -g ${SHAREGRP} -m ${BINMODE} -d \
 +	    ${STAGEDIR}${EXAMPLESDIR}
 +	${INSTALL_SCRIPT} ${WRKSRC}/portlintgrep.pl \
 +	    ${STAGEDIR}${EXAMPLESDIR}/portlintgrep
  .endif
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
