From nobody@FreeBSD.org  Wed Oct  9 03:19:39 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id E6432B10
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  9 Oct 2013 03:19:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id BB2D92537
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  9 Oct 2013 03:19:39 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r993JdEA053204
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 9 Oct 2013 03:19:39 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r993Jdtx053114;
	Wed, 9 Oct 2013 03:19:39 GMT
	(envelope-from nobody)
Message-Id: <201310090319.r993Jdtx053114@oldred.freebsd.org>
Date: Wed, 9 Oct 2013 03:19:39 GMT
From: clutton <clutton@zoho.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [maintainer update] [stagedir] multimedia/ffmpegthumbnailer
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: mbsd@isgroup.com.ua

>Number:         182848
>Category:       ports
>Synopsis:       [maintainer update] [stagedir] multimedia/ffmpegthumbnailer
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 09 03:20:00 UTC 2013
>Closed-Date:    Sat Oct 26 13:33:07 UTC 2013
>Last-Modified:  Sat Oct 26 13:40:00 UTC 2013
>Originator:     clutton
>Release:        current
>Organization:
>Environment:
FreeBSD host02 10.0-ALPHA4 FreeBSD 10.0-ALPHA4 #0 716c203(master): Sun Oct  6 11:46:04 EEST 2013     user@host02:/tmp/usr/src/sys/HOST02  amd64

>Description:
I want to update my maintainer email (the old one is broken).
And I have a question: 

I've deleted the line
-	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
was it correct?
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff --git a/multimedia/ffmpegthumbnailer/Makefile b/multimedia/ffmpegthumbnailer/Makefile
index ebc9e6e..defd2ff 100644
--- a/multimedia/ffmpegthumbnailer/Makefile
+++ b/multimedia/ffmpegthumbnailer/Makefile
@@ -7,7 +7,7 @@ PORTREVISION=	2
 CATEGORIES=	multimedia graphics
 MASTER_SITES=	GOOGLE_CODE
 
-MAINTAINER=	mbsd@isgroup.com.ua
+MAINTAINER=	clutton@zoho.com
 COMMENT=	Lightweight video thumbnailer that can be used by file managers
 
 LIB_DEPENDS=	png15:${PORTSDIR}/graphics/png \
@@ -25,24 +25,19 @@ USE_LDCONFIG=	yes
 
 OPTIONS_DEFINE=	GNOME
 
-MAN1=		ffmpegthumbnailer.1
-
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MGNOME}
-PKGNAMESUFFIX+=	-gnome
 USE_GNOME+=	gconf2
 GCONF_SCHEMAS=	ffmpegthumbnailer.schemas
 .endif
 
 post-install:
-	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
 .if ${PORT_OPTIONS:MGNOME}
-	${MKDIR} ${PREFIX}/etc/gconf/schemas
-	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${PREFIX}/etc/gconf/schemas
-	@${SETENV} GCONF_CONFIG_SOURCE=xml:${GCONF_CONFIG_OPTIONS}:${PREFIX}/${GCONF_CONFIG_DIRECTORY} \
-		gconftool-2 --makefile-install-rule ${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \
+	${MKDIR} ${STAGEDIR}${PREFIX}/etc/gconf/schemas
+	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${STAGEDIR}${PREFIX}/etc/gconf/schemas
+	@${SETENV} GCONF_CONFIG_SOURCE=xml:${GCONF_CONFIG_OPTIONS}:${STAGEDIR}${PREFIX}/${GCONF_CONFIG_DIRECTORY} \
+		gconftool-2 --makefile-install-rule ${STAGEDIR}${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \
 		> /dev/null || ${TRUE}
 .endif
 
diff --git a/multimedia/ffmpegthumbnailer/pkg-plist b/multimedia/ffmpegthumbnailer/pkg-plist
index 7f8e8fb..24769d6 100644
--- a/multimedia/ffmpegthumbnailer/pkg-plist
+++ b/multimedia/ffmpegthumbnailer/pkg-plist
@@ -10,4 +10,6 @@ lib/libffmpegthumbnailer.la
 lib/libffmpegthumbnailer.so
 lib/libffmpegthumbnailer.so.4
 libdata/pkgconfig/libffmpegthumbnailer.pc
+man/man1/ffmpegthumbnailer.1.gz
+
 @dirrm include/libffmpegthumbnailer


>Release-Note:
>Audit-Trail:
Class-Changed-From-To: maintainer-update->change-request 
Class-Changed-By: edwin 
Class-Changed-When: Wed Oct 9 03:20:08 UTC 2013 
Class-Changed-Why:  
Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182848 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Oct 9 03:20:09 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182848 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: mbsd@isgroup.com.ua
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/182848: [maintainer update] [stagedir] multimedia/ffmpegthumbnailer
Date: Wed, 9 Oct 2013 03:20:09 UT

 Maintainer of multimedia/ffmpegthumbnailer,
 
 Please note that PR ports/182848 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182848
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: clutton <clutton@zoho.com>
To: bug-followup@FreeBSD.org, clutton@zoho.com
Cc:  
Subject: Re: ports/182848: [maintainer update] [stagedir]
 multimedia/ffmpegthumbnailer
Date: Wed, 09 Oct 2013 06:37:41 +0300

 --=-Q1WugxCHnWQ8kNUQp7a0
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable
 
 The mentioned email is unavailable. Because the domain is dead.
 It was my email...
 
 --=-Q1WugxCHnWQ8kNUQp7a0
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iQIcBAABAgAGBQJSVM+FAAoJECNkWbjnbjuiB6cP+gPKhsfxdodVqh8/AKY6Lpxu
 nuZ53LqCe/yJ2DIhdN7OXDDlGje2Gyw9yfR80K/EaKaK6mWhxii0+zsNJfosR1VM
 CqrLBFyFxKr7zvPQwk0XHmSJBWPRdvNnMmOxBAmxQTMjEiZxatHPbT4jMgGTcD0Q
 epAOo28NOSN2ZPJRxvfVOnihXyOw5AS/UwKJ94YeSn7zLeapqRuOtn+C/dzxo0ny
 NUvZj6VPzYFlolQ4xPmYQZud2A1NsuycOKBHcIaG0JhpZm0HcIbH0YxAMRgzCLSL
 r1ilvYyiBS9wVbrfX3aZvFZvRMPOe2xswD9VHmfou91MyFvVvCnfqa/QdXDIeY0Z
 LsfiHfaBg9+Gn1l8FqdJDHVvBNm7F5VnFTU31pNgDyqbOXMRLG4uIRS2B19AZ4mG
 Pin9AI+quR6ZkY2RS2GNaND/bxIrHunv6e+Gzfp7L1s7fJj0CR2BENr2cxdiCu6D
 nUk9ro9pgSXfWVTSot4lmvUKuD3twyhaOkdHAiyrDlUEkwHPwJ30Ar0125zBxMYi
 d5TjZyuR5QaqJ6Lyxs2YVmiEiN6rS/SVSYn2Gs08P1u1GBj74aw5J7LhTmxay5cU
 5bWF/7Ce1au2Jjo3K+T61md4yp2PfvtTlRDyIyoxbndJAQUpwddPR6uKwsnjk9mB
 R+vjUm8mVXTG0f5mRaJk
 =W53r
 -----END PGP SIGNATURE-----
 
 --=-Q1WugxCHnWQ8kNUQp7a0--
 
 
Responsible-Changed-From-To: freebsd-ports-bugs->wg 
Responsible-Changed-By: wg 
Responsible-Changed-When: Sat Oct 26 01:32:57 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182848 
State-Changed-From-To: feedback->closed 
State-Changed-By: wg 
State-Changed-When: Sat Oct 26 13:32:27 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182848 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/182848: commit references a PR
Date: Sat, 26 Oct 2013 13:32:26 +0000 (UTC)

 Author: wg
 Date: Sat Oct 26 13:32:19 2013
 New Revision: 331687
 URL: http://svnweb.freebsd.org/changeset/ports/331687
 
 Log:
   multimedia/ffmpegthumbnailer: allow staging
   
   - Allow staging [1]
   - Convert lib depends to new format
   - Drop empty PTHREAD_CFLAGS
   
   PR:		ports/182848 [1] (based on)
   Submitted by:	clutton <clutton zoho.com> (maintainer)
   Reviewed by:	danfe
 
 Modified:
   head/multimedia/ffmpegthumbnailer/Makefile
   head/multimedia/ffmpegthumbnailer/pkg-plist
 
 Modified: head/multimedia/ffmpegthumbnailer/Makefile
 ==============================================================================
 --- head/multimedia/ffmpegthumbnailer/Makefile	Sat Oct 26 13:28:00 2013	(r331686)
 +++ head/multimedia/ffmpegthumbnailer/Makefile	Sat Oct 26 13:32:19 2013	(r331687)
 @@ -7,15 +7,15 @@ PORTREVISION=	2
  CATEGORIES=	multimedia graphics
  MASTER_SITES=	GOOGLE_CODE
  
 -MAINTAINER=	mbsd@isgroup.com.ua
 +MAINTAINER=	clutton@zoho.com
  COMMENT=	Lightweight video thumbnailer that can be used by file managers
  
 -LIB_DEPENDS=	png15:${PORTSDIR}/graphics/png \
 -		swscale:${PORTSDIR}/multimedia/ffmpeg \
 -		jpeg:${PORTSDIR}/graphics/jpeg
 +LIB_DEPENDS=	libpng15.so:${PORTSDIR}/graphics/png \
 +		libswscale.so:${PORTSDIR}/multimedia/ffmpeg \
 +		libjpeg.so:${PORTSDIR}/graphics/jpeg
  
 -CPPFLAGS+=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include
 -LDFLAGS+=	${PTHREAD_LIBS} -L${LOCALBASE}/lib
 +CPPFLAGS+=	-I${LOCALBASE}/include
 +LDFLAGS+=	-pthread -L${LOCALBASE}/lib
  CONFIGURE_ARGS=	--with-pkgconfigdir=${PREFIX}/libdata/pkgconfig --enable-gio
  
  GNU_CONFIGURE=	yes
 @@ -25,25 +25,17 @@ USE_LDCONFIG=	yes
  
  OPTIONS_DEFINE=	GNOME
  
 -MAN1=		ffmpegthumbnailer.1
 -
 -NO_STAGE=	yes
  .include <bsd.port.options.mk>
  
  .if ${PORT_OPTIONS:MGNOME}
 -PKGNAMESUFFIX+=	-gnome
  USE_GNOME+=	gconf2
  GCONF_SCHEMAS=	ffmpegthumbnailer.schemas
  .endif
  
  post-install:
 -	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
  .if ${PORT_OPTIONS:MGNOME}
 -	${MKDIR} ${PREFIX}/etc/gconf/schemas
 -	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${PREFIX}/etc/gconf/schemas
 -	@${SETENV} GCONF_CONFIG_SOURCE=xml:${GCONF_CONFIG_OPTIONS}:${PREFIX}/${GCONF_CONFIG_DIRECTORY} \
 -		gconftool-2 --makefile-install-rule ${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \
 -		> /dev/null || ${TRUE}
 +	@${MKDIR} ${STAGEDIR}${PREFIX}/etc/gconf/schemas
 +	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${STAGEDIR}${PREFIX}/etc/gconf/schemas
  .endif
  
  .include <bsd.port.mk>
 
 Modified: head/multimedia/ffmpegthumbnailer/pkg-plist
 ==============================================================================
 --- head/multimedia/ffmpegthumbnailer/pkg-plist	Sat Oct 26 13:28:00 2013	(r331686)
 +++ head/multimedia/ffmpegthumbnailer/pkg-plist	Sat Oct 26 13:32:19 2013	(r331687)
 @@ -10,4 +10,5 @@ lib/libffmpegthumbnailer.la
  lib/libffmpegthumbnailer.so
  lib/libffmpegthumbnailer.so.4
  libdata/pkgconfig/libffmpegthumbnailer.pc
 +man/man1/ffmpegthumbnailer.1.gz
  @dirrm include/libffmpegthumbnailer
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
