From darius@dons.net.au  Tue Oct  8 21:01:14 2013
Return-Path: <darius@dons.net.au>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id CF77B172
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  8 Oct 2013 21:01:14 +0000 (UTC)
	(envelope-from darius@dons.net.au)
Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [IPv6:2001:44b8:8060:ff02:300:1:2:7])
	by mx1.freebsd.org (Postfix) with ESMTP id 161D92210
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  8 Oct 2013 21:01:13 +0000 (UTC)
Received: from ppp118-210-202-219.lns20.adl6.internode.on.net (HELO midget.dons.net.au) ([118.210.202.219])
  by ipmail07.adl2.internode.on.net with ESMTP; 09 Oct 2013 07:31:12 +1030
Received: from ur.dons.net.au (Ur.dons.net.au [10.0.2.78])
	(authenticated bits=0)
	by midget.dons.net.au (8.14.6/8.14.4) with ESMTP id r98L17gC055767
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Wed, 9 Oct 2013 07:31:08 +1030 (CST)
	(envelope-from darius@dons.net.au)
Message-Id: <1E51B97D-2375-41D8-B14A-7AD71C7EEFD4@dons.net.au>
Date: Wed, 9 Oct 2013 07:31:07 +1030
From: "Daniel O'Connor" <darius@dons.net.au>
To: "Julian H. Stacey" <jhs@berklix.com>
Cc: FreeBSD-gnats-submit@freebsd.org
In-Reply-To: <201310081540.r98Fe6HZ058617@fire.js.berklix.net>
Subject: Re: ports/www/dummyflash/Makefile add BUILD_DEPENDS= gcc:ports/lang/gcc
References: <201310081540.r98Fe6HZ058617@fire.js.berklix.net>

>Number:         182841
>Category:       ports
>Synopsis:       Re: ports/www/dummyflash/Makefile add BUILD_DEPENDS= gcc:ports/lang/gcc
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 08 21:10:01 UTC 2013
>Closed-Date:    Tue Oct 15 04:33:37 UTC 2013
>Last-Modified:  Tue Oct 15 04:33:37 UTC 2013
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 --Apple-Mail=_DFF9BD9D-E849-468D-82BD-624BB7AF65E2
 Content-Type: multipart/mixed;
 	boundary="Apple-Mail=_49D6C71F-695E-48A9-9237-86B87DECA01E"
 
 
 --Apple-Mail=_49D6C71F-695E-48A9-9237-86B87DECA01E
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 
 On 09/10/2013, at 2:10, Julian H. Stacey <jhs@berklix.com> wrote:
 >> Fix:
 >=20
 > =09
 > apply patch appended
 > =
 http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/www/dummyflash/Mak=
 efile.REL=3DALL.diff
 >=20
 > *** current-2013-10-08-ctm-10069/ports/www/dummyflash/Makefile	=
 Tue Oct  8 17:27:31 2013
 > --- new/ports/www/dummyflash/Makefile	Tue Oct  8 17:28:01 2013
 > ***************
 > *** 13,18 ****
 > --- 13,19 ----
 >  COMMENT=3D	Silently consume flash MIME types
 >=20
 >  USE_XORG=3D	x11
 > + BUILD_DEPENDS=3D  gcc:${PORTSDIR}/lang/gcc
 >  BUILD_WRKSRC=3D	=
 ${WRKSRC}/PluginSDK30b5/examples/UnixTemplate/Unix
 >  NO_WRKSUBDIR=3D	yes
 >  MAKEFILE=3D	makefile.freebsd
 
 I no longer use this port (I use a click-to-flash extension in Chrome =
 instead), but I think the following diff is better. It doesn't depend on =
 GCC, just uses whatever the makefile framework says to use.
 
 It also splits out the patches into separate files.
 
 --
 Daniel O'Connor software and network engineer
 for Genesis Software - http://www.gsoft.com.au
 "The nice thing about standards is that there
 are so many of them to choose from."
   -- Andrew Tanenbaum
 GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C
 
 
 
 --Apple-Mail=_49D6C71F-695E-48A9-9237-86B87DECA01E
 Content-Disposition: attachment;
 	filename=dummyflash-update.diff
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="dummyflash-update.diff"
 Content-Transfer-Encoding: 7bit
 
 diff -Nur /usr/ports/www/dummyflash/files/patch-UnixShell.c dummyflash/files/patch-UnixShell.c
 --- /usr/ports/www/dummyflash/files/patch-UnixShell.c	1970-01-01 09:30:00.000000000 +0930
 +++ dummyflash/files/patch-UnixShell.c	2013-10-09 07:25:59.400475702 +1030
 @@ -0,0 +1,26 @@
 +--- PluginSDK30b5/examples/UnixTemplate/Source/UnixShell.c.orig	1996-07-12 15:10:28.000000000 +0930
 ++++ PluginSDK30b5/examples/UnixTemplate/Source/UnixShell.c	2013-10-09 07:24:13.570473153 +1030
 +@@ -48,7 +48,7 @@
 + char*
 + NPP_GetMIMEDescription(void)
 + {
 +-	return("mime/type:sample:Template Only");
 ++	return("application/x-shockwave-flash:null flash:Dummy flash plugin");
 + }
 + 
 + NPError
 +@@ -58,12 +58,11 @@
 + 
 + 	switch (variable) {
 + 		case NPPVpluginNameString:
 +-			*((char **)value) = "Template plugin";
 ++			*((char **)value) = "Dummy flash plugin";
 + 			break;
 + 		case NPPVpluginDescriptionString:
 + 			*((char **)value) =
 +-				"This plugins handles nothing. This is only"
 +-				" a template.";
 ++				"This is a dummy flash plugin";
 + 			break;
 + 		default:
 + 			err = NPERR_GENERIC_ERROR;
 diff -Nur /usr/ports/www/dummyflash/files/patch-aa dummyflash/files/patch-aa
 --- /usr/ports/www/dummyflash/files/patch-aa	2012-07-14 23:59:18.000000000 +0930
 +++ dummyflash/files/patch-aa	1970-01-01 09:30:00.000000000 +0930
 @@ -1,78 +0,0 @@
 ---- PluginSDK30b5/examples/UnixTemplate/Source/UnixShell.c.orig	Fri Jul 12 15:10:28 1996
 -+++ PluginSDK30b5/examples/UnixTemplate/Source/UnixShell.c	Thu Nov 21 15:38:24 2002
 -@@ -48,7 +48,7 @@
 - char*
 - NPP_GetMIMEDescription(void)
 - {
 --	return("mime/type:sample:Template Only");
 -+	return("application/x-shockwave-flash:null flash:Dummy flash plugin");
 - }
 - 
 - NPError
 -@@ -58,12 +58,11 @@
 - 
 - 	switch (variable) {
 - 		case NPPVpluginNameString:
 --			*((char **)value) = "Template plugin";
 -+			*((char **)value) = "Dummy flash plugin";
 - 			break;
 - 		case NPPVpluginDescriptionString:
 - 			*((char **)value) =
 --				"This plugins handles nothing. This is only"
 --				" a template.";
 -+				"This is a dummy flash plugin";
 - 			break;
 - 		default:
 - 			err = NPERR_GENERIC_ERROR;
 ---- PluginSDK30b5/examples/UnixTemplate/Unix/makefile.freebsd.orig	Thu Jan  1 09:30:00 1970
 -+++ PluginSDK30b5/examples/UnixTemplate/Unix/makefile.freebsd	Thu Nov 21 15:39:02 2002
 -@@ -0,0 +1,49 @@
 -+#!make
 -+################################################################################
 -+# Copyright (c) 1996 Netscape Communications. All rights reserved.
 -+################################################################################
 -+#
 -+# Template plugin makefile
 -+#
 -+# Platform: SunOS 4.1
 -+#
 -+# The output of the make process will be nptemplate.so
 -+# Install this file either in
 -+#	/usr/lib/netscape/plugins/
 -+#	(or)
 -+#	~/.netscape/plugins/
 -+#	(or) in any convenient directory and point environment variable
 -+#	     NPX_PLUGIN_PATH to point to the directory. It is advisable
 -+#	     that the plugins (.so) are the only files in that directory.
 -+#
 -+# This makefile contains some of our defines for the compiler:
 -+#
 -+# XP_UNIX	This needs to get defined for npapi.h on unix platforms.
 -+# PLUGIN_TRACE	Enable this define to get debug prints whenever the plugin
 -+#		api gets control.
 -+
 -+# PLUGIN_DEFINES= -DXP_UNIX -DPLUGIN_TRACE
 -+PLUGIN_DEFINES= -DXP_UNIX -I../../../include -I../Source/_gen -I${LOCALBASE}/include
 -+
 -+CC= gcc
 -+OPTIMIZER= -g
 -+CFLAGS=  $(OPTIMIZER) -fPIC $(PLUGIN_DEFINES) -I. -I$(ROOT)/usr/include
 -+
 -+SRC= ../Source/UnixShell.c ../Source/stubs.c 
 -+OBJ= UnixShell.o stubs.o
 -+
 -+SHAREDTARGET=dummyflash.so
 -+
 -+default all: $(SHAREDTARGET)
 -+
 -+$(SHAREDTARGET): $(OBJ)
 -+	$(LD) -shared -o $(SHAREDTARGET) $(OBJ) $(LDFLAGS)
 -+
 -+UnixShell.o: ../Source/UnixShell.c
 -+	$(CC) -c $(CFLAGS) ../Source/UnixShell.c
 -+
 -+stubs.o: ../Source/stubs.c
 -+	$(CC) -c $(CFLAGS) ../Source/stubs.c
 -+
 -+clean:
 -+	$(RM) $(OBJ) $(SHAREDTARGET)
 diff -Nur /usr/ports/www/dummyflash/files/patch-makefile.freebsd dummyflash/files/patch-makefile.freebsd
 --- /usr/ports/www/dummyflash/files/patch-makefile.freebsd	1970-01-01 09:30:00.000000000 +0930
 +++ dummyflash/files/patch-makefile.freebsd	2013-10-09 07:27:34.203470811 +1030
 @@ -0,0 +1,51 @@
 +--- PluginSDK30b5/examples/UnixTemplate/Unix/makefile.freebsd.orig	2013-10-09 07:24:13.572467161 +1030
 ++++ PluginSDK30b5/examples/UnixTemplate/Unix/makefile.freebsd	2013-10-09 07:27:13.288470186 +1030
 +@@ -0,0 +1,48 @@
 ++#!make
 ++################################################################################
 ++# Copyright (c) 1996 Netscape Communications. All rights reserved.
 ++################################################################################
 ++#
 ++# Template plugin makefile
 ++#
 ++# Platform: SunOS 4.1
 ++#
 ++# The output of the make process will be nptemplate.so
 ++# Install this file either in
 ++#	/usr/lib/netscape/plugins/
 ++#	(or)
 ++#	~/.netscape/plugins/
 ++#	(or) in any convenient directory and point environment variable
 ++#	     NPX_PLUGIN_PATH to point to the directory. It is advisable
 ++#	     that the plugins (.so) are the only files in that directory.
 ++#
 ++# This makefile contains some of our defines for the compiler:
 ++#
 ++# XP_UNIX	This needs to get defined for npapi.h on unix platforms.
 ++# PLUGIN_TRACE	Enable this define to get debug prints whenever the plugin
 ++#		api gets control.
 ++
 ++# PLUGIN_DEFINES= -DXP_UNIX -DPLUGIN_TRACE
 ++PLUGIN_DEFINES= -DXP_UNIX -I../../../include -I../Source/_gen -I${LOCALBASE}/include
 ++
 ++OPTIMIZER= -g
 ++CFLAGS=  $(OPTIMIZER) -fPIC $(PLUGIN_DEFINES) -I. -I$(ROOT)/usr/include
 ++
 ++SRC= ../Source/UnixShell.c ../Source/stubs.c 
 ++OBJ= UnixShell.o stubs.o
 ++
 ++SHAREDTARGET=dummyflash.so
 ++
 ++default all: $(SHAREDTARGET)
 ++
 ++$(SHAREDTARGET): $(OBJ)
 ++	$(LD) -shared -o $(SHAREDTARGET) $(OBJ) $(LDFLAGS)
 ++
 ++UnixShell.o: ../Source/UnixShell.c
 ++	$(CC) -c $(CFLAGS) ../Source/UnixShell.c
 ++
 ++stubs.o: ../Source/stubs.c
 ++	$(CC) -c $(CFLAGS) ../Source/stubs.c
 ++
 ++clean:
 ++	$(RM) $(OBJ) $(SHAREDTARGET)
 
 --Apple-Mail=_49D6C71F-695E-48A9-9237-86B87DECA01E
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii
 
 
 
 
 
 
 --Apple-Mail=_49D6C71F-695E-48A9-9237-86B87DECA01E--
 
 --Apple-Mail=_DFF9BD9D-E849-468D-82BD-624BB7AF65E2
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP using GPGMail
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org
 
 iD8DBQFSVHKT5ZPcIHs/zowRAq7CAJ9bZDBS6XdsiI3uOsyXPTOZ16ZMLACgi/Te
 /s55eSANTa2DJDzRPU6Qp4M=
 =ldgV
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_DFF9BD9D-E849-468D-82BD-624BB7AF65E2--
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Tue Oct 15 04:32:39 UTC 2013 
State-Changed-Why:  
Misfiled followup to ports/182834; content migrated. 


Responsible-Changed-From-To: gnats-admin->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Oct 15 04:32:39 UTC 2013 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=182841 
>Unformatted:
