From nobody@FreeBSD.org  Fri Sep 27 23:52:18 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id B236A5B9
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Sep 2013 23:52:18 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 9F68C2310
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Sep 2013 23:52:18 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r8RNqINn066159
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Sep 2013 23:52:18 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r8RNqITs066153;
	Fri, 27 Sep 2013 23:52:18 GMT
	(envelope-from nobody)
Message-Id: <201309272352.r8RNqITs066153@oldred.freebsd.org>
Date: Fri, 27 Sep 2013 23:52:18 GMT
From: Sbastien Santoro <dereckson@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [databases/pecl-memcached] Memcached::setSaslAuthData unavailable, by lack of SASL authentication option, 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: gslin@gslin.org

>Number:         182449
>Category:       ports
>Synopsis:       databases/pecl-memcached: Memcached::setSaslAuthData unavailable, by lack of SASL authentication option,
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          feedback
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 28 00:00:01 UTC 2013
>Closed-Date:    
>Last-Modified:  Mon Apr 28 02:40:00 UTC 2014
>Originator:     Sbastien Santoro
>Release:        
>Organization:
>Environment:
(current bug isn't environment dependant)
>Description:
PECL extension by default doesn't include SASL authentication, it should be explicitly asked at configure time.

Excerpt from http://www.php.net/manual/en/memcached.installation.php:
SASL authentication support is disabled by default. To enable it, use --enable-memcached-sasl switch. This requires that libsasl2 has been installed and that libmemcached has been built with SASL support enabled.

Excerpt from http://www.php.net/manual/en/memcached.setsaslauthdata.php:
This method is only available when the memcached extension is build with SASL support. Please refer to Memcached setup for how to do this.
>How-To-Repeat:
<?php
    $memcached = new Memcached();
    $memcached->addServer('localhost', 11211);
    $memcached->setSaslAuthData('username', 'password');
    //Fails, as setSaslAuthData doesn't exist

>Fix:
Add a SASL option:
- adding --enable-memcached-sasl to ./configure
- adding security/cyrus-sasl2 as dependency (should have been done by libmemcached)

If you wish to do it without the option:
- Argument pro: databases/libmemcached now always add SASL support
- Argument against: databases/memcached still provides the option (but we're in the client side, not the server side, so shouldn't we be coherent with libmemcached choice?)


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Sep 28 00:00:10 UTC 2013 
Responsible-Changed-Why:  
miwi@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182449 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Sep 28 00:00:11 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182449 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: gslin@gslin.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/182449: [databases/pecl-memcached] Memcached::setSaslAuthData unavailable, by lack of SASL authentication option,
Date: Sat, 28 Sep 2013 00:00:11 UT

 Maintainer of databases/pecl-memcached,
 
 Please note that PR ports/182449 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182449
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Gea-Suan Lin <gslin@gslin.org>
To: bug-followup@FreeBSD.org
Cc: gslin@gslin.org
Subject: Re: ports/182449: [databases/pecl-memcached]
 Memcached::setSaslAuthData unavailable, by lack of SASL authentication
 option,
Date: Tue, 22 Oct 2013 17:48:24 +0800

 Thanks, would you like to offer a patch to include these features ?
 
 On Sat, Sep 28, 2013 at 12:00:11AM +0000, Edwin Groothuis wrote:
 > Maintainer of databases/pecl-memcached,
 > 
 > Please note that PR ports/182449 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182449
 > 
 > -- 
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 
 -- 
 * Gea-Suan Lin  (public key: Using https://keyserver.pgp.com/ to search)
 * If you cannot convince them, confuse them.           -- Harry S Truman
Responsible-Changed-From-To: miwi->freebsd-port-bugs 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Tue Jan 7 04:18:29 UTC 2014 
Responsible-Changed-Why:  
back to pool. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182449 
Responsible-Changed-From-To: freebsd-port-bugs->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Mar 23 19:56:12 UTC 2014 
Responsible-Changed-Why:  
Canonicalize assignment. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182449 

From: Niels Poppe <niels.poppe@gmail.com>
To: bug-followup@FreeBSD.org,
 dereckson@gmail.com
Cc:  
Subject: Re: ports/182449: databases/pecl-memcached: Memcached::setSaslAuthData unavailable, by lack of SASL authentication option,
Date: Mon, 28 Apr 2014 04:24:53 +0200

 Someone somewhere found this problem and the solution, but somehow =
 nobody followed up the friendly request to do the work:
 
 > From:	Gea-Suan Lin <gslin@gslin.org>
 > To:	bug-followup@FreeBSD.org
 > Date:	Tue, 22 Oct 2013 17:48:24 +0800
 >=20
 > Thanks, would you like to offer a patch to include these features ?
 >=20
 > On Sat, Sep 28, 2013 at 12:00:11AM +0000, Edwin Groothuis wrote:
 > > Maintainer of databases/pecl-memcached,
 > >=20
 > > Please note that PR ports/182449 has just been submitted.
 > >=20
 
 This little patch does provide the needed option (I did not look any =
 deeper than that).
 
 Index: databases/pecl-memcached/Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 --- databases/pecl-memcached/Makefile	(revision 352016)
 +++ databases/pecl-memcached/Makefile	(working copy)
 @@ -25,8 +25,9 @@
  USE_PHP_BUILD=3D	yes
  CONFIGURE_ARGS+=3D--with-libmemcached-dir=3D${LOCALBASE}
 =20
 -OPTIONS_DEFINE=3D	IGBINARY
 +OPTIONS_DEFINE=3D	IGBINARY SASL
  IGBINARY_DESC=3D	Binary serializer support
 +SASL_DESC=3D	Cyrus SASL support
 =20
  .include <bsd.port.options.mk>
 =20
 @@ -36,4 +37,9 @@
  RUN_DEPENDS+=3D	=
 ${LOCALBASE}/lib/php/${PHP_EXT_DIR}/igbinary.so:${PORTSDIR}/converters/igb=
 inary
  .endif
 =20
 +.if ${PORT_OPTIONS:MSASL}
 +CONFIGURE_ARGS+=3D--enable-memcached-sasl
 +LIB_DEPENDS+=3D sasl2:${PORTSDIR}/security/cyrus-sasl2
 +.endif
 +
  .include <bsd.port.mk>
 
>Unformatted:
