From nobody@FreeBSD.org  Sun Sep 22 12:08:32 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id ADE94C06
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 22 Sep 2013 12:08:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 9CCB62B85
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 22 Sep 2013 12:08:32 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r8MC8VH3039094
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 22 Sep 2013 12:08:31 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r8MC8VVv039089;
	Sun, 22 Sep 2013 12:08:31 GMT
	(envelope-from nobody)
Message-Id: <201309221208.r8MC8VVv039089@oldred.freebsd.org>
Date: Sun, 22 Sep 2013 12:08:31 GMT
From: Alex <lexus@hostelnet.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/fsc not forked to background at start
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         182294
>Category:       ports
>Synopsis:       sysutils/fsc not forked to background at start
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    trhodes
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 22 12:10:00 UTC 2013
>Closed-Date:    Tue Mar 11 05:25:27 UTC 2014
>Last-Modified:  Tue Mar 11 05:30:00 UTC 2014
>Originator:     Alex
>Release:        9.2-RC4
>Organization:
>Environment:
FreeBSD xxx 9.2-RC4 FreeBSD 9.2-RC4 #0 r255465: Wed Sep 11 09:29:50 UTC 2013     root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
root@:/home/test # pkg inf fsc
fsc-1.0.1_2
root@:/home/test # cat /usr/local/etc/fscd.conf
sshd
root@:/home/test # service fscd start
Starting fscd.
sshd is running as pid 1474.

^Cfscd: pidfile_remove: Bad file descriptor
/usr/local/etc/rc.d/fscd: WARNING: failed to start fscd

On startup system will waiting when fscd going to background while user don't hit Ctrl+C
>How-To-Repeat:
Install sysutils/fsc from ports (current version 1.0.1_2).
Same results on 9.1-RELEASE and 10.0-ALPHA1
>Fix:
Dirty workaround:
--- /usr/local/etc/rc.d/fscd    2013-09-22 15:50:03.000000000 +0600
+++ /usr/local/etc/rc.d/fscd    2013-09-22 16:15:57.000000000 +0600
@@ -13,8 +13,19 @@
 . /etc/rc.subr

 name="fscd"
+rcvar="fscd_enable"
+load_rc_config $name
+: ${fscd_enable="NO"}
+
 command="/usr/local/sbin/${name}"
 pidfile="/var/run/${name}.pid"
+required_files="/usr/local/etc/$name.conf"
+
+start_cmd=fscd_start
+
+fscd_start()
+{
+       /usr/sbin/daemon -cf ${command}
+}

-load_rc_config $name
 run_rc_command "$1"

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->trhodes 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Sep 22 12:10:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182294 

From: Koichiro IWAO <meta@vmeta.jp>
To: bug-followup@freebsd.org, ports@freebsd.org
Cc:  
Subject: Re: ports/182294: sysutils/fsc not forked to background at start
Date: Tue, 11 Mar 2014 13:01:58 +0900

 Would someone please commit ports/182294?
 sysutils/fsc is a useful tool except for its poor rc script.
 http://www.freebsd.org/cgi/query-pr.cgi?pr=182294
 
 -- 
 `whois vmeta.jp | nkf -w`
 meta <meta@vmeta.jp>
State-Changed-From-To: open->closed 
State-Changed-By: daichi 
State-Changed-When: Tue Mar 11 05:25:08 UTC 2014 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182294 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/182294: commit references a PR
Date: Tue, 11 Mar 2014 05:24:18 +0000 (UTC)

 Author: daichi
 Date: Tue Mar 11 05:24:10 2014
 New Revision: 347843
 URL: http://svnweb.freebsd.org/changeset/ports/347843
 QAT: https://qat.redports.org/buildarchive/r347843/
 
 Log:
   fixed a start-up issue
   
   PR:		ports/182294
   Submitted by:	Alex <lexus@hostelnet.ru>
   Reviewed by:	Koichiro IWAO <meta@vmeta.jp>
 
 Added:
   head/sysutils/fsc/files/
   head/sysutils/fsc/files/patch-rc.d_fscd   (contents, props changed)
 Modified:
   head/sysutils/fsc/Makefile
 
 Modified: head/sysutils/fsc/Makefile
 ==============================================================================
 --- head/sysutils/fsc/Makefile	Tue Mar 11 05:17:43 2014	(r347842)
 +++ head/sysutils/fsc/Makefile	Tue Mar 11 05:24:10 2014	(r347843)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	fsc
  PORTVERSION=	1.0.1
 -PORTREVISION=	2
 +PORTREVISION=	3
  CATEGORIES=	sysutils
  MASTER_SITES=	LOCAL
  MASTER_SITE_SUBDIR=	trhodes
 @@ -17,8 +17,6 @@ PLIST_FILES=	bin/fscadm sbin/fscd etc/rc
  		man/man8/fscadm.8.gz man/man8/fscd.8.gz
  
  post-patch:
 -	@${REINPLACE_CMD} -e 's|/usr|${PREFIX}|' \
 -		${WRKSRC}/rc.d/fscd
  	@${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|' \
  		${WRKSRC}/fscd/fscd.8 ${WRKSRC}/fscd/fscd.c \
  		${WRKSRC}/fscd/fscd.conf.5 ${WRKSRC}/fscadm/fscadm.c
 
 Added: head/sysutils/fsc/files/patch-rc.d_fscd
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/sysutils/fsc/files/patch-rc.d_fscd	Tue Mar 11 05:24:10 2014	(r347843)
 @@ -0,0 +1,24 @@
 +--- rc.d/fscd.orig	2014-03-11 14:19:18.576173326 +0900
 ++++ rc.d/fscd	2014-03-11 14:20:09.206171150 +0900
 +@@ -13,8 +13,19 @@
 + . /etc/rc.subr
 + 
 + name="fscd"
 +-command="/usr/sbin/${name}"
 ++rcvar="fscd_enable"
 ++load_rc_config $name
 ++: ${fscd_enable="NO"}
 ++
 ++command="/usr/local/sbin/${name}"
 + pidfile="/var/run/${name}.pid"
 ++required_files="/usr/local/etc/$name.conf"
 ++
 ++start_cmd=fscd_start
 ++
 ++fscd_start()
 ++{
 ++	/usr/sbin/daemon -cf ${command}
 ++}
 + 
 +-load_rc_config $name
 + run_rc_command "$1"
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
