From root@www.unix-experience.fr  Sat Sep 21 09:54:29 2013
Return-Path: <root@www.unix-experience.fr>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id DD07950F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 21 Sep 2013 09:54:29 +0000 (UTC)
	(envelope-from root@www.unix-experience.fr)
Received: from www.unix-experience.fr (unix-experience.fr [88.191.192.43])
	by mx1.freebsd.org (Postfix) with ESMTP id A5E5A250F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 21 Sep 2013 09:54:29 +0000 (UTC)
Received: by www.unix-experience.fr (Postfix, from userid 0)
	id 71E8560650; Sat, 21 Sep 2013 11:56:07 +0200 (CEST)
Message-Id: <20130921095607.71E8560650@www.unix-experience.fr>
Date: Sat, 21 Sep 2013 11:56:07 +0200 (CEST)
From: Loic Blot <loic.blot@unix-experience.fr>
Reply-To: Loic Blot <loic.blot@unix-experience.fr>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: missing rcvar on netdisco
X-Send-Pr-Version: 3.113
X-GNATS-Notify: dgeo@centrale-marseille.fr

>Number:         182277
>Category:       ports
>Synopsis:       missing rcvar on net-mgmt/netdisco
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 21 10:00:00 UTC 2013
>Closed-Date:    Sun Nov 03 04:54:10 UTC 2013
>Last-Modified:  Sun Nov  3 05:00:00 UTC 2013
>Originator:     Loic Blot
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
Institut Optique Graduate School
>Environment:
System: FreeBSD www.unix-experience.fr 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec 4 09:23:10 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64

>Description:
	netdisco service rcvar is missing, then service wants to launch at each boot.
>How-To-Repeat:
	Install netdisco without set the netdisco_enable in rc.conf. Reboot
>Fix:
	This line must be added to /usr/local/etc/rc.d/netdisco:
	rcvar=${name}_enable


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Sep 21 15:23:51 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182277 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: dgeo@centrale-marseille.fr
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/182277: missing rcvar on net-mgmt/netdisco
Date: Sat, 21 Sep 2013 15:23:50 UT

 Maintainer of net-mgmt/netdisco,
 
 Please note that PR ports/182277 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/182277
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Sun Sep 22 06:13:28 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182277 
State-Changed-From-To: feedback->closed 
State-Changed-By: sunpoet 
State-Changed-When: Sun Nov 3 04:54:09 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182277 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/182277: commit references a PR
Date: Sun,  3 Nov 2013 04:54:07 +0000 (UTC)

 Author: sunpoet
 Date: Sun Nov  3 04:53:54 2013
 New Revision: 332583
 URL: http://svnweb.freebsd.org/changeset/ports/332583
 
 Log:
   - Add missing rcvar in rc.d script
   - Bump PORTREVISION for package change
   - While I'm here, use bsd.port.mk instead of bsd.port.pre.mk + bsd.port.post.mk
   
   PR:		ports/182277
   Submitted by:	Loic Blot <loic.blot@unix-experience.fr>
   Approved by:	maintainer (timeout, 7 weeks)
 
 Modified:
   head/net-mgmt/netdisco/Makefile
   head/net-mgmt/netdisco/files/netdisco.in
 
 Modified: head/net-mgmt/netdisco/Makefile
 ==============================================================================
 --- head/net-mgmt/netdisco/Makefile	Sun Nov  3 04:53:49 2013	(r332582)
 +++ head/net-mgmt/netdisco/Makefile	Sun Nov  3 04:53:54 2013	(r332583)
 @@ -3,6 +3,7 @@
  
  PORTNAME=	netdisco
  PORTVERSION=	1.3.2
 +PORTREVISION=	1
  CATEGORIES=	net-mgmt www
  MASTER_SITES=	SF
  
 @@ -38,6 +39,7 @@ USE_APACHE_RUN=	22+
  USE_RC_SUBR=	netdisco
  
  NO_BUILD=	yes
 +NO_STAGE=	yes
  
  NETDISCO_RUNDIR=/var/run
  NETDISCO_DBDIR=	/var/db/netdisco
 @@ -56,8 +58,7 @@ CONFIG_FILES=	netdisco.conf netdisco.cro
  
  DOCFILES=	ChangeLog doc/*.pod INSTALL README* UPGRADE
  
 -NO_STAGE=	yes
 -.include <bsd.port.pre.mk>
 +.include <bsd.port.options.mk>
  
  MIBSDIR=	${PREFIX}/share/netdisco-mibs
  .if ${PORT_OPTIONS:MMIBS}
 @@ -150,4 +151,4 @@ post-install:
  .	endif
  	@${CAT} ${PKGMESSAGE}
  
 -.include <bsd.port.post.mk>
 +.include <bsd.port.mk>
 
 Modified: head/net-mgmt/netdisco/files/netdisco.in
 ==============================================================================
 --- head/net-mgmt/netdisco/files/netdisco.in	Sun Nov  3 04:53:49 2013	(r332582)
 +++ head/net-mgmt/netdisco/files/netdisco.in	Sun Nov  3 04:53:54 2013	(r332583)
 @@ -10,6 +10,7 @@
  . /etc/rc.subr
  
  name="netdisco"
 +rcvar="netdisco_enable"
  
  load_rc_config $name
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
