From crees@bayofrum.net  Wed Sep 11 20:03:35 2013
Return-Path: <crees@bayofrum.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 946EA1BA
	for <freebsd-gnats-submit@freebsd.org>; Wed, 11 Sep 2013 20:03:35 +0000 (UTC)
	(envelope-from crees@bayofrum.net)
Received: from mk-outboundfilter-2.mail.uk.tiscali.com (mk-outboundfilter-2.mail.uk.tiscali.com [212.74.114.38])
	by mx1.freebsd.org (Postfix) with ESMTP id 308EC2474
	for <freebsd-gnats-submit@freebsd.org>; Wed, 11 Sep 2013 20:03:34 +0000 (UTC)
Received: from host-2-102-106-185.as13285.net (HELO pegasus.bayofrum.net) ([2.102.106.185])
  by smtp.pipex.tiscali.co.uk with ESMTP; 11 Sep 2013 21:03:27 +0100
Received: by pegasus.bayofrum.net (Postfix, from userid 1001)
	id 4F2393B7F3; Wed, 11 Sep 2013 21:03:04 +0100 (BST)
Message-Id: <20130911200304.4F2393B7F3@pegasus.bayofrum.net>
Date: Wed, 11 Sep 2013 21:03:04 +0100 (BST)
From: Chris Rees <crees@FreeBSD.org>
Reply-To: Chris Rees <crees@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Fix port: textproc/docbook-xml should use base unzip where possible
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         182022
>Category:       ports
>Synopsis:       Fix port: textproc/docbook-xml should use base unzip where possible
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kuriyama
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 11 20:10:00 UTC 2013
>Closed-Date:    Sun Oct 06 12:35:10 UTC 2013
>Last-Modified:  Sun Oct 06 12:35:10 UTC 2013
>Originator:     Chris Rees
>Release:        FreeBSD 9.1-RELEASE-p4 amd64
>Organization:
>Environment:
System: FreeBSD pegasus.bayofrum.net 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #1 r252227M: Sat Jun 29 13:55:30 BST 2013 root@pegasus.bayofrum.net:/usr/obj/usr/src/sys/PEGASUS amd64


	
>Description:
	USE_ZIP depends on any binary called unzip, so build fails when base unzip is present, but not the zip package.

	http://www.bayofrum.net/medusa/tinderlogs/10-local-20130829053459/docbook-xml-4.2_1.log (modified tinderbox to use the ports system to install dependencies, but will apply if installing on a clean system)
>How-To-Repeat:
	
>Fix:

	Use plain unzip rather than ${UNZIP_CMD}

--- patch.txt begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 327009)
+++ Makefile	(working copy)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	DocBook XML DTD
-# Date created:		28 March 1999
-# Whom:			kuriyama
-#
+# Created by: kuriyama
 # $FreeBSD$
-#
 
 PORTNAME=	docbook-xml
 PORTVERSION=	4.2
@@ -36,7 +32,7 @@
 	@[ -d ${DOCBOOKDIR}/ent ] || ${MKDIR} ${DOCBOOKDIR}/ent
 
 do-install:
-	for file in `${UNZIP_CMD} -l ${DISTDIR}/${DISTFILES}|${AWK} '/:[0-9].*[^\/]$$/{print $$4}'`; do \
+	for file in `unzip -l ${DISTDIR}/${DISTFILES}|${AWK} '/:[0-9].*[^\/]$$/{print $$4}'`; do \
 		${INSTALL_DATA} ${WRKSRC}/$$file ${DOCBOOKDIR}/$$file; \
 	done
 
--- patch.txt ends here ---



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kuriyama 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Sep 11 20:10:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182022 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Sun Oct 6 12:35:10 UTC 2013 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=182022 
>Unformatted:
