From tijl@coosemans.org  Mon Sep  2 19:00:52 2013
Return-Path: <tijl@coosemans.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 52B00F02
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  2 Sep 2013 19:00:52 +0000 (UTC)
	(envelope-from tijl@coosemans.org)
Received: from mailrelay010.isp.belgacom.be (mailrelay010.isp.belgacom.be [195.238.6.177])
	by mx1.freebsd.org (Postfix) with ESMTP id E12DD2AB5
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  2 Sep 2013 19:00:51 +0000 (UTC)
Received: from 197.77-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.77.197])
  by relay.skynet.be with ESMTP; 02 Sep 2013 20:59:42 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1])
	by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r82IxfSG046450
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 2 Sep 2013 20:59:41 +0200 (CEST)
	(envelope-from tijl@kalimero.tijl.coosemans.org)
Received: (from tijl@localhost)
	by kalimero.tijl.coosemans.org (8.14.7/8.14.7/Submit) id r82Ixfhi046449;
	Mon, 2 Sep 2013 20:59:41 +0200 (CEST)
	(envelope-from tijl)
Message-Id: <201309021859.r82Ixfhi046449@kalimero.tijl.coosemans.org>
Date: Mon, 2 Sep 2013 20:59:41 +0200 (CEST)
From: Tijl Coosemans <tijl@FreeBSD.org>
Reply-To: Tijl Coosemans <tijl@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] devel/mingw32-binutils: fix build with clang
X-Send-Pr-Version: 3.114
X-GNATS-Notify: cyberbotx@cyberbotx.com

>Number:         181761
>Category:       ports
>Synopsis:       [patch] devel/mingw32-binutils: fix build with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tijl
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 02 19:10:00 UTC 2013
>Closed-Date:    Tue Sep 03 00:05:08 CEST 2013
>Last-Modified:  Mon Sep  2 22:10:00 UTC 2013
>Originator:     Tijl Coosemans
>Release:        FreeBSD 10.0-CURRENT i386
>Organization:
>Environment:
>Description:
The attached removes USE_GCC=any and adds --disable-werror to
CONFIGURE_ARGS to allow building with clang.
Initially I tried adding flags like -Wno-error=string-plus-int to CFLAGS
but I kept having to disable more and more warnings and future versions
of clang might require even more that I think setting --disable-werror is
best.
The attached patch also converts USE_GMAKE to USES=gmake.
>How-To-Repeat:
>Fix:

--- mingw32-binutils.patch begins here ---
Index: devel/mingw32-binutils/Makefile
===================================================================
--- devel/mingw32-binutils/Makefile	(revision 325982)
+++ devel/mingw32-binutils/Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	binutils
 PORTVERSION=	${BINUTILVERSION}
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_SOURCEWARE}
@@ -15,14 +16,12 @@ COMMENT=	GNU Binutils for Windows cross-
 BINUTILVERSION=	2.23.1
 
 USE_BZIP2=	yes
-USE_GCC=	any
-USE_GMAKE=	yes
-USES=		iconv
+USES=		gmake iconv
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--target=${PKGNAMEPREFIX:S/-$//} \
 		--with-gcc --with-gnu-ld --with-gnu-as \
 		--disable-nls --disable-win32-registry \
-		--disable-shared
+		--disable-shared --disable-werror
 INFO_PATH=	${PKGNAMEPREFIX:S/-$//}/info
 
 MAN1=	${PKGNAMEPREFIX}addr2line.1 ${PKGNAMEPREFIX}ar.1    \
--- mingw32-binutils.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Sep 2 19:10:08 UTC 2013 
Responsible-Changed-Why:  
miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181761 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Sep 2 19:10:10 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181761 
Responsible-Changed-From-To: miwi->tijl 
Responsible-Changed-By: tijl 
Responsible-Changed-When: Mon Sep 2 21:15:15 CEST 2013 
Responsible-Changed-Why:  
Track my own PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181761 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: cyberbotx@cyberbotx.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/181761: [patch] devel/mingw32-binutils: fix build with clang
Date: Mon, 2 Sep 2013 19:10:10 UT

 Maintainer of devel/mingw32-binutils,
 
 Please note that PR ports/181761 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181761
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Naram Qashat <cyberbotx@cyberbotx.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/181761: [patch] devel/mingw32-binutils: fix build with
 clang
Date: Mon, 02 Sep 2013 17:05:11 -0400

 This patch is good to me. Go ahead.
 
 Thanks,
 Naram Qashat
 
 On 09/02/13 15:10, Edwin Groothuis wrote:
 > Maintainer of devel/mingw32-binutils,
 >
 > Please note that PR ports/181761 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181761
 >
State-Changed-From-To: feedback->closed 
State-Changed-By: tijl 
State-Changed-When: Tue Sep 3 00:03:58 CEST 2013 
State-Changed-Why:  
Committed in r326102. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181761 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/181761: commit references a PR
Date: Mon,  2 Sep 2013 22:00:59 +0000 (UTC)

 Author: tijl
 Date: Mon Sep  2 22:00:52 2013
 New Revision: 326102
 URL: http://svnweb.freebsd.org/changeset/ports/326102
 
 Log:
   - Remove USE_GCC=any and fix building with clang by disabling -Werror.
   - Convert USE_GMAKE to USES=gmake.
   
   PR:		181761
   Approved by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)
 
 Modified:
   head/devel/mingw32-binutils/Makefile
 
 Modified: head/devel/mingw32-binutils/Makefile
 ==============================================================================
 --- head/devel/mingw32-binutils/Makefile	Mon Sep  2 21:57:08 2013	(r326101)
 +++ head/devel/mingw32-binutils/Makefile	Mon Sep  2 22:00:52 2013	(r326102)
 @@ -3,6 +3,7 @@
  
  PORTNAME=	binutils
  PORTVERSION=	${BINUTILVERSION}
 +PORTREVISION=	1
  PORTEPOCH=	1
  CATEGORIES=	devel
  MASTER_SITES=	${MASTER_SITE_SOURCEWARE}
 @@ -15,14 +16,12 @@ COMMENT=	GNU Binutils for Windows cross-
  BINUTILVERSION=	2.23.1
  
  USE_BZIP2=	yes
 -USE_GCC=	any
 -USE_GMAKE=	yes
 -USES=		iconv
 +USES=		gmake iconv
  GNU_CONFIGURE=	yes
  CONFIGURE_ARGS=	--target=${PKGNAMEPREFIX:S/-$//} \
  		--with-gcc --with-gnu-ld --with-gnu-as \
  		--disable-nls --disable-win32-registry \
 -		--disable-shared
 +		--disable-shared --disable-werror
  INFO_PATH=	${PKGNAMEPREFIX:S/-$//}/info
  
  MAN1=	${PKGNAMEPREFIX}addr2line.1 ${PKGNAMEPREFIX}ar.1    \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
