From nobody@FreeBSD.org  Mon Sep  2 08:36:54 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 0EACDA20
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  2 Sep 2013 08:36:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id D7B86277C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  2 Sep 2013 08:36:53 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r828arGm046534
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 2 Sep 2013 08:36:53 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r828ar3O046531;
	Mon, 2 Sep 2013 08:36:53 GMT
	(envelope-from nobody)
Message-Id: <201309020836.r828ar3O046531@oldred.freebsd.org>
Date: Mon, 2 Sep 2013 08:36:53 GMT
From: Pietro Cerutti <gahr@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] www/mod_rivet -- support configuration options
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: cowbert@gmail.com

>Number:         181747
>Category:       ports
>Synopsis:       [patch] www/mod_rivet -- support configuration options
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    apache
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 02 08:40:01 UTC 2013
>Closed-Date:    Fri Feb 14 15:27:37 UTC 2014
>Last-Modified:  Fri Feb 14 15:27:37 UTC 2014
>Originator:     Pietro Cerutti
>Release:        
>Organization:
The FreeBSD Project
>Environment:
>Description:
The patch adds support for turning on/off the following configuration options

- The ::rivet namespace is automatically imported
- Commands of the ::rivet namespace are exported

The default is ON for both options, which keeps the current functionality. Also, I also added DOCS to OPTIONS.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 325946)
+++ Makefile	(working copy)
@@ -15,6 +15,11 @@
 
 LIB_DEPENDS=	libitcl.so:${PORTSDIR}/lang/itcl
 
+OPTIONS_DEFINE=	IMP_NS EXP_CMD DOCS
+OPTIONS_DEFAULT=IMP_NS EXP_CMD
+IMP_NS_DESC=	Import the ::rivet namespace
+EXP_CMD_DESC=	Export commands from the ::rivet namespace
+
 USE_APACHE=	22+
 USE_TCL=	85+
 USE_LDCONFIG=	${PREFIX}/lib/rivet
@@ -22,20 +27,40 @@
 USES=		gmake
 GNU_CONFIGURE=	yes
 
+PORTDOCS=	*
 INSTALL_TARGET=	install install-packages
 
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
-CONFIGURE_ARGS+=	--with-apache-version=2 \
-			--prefix=${PREFIX} --with-apxs=${APXS} \
-			--with-tcl=${TCL_LIBDIR} --with-tclsh=${TCLSH} \
-			--with-rivet-target-dir=${PREFIX}/lib/rivet
+.if !${PORT_OPTIONS:MIMP_NS}
+CONFIGURE_ARGS+=--disable-import-rivet-commands
+.endif
 
+.if !${PORT_OPTIONS:MEXP_CMD}
+CONFIGURE_ARGS+=--disable-rivet-commands-export
+.endif
+
+.if ${PORT_OPTIONS:MPACKAGES}
+PLIST_SUB+=	PACKAGES=""
+INSTALL_TARGET+=install-packages
+.else
+PLIST_SUB+=	PACKAGES="@comment "
+.endif
+
+CONFIGURE_ARGS+=--with-apache-version=2 \
+		--prefix=${PREFIX} --with-apxs=${APXS} \
+		--with-tcl=${TCL_LIBDIR} --with-tclsh=${TCLSH} \
+		--with-rivet-target-dir=${PREFIX}/lib/rivet
+
 post-patch:
 	${REINPLACE_CMD}  -e 's|`$${apxs_found} -q LIBEXECDIR`|${PREFIX}/${APACHEMODDIR}|g' \
 	   ${WRKSRC}/configure.ac ${WRKSRC}/configure
 
 post-install:
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
+	@cd ${WRKSRC}/doc/html && ${COPYTREE_SHARE} \* ${DOCSDIR}
+.endif
 	@${ECHO_MSG} ""
 	@${ECHO_MSG} "===================================================="
 	@${ECHO_MSG} "Remember to modify your apache configuration file"
@@ -50,4 +75,4 @@
 	@${ECHO_MSG} ""
 	@${ECHO_MSG} "===================================================="
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->apache 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Sep 2 08:40:08 UTC 2013 
Responsible-Changed-Why:  
apache@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181747 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Sep 2 08:40:10 UTC 2013 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181747 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: cowbert@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/181747: [patch] www/mod_rivet -- support configuration options
Date: Mon, 2 Sep 2013 08:40:09 UT

 Maintainer of www/mod_rivet,
 
 Please note that PR ports/181747 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181747
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Pietro Cerutti <gahr@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/181747: [patch] www/mod_rivet -- support configuration
 options
Date: Wed, 23 Oct 2013 15:47:24 +0200

 --ggdAeHltlv4tpqCr
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 PING?
 
 --=20
 Pietro Cerutti
 The FreeBSD Project
 gahr@FreeBSD.org
 
 PGP Public Key:
 http://gahr.ch/pgp
 
 --ggdAeHltlv4tpqCr
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iQJ8BAEBCgBmBQJSZ9NnXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB
 REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgieS2gP/0aZM4Xh4XQs2IomPPimIbqt
 ImgwOWzMChORkdG13wkLzqhGQ7lrfOqwITQwVlnVKYXx81NsUyGBBVWpmDcXIwP5
 d41LZjABda6P+SaCQapGUPfOml8tBykGSOrS2DjsdQHT+XJpl0AuBXK4IaAofdL+
 nQYgbztl616Jh36aeZUPx/VugHb7eDKtdp7tNzN1dn5c+3d+8aAPuHrq7aSWToka
 PaIgJy24uCMRr8guQvUyXOxN06rSttEVvEvYQIK71VJJgD4DEg8VzZRMvGnB5sPx
 z0zVlDxofPMzwB8ow4cvw0+uKnL+93CY4v+6tKAU2KuPVeR+/chEwa66HL8+xl1f
 3gV5SJcAbPeWmQhefLmQvhZSofehrYQnXdn9bOfEzGRtnu9ZWiAQSUYogJFdaTI8
 oGszvQzCrkvjVHfEDnga2uMFcquOkERu7zRHKciuOg9hs6aTKmPfDfbXS4r/CKeS
 +DGL3M8QzrqPTj419OOz6SSdN0A6DLPllCOQE6gAiJfPB3+Yufwn5qMXR8VTimqv
 493gy+uQ+t2f/zWgDbCZh/wQ/LVlthbKdxZCwK1aqVu6dz/qvcozbK3vPQHJzLMt
 X82pMafNjTVS7BVOymC1VfxQApx6Iw+fnC0aL7OTmcQfpqm3+eEnXYHhjcoYzIuB
 6L+GYK+k0sTdlOG8NVLb
 =YxSj
 -----END PGP SIGNATURE-----
 
 --ggdAeHltlv4tpqCr--
State-Changed-From-To: feedback->closed 
State-Changed-By: gahr 
State-Changed-When: Fri Feb 14 15:27:37 UTC 2014 
State-Changed-Why:  
Won't do. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181747 
>Unformatted:
