From gerald@FreeBSD.org  Sun Sep  1 20:04:51 2013
Return-Path: <gerald@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id B43F3BCA
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Sep 2013 20:04:51 +0000 (UTC)
	(envelope-from gerald@FreeBSD.org)
Received: from ref10-i386.freebsd.org (ref10-i386.freebsd.org [IPv6:2001:1900:2254:206c::16:8a])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id A13ED22E1;
	Sun,  1 Sep 2013 20:04:51 +0000 (UTC)
Received: from ref10-i386.freebsd.org (localhost [127.0.0.1])
	by ref10-i386.freebsd.org (8.14.7/8.14.7) with ESMTP id r81K4pnC001945;
	Sun, 1 Sep 2013 20:04:51 GMT
	(envelope-from gerald@ref10-i386.freebsd.org)
Received: (from gerald@localhost)
	by ref10-i386.freebsd.org (8.14.7/8.14.7/Submit) id r81K4p0S001944;
	Sun, 1 Sep 2013 20:04:51 GMT
	(envelope-from gerald)
Message-Id: <201309012004.r81K4p0S001944@ref10-i386.freebsd.org>
Date: Sun, 1 Sep 2013 20:04:51 GMT
From: Gerald Pfeifer <gerald@pfeifer.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ports-mgmt/portlint: don't stop checks for COMMENT after first warning
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         181730
>Category:       ports
>Synopsis:       ports-mgmt/portlint: don't stop checks for COMMENT after first warning
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bdrewery
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 01 20:10:01 UTC 2013
>Closed-Date:    Sat Oct 12 05:14:56 CDT 2013
>Last-Modified:  Sat Oct 12 10:20:00 UTC 2013
>Originator:     Gerald Pfeifer
>Release:        
>Organization:
>Environment:
>Description:
	Currently portlint stops checking for further issues once
	the first has been found for the COMMENT field in Makefile.
>How-To-Repeat:
	Make COMMENT$of some test port read "a1234567890123456789012345678901234567890123456789012345678901234567890".
	Run portlint.
	See how there is no complaint about the length of the COMMENT.
>Fix:
--- portlint.pl.orig	2013-07-16 12:35:28.823262000 +0000
+++ portlint.pl	2013-09-01 19:59:38.228589000 +0000
@@ -2839,7 +2839,8 @@
 	} else { # check for correctness
 		if (($makevar{COMMENT} !~ /^["\[0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #"
 			&perror("WARN", $file, -1, "COMMENT should begin with a capital, and end without a period");
-		} elsif (length($makevar{COMMENT}) > 70) {
+		} 
+		if (length($makevar{COMMENT}) > 70) {
 			&perror("WARN", $file, -1, "COMMENT exceeds 70 characters limit.");
 		}
 	}
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marcus 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Sep 1 20:10:14 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181730 
Responsible-Changed-From-To: marcus->bdrewery 
Responsible-Changed-By: bdrewery 
Responsible-Changed-When: Sat Oct 12 05:11:34 CDT 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181730 
State-Changed-From-To: open->closed 
State-Changed-By: bdrewery 
State-Changed-When: Sat Oct 12 05:14:55 CDT 2013 
State-Changed-Why:  
Committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181730 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/181730: commit references a PR
Date: Sat, 12 Oct 2013 10:14:49 +0000 (UTC)

 Author: bdrewery
 Date: Sat Oct 12 10:14:41 2013
 New Revision: 330124
 URL: http://svnweb.freebsd.org/changeset/ports/330124
 
 Log:
   - Update to 2.14.5
   
   Changes:
     * Fix recommending to replace USES=gmake with ${GMAKE} [1]
     * Ignore USES when recommending to replace direct commands [1]
     * Fix COMMENT check so it checks for length even if it
       is not formatted properly [2]
   
   PR:		ports/181359 [1]
   Submitted by:	Alan Hicks <ahicks@p-o.co.uk> [1]
   Reported by:	many
   PR:		ports/181730 [2]
   Submitted by:	gerald
   Approved by:	maintainer timeout (> 1 month)
 
 Modified:
   head/ports-mgmt/portlint/Makefile
   head/ports-mgmt/portlint/src/portlint.pl
 
 Modified: head/ports-mgmt/portlint/Makefile
 ==============================================================================
 --- head/ports-mgmt/portlint/Makefile	Sat Oct 12 09:31:18 2013	(r330123)
 +++ head/ports-mgmt/portlint/Makefile	Sat Oct 12 10:14:41 2013	(r330124)
 @@ -2,7 +2,7 @@
  # $FreeBSD$
  
  PORTNAME=	portlint
 -PORTVERSION=	2.14.4
 +PORTVERSION=	2.14.5
  CATEGORIES=	ports-mgmt
  MASTER_SITES=	# none
  DISTFILES=	# none
 
 Modified: head/ports-mgmt/portlint/src/portlint.pl
 ==============================================================================
 --- head/ports-mgmt/portlint/src/portlint.pl	Sat Oct 12 09:31:18 2013	(r330123)
 +++ head/ports-mgmt/portlint/src/portlint.pl	Sat Oct 12 10:14:41 2013	(r330124)
 @@ -1157,11 +1157,11 @@ sub check_depends_syntax {
  					"USES[+]=gettext.");
  			}
  
 -			# check USE_GMAKE
 +			# check USES=gmake
  			if ($m{'dep'} =~ /^(gmake|\${GMAKE})$/) {
  				&perror("WARN", $file, -1, "dependency to $1 ".
  					"listed in $j. consider using ".
 -					"USE_GMAKE.");
 +					"USES[+]=gmake.");
  			}
  
  			# check USE_QT
 @@ -1867,6 +1867,7 @@ ruby sed sh sort sysctl touch tr which x
  				&& $curline !~ /^NO_CDROM(.)?=[^\n]+$i/m
  				&& $curline !~ /^MAINTAINER(.)?=[^\n]+$i/m
  				&& $curline !~ /^CATEGORIES(.)?=[^\n]+$i/m
 +				&& $curline !~ /^USES(.)?=[^\n]+$i/m
  				&& $curline !~ /^WX_COMPS(.)?=[^\n]+$i/m
  				&& $curline !~ /^\s*#.+$/m
  				&& $curline !~ /\-\-$i/m
 @@ -2839,7 +2840,8 @@ MAINTAINER COMMENT
  	} else { # check for correctness
  		if (($makevar{COMMENT} !~ /^["\[0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #"
  			&perror("WARN", $file, -1, "COMMENT should begin with a capital, and end without a period");
 -		} elsif (length($makevar{COMMENT}) > 70) {
 +		}
 +		if (length($makevar{COMMENT}) > 70) {
  			&perror("WARN", $file, -1, "COMMENT exceeds 70 characters limit.");
  		}
  	}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
