From tijl@coosemans.org  Sun Sep  1 19:06:25 2013
Return-Path: <tijl@coosemans.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 1809FBC7
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Sep 2013 19:06:25 +0000 (UTC)
	(envelope-from tijl@coosemans.org)
Received: from mailrelay009.isp.belgacom.be (mailrelay009.isp.belgacom.be [195.238.6.176])
	by mx1.freebsd.org (Postfix) with ESMTP id A5E64201A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Sep 2013 19:06:24 +0000 (UTC)
Received: from 197.77-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.77.197])
  by relay.skynet.be with ESMTP; 01 Sep 2013 21:05:14 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1])
	by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r81J5Da7009685
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 1 Sep 2013 21:05:13 +0200 (CEST)
	(envelope-from tijl@kalimero.tijl.coosemans.org)
Received: (from tijl@localhost)
	by kalimero.tijl.coosemans.org (8.14.7/8.14.7/Submit) id r81J5DZm009684;
	Sun, 1 Sep 2013 21:05:13 +0200 (CEST)
	(envelope-from tijl)
Message-Id: <201309011905.r81J5DZm009684@kalimero.tijl.coosemans.org>
Date: Sun, 1 Sep 2013 21:05:13 +0200 (CEST)
From: Tijl Coosemans <tijl@FreeBSD.org>
Reply-To: Tijl Coosemans <tijl@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] japanese/skkserv: provide default for skkserv_enable
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         181729
>Category:       ports
>Synopsis:       [patch] japanese/skkserv: provide default for skkserv_enable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hrs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 01 19:10:00 UTC 2013
>Closed-Date:    Tue Dec 03 16:06:07 CET 2013
>Last-Modified:  Tue Dec  3 15:10:00 UTC 2013
>Originator:     Tijl Coosemans
>Release:        FreeBSD 10.0-CURRENT i386
>Organization:
>Environment:
>Description:
There's a warning during boot if skkserv_enable isn't defined.
The attached patch provides a default value like other port provided
rc.d scripts do.
>How-To-Repeat:
>Fix:

--- skkserv.patch begins here ---
Index: japanese/skkserv/Makefile
===================================================================
--- japanese/skkserv/Makefile	(revision 325588)
+++ japanese/skkserv/Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	skkserv
 PORTVERSION=	9.6
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	japanese
 MASTER_SITES=	${MASTER_SITE_PORTS_JP}
 DISTNAME=	skk${PORTVERSION}
Index: japanese/skkserv/files/skkserv.in
===================================================================
--- japanese/skkserv/files/skkserv.in	(revision 325588)
+++ japanese/skkserv/files/skkserv.in	(working copy)
@@ -12,6 +12,7 @@ name=skkserv
 rcvar=skkserv_enable
 command=%%PREFIX%%/sbin/skkserv
 
+: ${skkserv_enable:="NO"}
 : ${skkserv_flags:="-a 127.0.0.1 -u skkserv"}
 
 load_rc_config ${name}
--- skkserv.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->hrs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Sep 1 19:10:08 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181729 
State-Changed-From-To: open->closed 
State-Changed-By: tijl 
State-Changed-When: Tue Dec 3 16:05:37 CET 2013 
State-Changed-Why:  
Committed in r335572. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181729 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/181729: commit references a PR
Date: Tue,  3 Dec 2013 15:05:25 +0000 (UTC)

 Author: tijl
 Date: Tue Dec  3 15:05:17 2013
 New Revision: 335572
 URL: http://svnweb.freebsd.org/changeset/ports/335572
 
 Log:
   There's a warning during boot if the skkserv_enable rc variable is
   undefined so set it to "NO" by default.
   
   PR:		ports/181729
   Approved by:	maintainer timeout (3 months)
 
 Modified:
   head/japanese/skkserv/Makefile
   head/japanese/skkserv/files/skkserv.in
 
 Modified: head/japanese/skkserv/Makefile
 ==============================================================================
 --- head/japanese/skkserv/Makefile	Tue Dec  3 14:52:52 2013	(r335571)
 +++ head/japanese/skkserv/Makefile	Tue Dec  3 15:05:17 2013	(r335572)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	skkserv
  PORTVERSION=	9.6
 -PORTREVISION=	5
 +PORTREVISION=	6
  CATEGORIES=	japanese
  MASTER_SITES=	${MASTER_SITE_PORTS_JP}
  DISTNAME=	skk${PORTVERSION}
 
 Modified: head/japanese/skkserv/files/skkserv.in
 ==============================================================================
 --- head/japanese/skkserv/files/skkserv.in	Tue Dec  3 14:52:52 2013	(r335571)
 +++ head/japanese/skkserv/files/skkserv.in	Tue Dec  3 15:05:17 2013	(r335572)
 @@ -12,6 +12,7 @@ name=skkserv
  rcvar=skkserv_enable
  command=%%PREFIX%%/sbin/skkserv
  
 +: ${skkserv_enable:="NO"}
  : ${skkserv_flags:="-a 127.0.0.1 -u skkserv"}
  
  load_rc_config ${name}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
